💬 ryanofsky commented on pull request "depends: Update libmultiprocess library to fix C++20 macos build error":
(https://github.com/bitcoin/bitcoin/pull/29276#issuecomment-1901253716)
There is another macos issue I'm debugging here: https://github.com/chaincodelabs/libmultiprocess/issues/92 and I don't think it shows up in depends builds because the depends build skips tests. But it might trigger errors in bitcoin builds if more code from #10102 is merged.

There is no need to hold off on this PR, but if it is not merged, I will probably update it again with whatever the fix is for https://github.com/chaincodelabs/libmultiprocess/issues/92

I probably need to figure out a
...

💬 eragmus commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1901258102)
> I think this view shows a twisted absolute ignorance of what Bitcoin is about. Different from "crypto", Bitcoin is not an "all purpose DB" neither a 'world computer'. Its scope must be instead, contrary to all the 10000 altcoining misconceptions, and be kept tyranically (Satoshi's used term on this) TINY. Fees in Bitcoin are one of the measures against arbitrary data dumping, and Satoshi mentioned 'OTHER THINGS' that he could do to actually FIGHT it, NOT by any means EVER accept such misuse ou
...

💬 eragmus commented on issue "Witness scripts being abused to bypass datacarriersize limit (CVE-2023-50428)":
(https://github.com/bitcoin/bitcoin/issues/29187#issuecomment-1901272351)
> > Which of these [opcodes](https://en.bitcoin.it/wiki/Script#Opcodes) is not working as implemented or [documented](https://github.com/ChrisCho-H/bitcoin/blob/0bf55345764d22c5653c0a374647aa5582a186a2/src/script/script.h)?
>
> It's not a single opcode that is not working as implemented or documented. It's the whole system that is not behaving as expected.
>
> If you have an API so users of your site can upload pictures for blog posts, and you found that somebody uploaded a 35 GB blueray-r
...

💬 ktecho commented on issue "Witness scripts being abused to bypass datacarriersize limit (CVE-2023-50428)":
(https://github.com/bitcoin/bitcoin/issues/29187#issuecomment-1901286042)
> Bitcoin is a decentralized system that operates based on market incentives, it's not a centralized system. So, that's an apples-to-oranges comparison.

That has nothing to do with what I said. It was designed to be money, and it's being exploited to be used as a general purpose database. That must be fixed.

💬 eragmus commented on issue "Witness scripts being abused to bypass datacarriersize limit (CVE-2023-50428)":
(https://github.com/bitcoin/bitcoin/issues/29187#issuecomment-1901288039)
> > Bitcoin is a decentralized system that operates based on market incentives, it's not a centralized system. So, that's an apples-to-comparison.
>
>
>
> That has nothing to do with what I said. It was designed to be money, and it's being exploited to be used as a general purpose database. That must be fixed.

I responded to what you said:
> If you have an API so users of your site can upload pictures for blog posts, and you found that somebody uploaded a 35 GB blueray-ripped movie, you do s
...

👍 ryanofsky approved a pull request: "kernel: Remove dependency on CScheduler"
(https://github.com/bitcoin/bitcoin/pull/28960#pullrequestreview-1833942330)
Code review ACK f442a3a5b2a0a58bc263fbb9c87e8e4715de103a, but note that linter is failing in https://cirrus-ci.com/task/5386260651442176, I think due to a problem with the scripted-diff command. Only changes since last review were suggested changes (thanks!)

💬 ryanofsky commented on pull request "kernel: Remove dependency on CScheduler":
(https://github.com/bitcoin/bitcoin/pull/28960#discussion_r1459989847)
re: https://github.com/bitcoin/bitcoin/pull/28960#discussion_r1459279757

[Pointer-to-implementation](https://en.cppreference.com/w/cpp/language/pimpl) is a c++ specific pattern. It's a simple trick to divide a *single* class into two halves so that the private parts of the class are in the .cpp file rather than the .h file. It doesn't have to do with SOLID principles or object oriented design.

The typical way to define a class in c++ is

```
class MyClass
{
public:
// MyClass publ
...

💬 GONNAGITU72 commented on issue "Witness scripts being abused to bypass datacarriersize limit (CVE-2023-50428)":
(https://github.com/bitcoin/bitcoin/issues/29187#issuecomment-1901657859)
https://github.com/coinbase/waas-sdk-react-native

💬 RobinLinus commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1901699658)
> to dictate to the economy what it should or should not do

@RicYashiroLee your post reads as if you have missed that the [spammer himself](https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1667208040) publicly states that their transactions are a spam attack.
Of course, one can question the effectiveness of the spam mitigation proposed here, but it's pretty absurd trying to argue that this spam would not be an attack even though the attacker is bragging about his attack in intervi
...

💬 ns-xvrn commented on pull request "test: Add test case for spending bare multisig":
(https://github.com/bitcoin/bitcoin/pull/29120#issuecomment-1901721335)
I compiled with https://github.com/bitcoin/bitcoin/pull/28217, which sets default value of `permitbaremultisig` to false in `policy.h` and tried to run this test case with `'allowed': False` for expected result but the test fails.
I would have expected that one to pass the test.

⚠️ ns-xvrn opened an issue: "Policy: disallow P2PK transactions from relaying by default"
(https://github.com/bitcoin/bitcoin/issues/29285)
### Please describe the feature you'd like to see added.

P2PK transactions are obsolete so adding a default policy that disallows such transactions from relaying by default should be considered at this point. This only disallows **future** outputs from relaying by default.

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

- `permit_bare_pubkey` conf setting with default value of `0` that can disallow(switch) bare pubkey tr
...

⚠️ freezoloto opened an issue: "berkeley database failed to open database environment"
(https://github.com/bitcoin/bitcoin/issues/29286)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Hello, I installed a new wallet for myself, the blocks started updating to the latest version, but suddenly the computer rebooted and now I can’t open my wallet. The error appears: "berkeley database failed to open database environment"


### Expected behaviour

Hello, I instal
...

💬 freezoloto commented on issue "berkeley database failed to open database environment":
(https://github.com/bitcoin/bitcoin/issues/29286#issuecomment-1901943405)

🤔 jarolrod reviewed a pull request: "depends: Update libmultiprocess library to fix C++20 macos build error"
(https://github.com/bitcoin/bitcoin/pull/29276#pullrequestreview-1834644340)
ACK 5dfd24581a7c5497601966a5371d8c33eabcee8a

This fixes the build issue.

💬 TheCharlatan commented on pull request "kernel: Remove dependency on CScheduler":
(https://github.com/bitcoin/bitcoin/pull/28960#issuecomment-1902037507)
Thank you @ryanofsky,

Updated f442a3a5b2a0a58bc263fbb9c87e8e4715de103a -> 38e25f67b4b2aeb3dd13f4f9ffa689f47718aa17 ([noGlobalSignals_7](https://github.com/TheCharlatan/bitcoin/tree/noGlobalSignals_7) -> [noGlobalSignals_8](https://github.com/TheCharlatan/bitcoin/tree/noGlobalSignals_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/noGlobalSignals_7..noGlobalSignals_8))

* Fixup scripted-diff
* Addressed @ryanofsky's [comment](https://github.com/bitcoin/bitcoin/pull/28960#discu
...

💬 TheCharlatan commented on pull request "kernel: Remove dependency on CScheduler":
(https://github.com/bitcoin/bitcoin/pull/28960#issuecomment-1902062244)
Updated 38e25f67b4b2aeb3dd13f4f9ffa689f47718aa17 -> 22048c19e236e4b683f1c8192883545d5c68f793 ([noGlobalSignals_8](https://github.com/TheCharlatan/bitcoin/tree/noGlobalSignals_8) -> [noGlobalSignals_9](https://github.com/TheCharlatan/bitcoin/tree/noGlobalSignals_9), [compare](https://github.com/TheCharlatan/bitcoin/compare/noGlobalSignals_8..noGlobalSignals_9))

* Improved scripted-diff to exclude renaming a method.

💬 remyers commented on pull request "wallet: fix coin selection tracing to return -1 when no change pos":
(https://github.com/bitcoin/bitcoin/pull/29272#discussion_r1460372757)
Fixed in [39d8621](https://github.com/bitcoin/bitcoin/pull/29272/commits/39d8621b0f3e9b20898278be35922ddab09683a3). I also updated the description to make it clearer that the APS path is tested due to APS being initially disabled.

💬 remyers commented on pull request "wallet: fix coin selection tracing to return -1 when no change pos":
(https://github.com/bitcoin/bitcoin/pull/29272#discussion_r1460385240)
This seems like a good practice and is consistent with other TRACEx uses in the code where x > 1. This would also makes it easier to check the correct number of parameters is used if PR #26593 is adopted. Fixed in [a32af4c](https://github.com/bitcoin/bitcoin/pull/29272/commits/a32af4c2593aa2cff49b6c6afeeba6c1681b5b45).

💬 0xB10C commented on issue "Policy: disallow P2PK transactions from relaying by default":
(https://github.com/bitcoin/bitcoin/issues/29285#issuecomment-1902073997)
fwiw: here are some P2PK usage numbers https://transactionfee.info/charts/inputs-and-outputs-p2pk/?start=2019-01-01

The blue line (P2PK outputs being spent) is what's relevant here.

📝 hebasto opened a pull request: "depends: Do not override `CFLAGS` when building SQLite with `DEBUG=1`"
(https://github.com/bitcoin/bitcoin/pull/29287)
The `--enable-debug` configure option for the SQLite package does two things:
```autoconf
#-----------------------------------------------------------------------
# --enable-debug
#
AC_ARG_ENABLE(debug, [AS_HELP_STRING(
[--enable-debug], [build with debugging features enabled [default=no]])],
[], [])
AC_MSG_CHECKING([Build type])
if test x"$enable_debug" = "xyes"; then
BUILD_CFLAGS="$BUILD_CFLAGS -DSQLITE_DEBUG -DSQLITE_ENABLE_SELECTTRACE -DSQLITE_ENABLE_WHERETRACE"
CFLAGS=
...