💬 ariard commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1897677061)
Let's do the anti-pinning analysis with the most restrictve package vbyte size:
- 1 commitment tx 268 bytes
- 1 child 1kb

Package size: 1268 bytes.

This is assuming a commitment tx with only 1 HTLC output at max.

With mempool backlog superior to 20 sat/byte and depth=`cltv_expiry_delta`, one can pin 25k sats payment.
Adversary cost: 5360 (commitment tx fee) + 1000 (child rbf-penalty) + 43 (channel opening output)
Adversary gain (per-channel): 18597 satoshis.

If we reduce the size
...

⚠️ YezikTech opened an issue: "Lupe Fiasco - Superstar (Live Lounge 3)"
(https://github.com/bitcoin/bitcoin/issues/29268)
https://youtu.be/9TMmPEfRjhs?si=nXqKYFGQcEUvfZ4Z

✅ achow101 closed an issue: "Lupe Fiasco - Superstar (Live Lounge 3)"
(https://github.com/bitcoin/bitcoin/issues/29268)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29268)

💬 kevkevinpal commented on pull request "test: Remove all-lint.py script":
(https://github.com/bitcoin/bitcoin/pull/29228#issuecomment-1897749450)
ACK [fa2b95c](https://github.com/bitcoin/bitcoin/pull/29228/commits/fa2b95cf3f5148d27a8fd4fb3763ca1fc139bdd9)

💬 ajtowns commented on pull request "Add leaf_version parameter to `IsOpSuccess()`":
(https://github.com/bitcoin/bitcoin/pull/29265#issuecomment-1897763095)
> Small quibble here, there are other consensus PRs out there that probably would need this change ( #29247 , #29050 , #28550 ).

While they're just drafts, they can just each include the commit; DrahtBot will report them as conflicting, but that's not big deal.

If/when it becomes apparent that there's wide consensus in favour of adopting/merging/activating one or more of the changes, we can pull that commit out as a preparatory step prior to the consensus changes. Compare with #16902 or #1
...

💬 petertodd commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1897791032)
> However no, it doesn't solve all the pinning scenarios in my opinion

Notably, from the discussion I see on delvingbitcoin, it appears that V3 transactions are *not* intended to be used for HTLC-x transactions. Which means they'll remain pinnable, due to the `SIGHASH_ANYONECANPAY` signatures, allowing anyone to turn them into large, pinned, high fee/low fee-rate transactions by adding additional inputs (and outputs).

📝 reardencode opened a pull request: "Add OP_INTERNALKEY for Tapscript"
(https://github.com/bitcoin/bitcoin/pull/29269)
Testing is minimal, but so is the code.

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any
...

📝 reardencode opened a pull request: "Implement OP_CHECKSIGFROMSTACK(VERIFY)"
(https://github.com/bitcoin/bitcoin/pull/29270)
Some code and ideas from Elements by stevenroose, and sanket1729 Porting help from moonsettler

Tests added to the transaction tests framework.

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain h
...

⚠️ matidau opened an issue: "The following table ifc"
(https://github.com/bitcoin/bitcoin/issues/29271)

✅ maflcko closed an issue: "The following table ifc"
(https://github.com/bitcoin/bitcoin/issues/29271)

📝 remyers opened a pull request: "wallet: fix coin selection tracing to return -1 when no change pos"
(https://github.com/bitcoin/bitcoin/pull/29272)
This is a bugfix for from when [optional was introduced](https://github.com/bitcoin/bitcoin/pull/25273/commits/758501b71391136c33b525b1a0109b990d4f463e) for `change_pos` in the wallet. When optional `change_pos` is unset, we should return -1 and not 0.

I added two new checks to the `test/functional/interface_usdt_coinselection.py` which adds coverage for the situations when `normal_create_tx_internal` and `aps_create_tx_internal` events occur with no change.

You can reproduce this bug u
...

💬 remyers commented on pull request "wallet: fix coin selection tracing to return -1 when no change pos":
(https://github.com/bitcoin/bitcoin/pull/29272#issuecomment-1897978185)
You might want to take a look at this @murchandamus. I discovered the problem while trying to repo your coingrinder results with the coin-selection-simulation scripts.

👍 TheCharlatan approved a pull request: "build: always set `-g -O2` in `CORE_CXXFLAGS`"
(https://github.com/bitcoin/bitcoin/pull/29205#pullrequestreview-1829103258)
lgtm ACK 00c1e2aa4496b5f038ae5199dbd16d8313766533

⚠️ ri131211 opened an issue: "Hello"
(https://github.com/bitcoin/bitcoin/issues/29273)

✅ fanquake closed an issue: "Hello"
(https://github.com/bitcoin/bitcoin/issues/29273)

:lock: fanquake locked an issue: "Hello"
(https://github.com/bitcoin/bitcoin/issues/29273)

💬 0xB10C commented on pull request "wallet: fix coin selection tracing to return -1 when no change pos":
(https://github.com/bitcoin/bitcoin/pull/29272#discussion_r1457097947)
nit: I think this tracepoint would be easier to reason about if it was one line per argument. Not sure if this PR is the right place to reformat it.

💬 vasild commented on pull request "Fuzz: extend CConnman tests":
(https://github.com/bitcoin/bitcoin/pull/28584#issuecomment-1898030061)
`20a9fc83bd...cd5bbb12e0`: rebase due to conflicts

💬 0xB10C commented on pull request "wallet: fix coin selection tracing to return -1 when no change pos":
(https://github.com/bitcoin/bitcoin/pull/29272#discussion_r1457111240)
```
(mocktwallet/spend.cpp:1339:5: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'unsigned int' changed the value to 4294967295 (32-bit, unsigned)
#0 0x5589c92846e6 in wallet::CreateTransaction(wallet::CWallet&, std::vector<wallet::CRecipient, std::allocator<wallet::CRecipient>> const&, std::optional<unsigned int>, wallet::CCoinControl const&, bool) src/wallet/spend.cpp:1339:5
#1 0x5589c8d8617d in wallet::spend_tests::wallet_duplicated_preset_
...