💬 TheCharlatan commented on pull request "kernel: Remove dependency on CScheduler":
(https://github.com/bitcoin/bitcoin/pull/28960#discussion_r1454918683)
Ah, I think we need the full declaration here, because other modules are now instantiating the `CMainSignals`.

💬 TheCharlatan commented on pull request "contrib: Add -binary option to clang-format-diff":
(https://github.com/bitcoin/bitcoin/pull/29251#issuecomment-1895327695)
Updated c7cb63a12e1a90fe46471cca4001a472078b5ccf -> 008e81e025d64c33e1e71b5a2fe63dfdf6b31437 ([ClangFormatDiffBinaryOption_0](https://github.com/TheCharlatan/bitcoin/tree/ClangFormatDiffBinaryOption_0) -> [ClangFormatDiffBinaryOption_1](https://github.com/TheCharlatan/bitcoin/tree/ClangFormatDiffBinaryOption_1), [compare](https://github.com/TheCharlatan/bitcoin/compare/ClangFormatDiffBinaryOption_0..ClangFormatDiffBinaryOption_1))

* Addressed @maflcko's [comment](https://github.com/bitcoin/bi
...

💬 maflcko commented on issue "Unable to sync blockchain on laptop: ERROR: ReadBlockFromDisk: Deserialize or I/O error":
(https://github.com/bitcoin/bitcoin/issues/29255#issuecomment-1895368323)
Which filesystem is the blocks directory on?

Otherwise, this may be due to overheating, which will only happen under CPU load, and not if a mere filesystem check tool is run.

💬 maflcko commented on pull request "kernel: Remove key module from kernel library":
(https://github.com/bitcoin/bitcoin/pull/29252#issuecomment-1895372210)
lgtm ACK a885a166cec6d84d08600f12b25d912bd28af80e 🔀

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: lgtm ACK a885a166cec6d84d
...

💬 Xaspr commented on issue "Unable to sync blockchain on laptop: ERROR: ReadBlockFromDisk: Deserialize or I/O error":
(https://github.com/bitcoin/bitcoin/issues/29255#issuecomment-1895417277)
The whole SSD is just 1 partition in NTFS. There are no other drives.

I'll look into overheating as well.

By the way, v24.2 crashed after about 4 hours. Now looking into trying v26.0.0 with antivirus software disabled.

💬 maflcko commented on pull request "contrib: Update clang-format-diff":
(https://github.com/bitcoin/bitcoin/pull/29251#issuecomment-1895452236)
You'd have to fixup the linter in one way or another. I think it would be fine to add a commit to modify the script in the two places, or add an exclusion, or something else.

💬 willcl-ark commented on issue "Failed loading mempool when restarting bitcoind":
(https://github.com/bitcoin/bitcoin/issues/29193#issuecomment-1895492040)
Is there anything actionable left here to be done or can we close this out?

IIUC this mempool was not given enough time to load after restart, but now in addition to `getmempoolinfo` we have logging from #29227.

I have increased my `maxmempoolsize` to see if I can try and re-create the issue, but have only tried loading a 600MB one so far, which was successful and took < 6 minutes:

```log
$ grep mempool debug.log
2024-01-17T09:57:40Z Config file arg: [main] maxmempool="2000"
2024-01-
...

👍 TheCharlatan approved a pull request: "build: depends move macOS C(XX) FLAGS out of C & CXX"
(https://github.com/bitcoin/bitcoin/pull/29233#pullrequestreview-1826943317)
ACK cbc9bf11fe84deb96daf9b97a8e7499979360db2

Guix build (x86):
```
94d2fe95101baf9ba74e5c1be6a93708bd55b3700567c768e72ceb4af4951bb9 guix-build-cbc9bf11fe84/output/aarch64-linux-gnu/SHA256SUMS.part
3cacc8c3d726e78b1db8ea07c25186e589f32c991cd7fd45d4390135adf199f2 guix-build-cbc9bf11fe84/output/aarch64-linux-gnu/bitcoin-cbc9bf11fe84-aarch64-linux-gnu-debug.tar.gz
39f42920ea452ea67f0f8df3199c50d73660009368fccfab900204d27b8e50cc guix-build-cbc9bf11fe84/output/aarch64-linux-gnu/bitcoin-cbc9b
...

💬 TheCharlatan commented on pull request "contrib: Update clang-format-diff":
(https://github.com/bitcoin/bitcoin/pull/29251#issuecomment-1895501411)
Updated 008e81e025d64c33e1e71b5a2fe63dfdf6b31437 -> 52149b7a2c2b48ed4a4c0900c74cda4bb52a1ea5 ([ClangFormatDiffBinaryOption_1](https://github.com/TheCharlatan/bitcoin/tree/ClangFormatDiffBinaryOption_1) -> [ClangFormatDiffBinaryOption_2](https://github.com/TheCharlatan/bitcoin/tree/ClangFormatDiffBinaryOption_2), [compare](https://github.com/TheCharlatan/bitcoin/compare/ClangFormatDiffBinaryOption_1..ClangFormatDiffBinaryOption_2))


* Added a commit fixing the lint errors by removing a python
...

💬 Sjors commented on pull request "build: depends move macOS C(XX) FLAGS out of C & CXX":
(https://github.com/bitcoin/bitcoin/pull/29233#issuecomment-1895512452)
Guix build on Ubuntu AMD:

```
94d2fe95101baf9ba74e5c1be6a93708bd55b3700567c768e72ceb4af4951bb9 guix-build-cbc9bf11fe84/output/aarch64-linux-gnu/SHA256SUMS.part
3cacc8c3d726e78b1db8ea07c25186e589f32c991cd7fd45d4390135adf199f2 guix-build-cbc9bf11fe84/output/aarch64-linux-gnu/bitcoin-cbc9bf11fe84-aarch64-linux-gnu-debug.tar.gz
39f42920ea452ea67f0f8df3199c50d73660009368fccfab900204d27b8e50cc guix-build-cbc9bf11fe84/output/aarch64-linux-gnu/bitcoin-cbc9bf11fe84-aarch64-linux-gnu.tar.gz
dc1a
...

💬 willcl-ark commented on issue "./bitcoin.conf file should not cause confusion with ./datadir/bitcoin.conf":
(https://github.com/bitcoin/bitcoin/issues/29139#issuecomment-1895518581)
Perhaps the best solution is simply to move the example conf back inside `share/examples/bitcoin.conf` in the release tar, as we have it here in the repo? That way if people unzip-to-dir which I assume is how it's usually done?, the example conf also won't be floating loosely inside `/usr/local`:

```bash
# Check contents
tar -tzvf bitcoin-26.0-x86_64-linux-gnu.tar.gz
# Unzip directly to /usr/local
sudo tar -xzvf bitcoin-26.0-x86_64-linux-gnu.tar.gz -C /usr/local/
```

IMO folks looking
...

💬 glozow commented on issue "Failed loading mempool when restarting bitcoind":
(https://github.com/bitcoin/bitcoin/issues/29193#issuecomment-1895531724)
+1 @dev7ba there's not much to go on without logs. Maybe open another report with more information if it happens again?

🚀 fanquake merged a pull request: "build: depends move macOS C(XX) FLAGS out of C & CXX"
(https://github.com/bitcoin/bitcoin/pull/29233)

✅ willcl-ark closed an issue: "Failed loading mempool when restarting bitcoind"
(https://github.com/bitcoin/bitcoin/issues/29193)

💬 willcl-ark commented on issue "Failed loading mempool when restarting bitcoind":
(https://github.com/bitcoin/bitcoin/issues/29193#issuecomment-1895555239)
OK let's close for now then.

@dev7ba feel free to ping me in here, or open a new issue if this happens again or you have new information.

📝 Sjors opened a pull request: "Support self hosted Github workers on forks"
(https://github.com/bitcoin/bitcoin/pull/29259)
I find myself making pull requests against my fork (mostly on top of #28983), or asking others to do so. Since I don't want to splurge on a Cirrus account, and since Github free minutes are limited, I looked into how self hosted runners work on Github.

You can see this PR in action on this pull request to my fork: https://github.com/Sjors/bitcoin/actions/runs/7554260507

To test it yourself, spin up one or more [self hosted runners](https://docs.github.com/en/actions/hosting-your-own-runner
...

💬 glozow commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1895559493)
Please rebase. See contributing guidelines https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes.

💬 fanquake commented on issue "ci: failure in `wallet_basic.py --descriptors`":
(https://github.com/bitcoin/bitcoin/issues/29110#issuecomment-1895578477)
https://cirrus-ci.com/task/6509037848625152?logs=ci#L2502

💬 Retropex commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1895579012)
> Please rebase.

Rebased.

💬 moonsettler commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1895601881)
> Concept ACK, what will it take to get this merged? Stamps are absolutely ravaging the UTXO set.

what do we mean by ravaging? afaik the biggest unnecessary bloater of the UTXO set is the stacks protocol.