💬 jonatack commented on pull request "Severity-based logging -- parent PR":
(https://github.com/bitcoin/bitcoin/pull/25203#discussion_r1449164398)
Noting here that this change was done in #28318, resolving.

💬 jonatack commented on pull request "logging: Simplify API for level based logging":
(https://github.com/bitcoin/bitcoin/pull/28318#discussion_r1449165848)
Possibly relevant comment: [`118c756` (#25203)](https://github.com/bitcoin/bitcoin/pull/25203/commits/118c7567f62df2b882877590f232242d7c627a05#r975577418)

💬 achow101 commented on pull request "test: detect OS in functional tests consistently using `platform.system()`":
(https://github.com/bitcoin/bitcoin/pull/29034#issuecomment-1887610930)
ACK 878d914777a03a04ecb84217152e8b7fd73a5062

🚀 achow101 merged a pull request: "test: detect OS in functional tests consistently using `platform.system()`"
(https://github.com/bitcoin/bitcoin/pull/29034)

📝 fanquake opened a pull request: "build: depends move macOS C(XX) FLAGS out of C & CXX"
(https://github.com/bitcoin/bitcoin/pull/29233)
Move some C/CXX FLAGS out of C/CXX. The remaining flags are host/SDK related, and will need some more thought.
This is more correct in any case, and simplifies future changes.
Related to #21778.

⚠️ fanquake opened an issue: "ci: failure in `wallet_assumeutxo.py --descriptors`"
(https://github.com/bitcoin/bitcoin/issues/29234)
Merged in #28838. Seems to be failing on all MSVC CI jobs.

https://github.com/bitcoin/bitcoin/actions/runs/7492122146/job/20394956531?pr=29232#step:27:7862:
```bash
test 2024-01-11T17:24:30.783000Z TestFramework (INFO): Backup can't be loaded during background sync
test 2024-01-11T17:24:30.783000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "D:\a\bitcoin\bitcoin\test\functio
...

💬 achow101 commented on pull request "Fix -netinfo backward compat with getpeerinfo pre-v26":
(https://github.com/bitcoin/bitcoin/pull/29212#issuecomment-1887649774)
ACK 5fa74609b833643334dfb5519f2023119984267b

👍 fanquake approved a pull request: "build: Bump clang minimum supported version to 14"
(https://github.com/bitcoin/bitcoin/pull/29208#pullrequestreview-1816134091)
ACK aaaace2fd1299939c755c281b787df0bbf1747a0

💬 cecuabin commented on issue "Enable `maxfeerate` and `maxburnamount` as startup config options.":
(https://github.com/bitcoin/bitcoin/issues/29217#issuecomment-1887678912)
2(d11ts1)/1^-b^^-2/9 + ddx(Ass.V).dmb
R2 = rm^2 + 2/1 (oh^-eipi^n2-2*mf.rsc
n^3x.u'/ r^2, 64pi rnt?d3/4*.int
-L^2 = 0rc . g3/2pi / Am^-pu.u*.lk
z = r^2 v^2 - 2*.zip
3+1/2Nmf = -Aq' . 1/2hco.dnc
Trc . dt^2 = oH
OH = 5Tu' . 3/5q^2
dryHe = Frv^vu^2
10KT = / . 2/1 Api/-pu.ucc
DM = ds^5/4 - pu^-2mû'. -hu!
arcsen^2 = Apu'-mf'/1
5/0- . Mo - ddt^2E = GEo . Q^nk . pEc - Ec2
dt = 3/2j - dc2 . t^h + KPR+-4/27
mu^2 = -t^2 + arcsen r^216pirsc^-2/1
s = -2/1 rsc^2 - TKqu' +DEc
o = -pmiEc't^3/2
...

🚀 achow101 merged a pull request: "Fix -netinfo backward compat with getpeerinfo pre-v26"
(https://github.com/bitcoin/bitcoin/pull/29212)

📝 fanquake opened a pull request: "doc: refer to "Node relay options" in policy/README"
(https://github.com/bitcoin/bitcoin/pull/29235)
Fixed up #29095, to refer to `-help`, rather than listing every option.

✅ fanquake closed a pull request: "Update doc/policy/README.md"
(https://github.com/bitcoin/bitcoin/pull/29095)

💬 fanquake commented on pull request "Update doc/policy/README.md":
(https://github.com/bitcoin/bitcoin/pull/29095#issuecomment-1887707194)
Cherry-picked into #29235.

💬 fanquake commented on pull request "build: Remove HAVE_CONSENSUS_LIB":
(https://github.com/bitcoin/bitcoin/pull/29123#issuecomment-1887708435)
Maybe draft for now, while we hash out #29189?

📝 maflcko opened a pull request: "log: Nuke error(...)"
(https://github.com/bitcoin/bitcoin/pull/29236)
`error(...)` has many issues:

* It is often used in the context of `return error(...)`, implying that it has a "fancy" type, creating confusing with `util::Result/Error`
* `-logsourcelocations` does not work with it, because it will pretend the error happened inside of `logging.h`
* The log line contains `ERROR: `, as opposed to `[error]`, like for other errors logged with `LogError`.

Fix all issues by removing it.

💬 fanquake commented on pull request "libconsensus: adapt API header to be compliant to ANSI C":
(https://github.com/bitcoin/bitcoin/pull/28661#issuecomment-1887738422)
Could draft for now, dependant on the outcome of #29189?

💬 mzumsande commented on pull request "log mempool loading progress":
(https://github.com/bitcoin/bitcoin/pull/29227#issuecomment-1887747143)
Concept ACK. I remember being surprised in the past that >5 minutes after starting up the node, my mempool was still loading.

📝 alfonsoromanz opened a pull request: "[depends] Allow PATH with spaces in directory names."
(https://github.com/bitcoin/bitcoin/pull/29237)
The goal of this PR is to help close https://github.com/bitcoin/bitcoin/pull/28733. I reverted the change on `depends/config.guess` based on the feedback provided in the previous PR. I've also incorporated the test mentioned by @maflcko

💬 alfonsoromanz commented on pull request "depends: Allow PATH with spaces in directory names.":
(https://github.com/bitcoin/bitcoin/pull/28733#issuecomment-1887761563)
Hi @maflcko! I opened this PR for this issue: https://github.com/bitcoin/bitcoin/pull/29237

✅ fanquake closed a pull request: "depends: Allow PATH with spaces in directory names."
(https://github.com/bitcoin/bitcoin/pull/28733)