📝 pablomartin4btc opened a pull request: "httpserver, rest: fix segmentation fault on evhttp_uri_get_query"
(https://github.com/bitcoin/bitcoin/pull/27253)
The issue is that an invalid uri parsed by `evhttp_uri_parse()`(part of the [libevent open-source project]( https://github.com/libevent/libevent.)) which result (NULL/ nullptr) is sent to `evhttp_uri_get_query()` will produce a segmentation fault.

https://github.com/bitcoin-core/gui/blob/86bacd75e76eff207ef8f7bdb897365f5b6e7b6b/src/httpserver.cpp#L673-L676

In order to reproduce the issue:
1. Start `bitcoind -rest`.
2. Get a block hash (e.g.: `./src/bitcoin-cli getbestblockhash`).
3. Exe
...

🚀 fanquake merged a pull request: "refactor: Split logging utilities from system.h"
(https://github.com/bitcoin/bitcoin/pull/27238)

💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1135206140)
Are you sure? I tested my proposed change locally.

💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1135213207)
Looks like it throws `test_framework.authproxy.JSONRPCException: Error: the wallet is currently being used to rescan the blockchain for related transactions. Please call `abortrescan` before locking the wallet. (-4)`, which can be caught by `assert_raises_rpc_error`?

💬 glozow commented on pull request "mempool: Add mempool tracepoints":
(https://github.com/bitcoin/bitcoin/pull/26531#discussion_r1119840003)
I have a question about reusing an event name, i.e. for rejections in packages (in a future PR) could/should we add a `TRACE2(mempool, rejected, txhash, reason)` or `TRACE3(mempool, rejected, txhash, pkghash, reason)` in the package rejection code? Or should we use a different `event`?

🚀 hebasto merged a pull request: "Mask values on Transactions View"
(https://github.com/bitcoin-core/gui/pull/708)

📝 TheCharlatan opened a pull request: "refactor: Extract util/fs from util/system"
(https://github.com/bitcoin/bitcoin/pull/27254)
This pull request is part of the `libbitcoinkernel` project https://github.com/bitcoin/bitcoin/issues/24303 https://github.com/bitcoin/bitcoin/projects/18 and more specifically its "Step 2: Decouple most non-consensus code from libbitcoinkernel". This commit was originally authored by @empact and are taken from their parent PR #25152.

#### Context

There is an ongoing effort to decouple the `ArgsManager` used for command line parsing user-provided arguments from the libbitcoinkernel library
...

💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1467916011)
Rebased a7afa98ca38fd66fc69b77b95a6a57d50207911b -> 45048c0d7e0ee12210d226239fb5ce63d9ed4441 ([tc/2022-09-libbitcoinkernel-chainparams-args_5](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_5) -> [tc/2022-09-libbitcoinkernel-chainparams-args_6](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_6), [compare](https://github.com/TheCharlatan/bitcoin/compare/tc/2022-09-libbitcoinkernel-chainparams-args_5..tc/202
...

💬 MarcoFalke commented on pull request "refactor: Extract util/fs from util/system":
(https://github.com/bitcoin/bitcoin/pull/27254#discussion_r1135396391)
```suggestion
#include <cstdint>
#include <cstdio>
```

nit

💬 MarcoFalke commented on pull request "refactor: Extract util/fs from util/system":
(https://github.com/bitcoin/bitcoin/pull/27254#discussion_r1135397641)
unrelated change?

💬 fanquake commented on pull request "refactor: Extract util/fs from util/system":
(https://github.com/bitcoin/bitcoin/pull/27254#discussion_r1135402195)
nit: missing newline

💬 TheCharlatan commented on pull request "refactor: Extract util/fs from util/system":
(https://github.com/bitcoin/bitcoin/pull/27254#discussion_r1135404419)
This is from clang format diff. Should I drop these kind of changes in the future? There are also some other not strictly related include order fixes.

💬 fanquake commented on pull request "refactor: Extract util/fs from util/system":
(https://github.com/bitcoin/bitcoin/pull/27254#discussion_r1135405169)
Pretty sure this can just be merged into the includes below.

💬 fanquake commented on pull request "refactor: Extract util/fs from util/system":
(https://github.com/bitcoin/bitcoin/pull/27254#discussion_r1135406000)
I think include fixing is fine. However theres no need to include unrelated clang-format changes.

💬 MarcoFalke commented on pull request "refactor: Extract util/fs from util/system":
(https://github.com/bitcoin/bitcoin/pull/27254#discussion_r1135406385)
You'll need to set `-U0` for the context to avoid unrelated changes, no?

💬 fanquake commented on pull request "refactor: Split util/system into exception, shell, and fs-specific files":
(https://github.com/bitcoin/bitcoin/pull/25152#issuecomment-1467936449)
Going to close this for now, given that it's being split out, and there's a [thumbs up from the author above](https://github.com/bitcoin/bitcoin/pull/25152#issuecomment-1458326647).

✅ fanquake closed a pull request: "refactor: Split util/system into exception, shell, and fs-specific files"
(https://github.com/bitcoin/bitcoin/pull/25152)

💬 TheCharlatan commented on pull request "refactor: Extract util/fs from util/system":
(https://github.com/bitcoin/bitcoin/pull/27254#discussion_r1135417534)
I'm formatting each commit with `git diff -U0 HEAD~1.. | ./contrib/devtools/clang-format-diff.py -p1 -i -v`. I think I must have included this unrelated change somewhere. Will fix.

💬 0xB10C commented on pull request "Add feerate histogram to getmempoolinfo":
(https://github.com/bitcoin/bitcoin/pull/21422#issuecomment-1467960000)
> > Could a tracepoints approach, similar to #26531, work?
>
> I need to research that in detail but it looks promising. Thank you for sharing it here!

I don't think tracepoints are suited for this use-case. Tracepoints allow you to react to a specific event. Here, you request / pull data when a consumer needs it.

> So what would be your approach to do it externally then? Especially if you want to get this information more often.

You can query the `getrawmempool` RPC with the verbose
...

💬 TheCharlatan commented on pull request "refactor: Extract util/fs from util/system":
(https://github.com/bitcoin/bitcoin/pull/27254#issuecomment-1467983104)
Thanks for the review!

Updated b67efe778d4e4ad359fb8dccea7f92e17d1b1f95 -> ea278094e9937bf96157161941d38a0c08a0aa4e ([splitSystemFs_0](https://github.com/TheCharlatan/bitcoin/commits/splitSystemFs_0) -> [splitSystemFs_1](https://github.com/TheCharlatan/bitcoin/commits/splitSystemFs_1), [compare](https://github.com/TheCharlatan/bitcoin/compare/splitSystemFs_0..splitSystemFs_1)) to address review comments.