💬 glozow commented on pull request "test: wallet rescan with reorged parent + IsFromMe child in mempool":
(https://github.com/bitcoin/bitcoin/pull/29179#issuecomment-1880584066)
> Pre-review note: have you considered that wallet_import_rescan.py is a legacy wallet only test?

Ah good point. I added a commit to run this test with descriptors as I couldn't find a reason why we don't do this. Lmk if this seems sufficient / ok to do?

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1444359148)
taken

👍 brunoerg approved a pull request: "net: create I2P sessions using both ECIES-X25519 and ElGamal encryption"
(https://github.com/bitcoin/bitcoin/pull/29200#pullrequestreview-1808534184)
crACK 9d728916b27e18efc6f8839770ed5ec14789fc08

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1444359693)
I've added an `Assume` checking that there is a v3 tx in the package and exiting early if not

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1444359794)
taken

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1444359931)
taken

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1444360019)
fixed

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1444360107)
taken, thanks

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1444360587)
because otherwise it is always 0

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1444360834)
taken

✅ glozow closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29201)

:lock: fanquake locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29201)

💬 maflcko commented on pull request "test: Treat msg_version.relay as unsigned, Remove `struct` packing in messages.py":
(https://github.com/bitcoin/bitcoin/pull/29067#issuecomment-1880721233)
> over int.from_bytes(bs, "little")

In python3.11, one could also write `int.from_bytes(bs)` for single-byte conversions.

💬 glozow commented on pull request "mempool / rpc: followup to getprioritisedtransactions and delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/28885#issuecomment-1880722797)
Still working on this? I'll be available to re-review quickly after comments are addressed.

💬 maflcko commented on pull request "ci: Switch native macOS CI job to Xcode 15.0":
(https://github.com/bitcoin/bitcoin/pull/29195#issuecomment-1880726651)
pull title should be "build: Fix -Xclang -internal-isystem option"? Otherwise lgtm

💬 hebasto commented on pull request "build: Fix `-Xclang -internal-isystem` option":
(https://github.com/bitcoin/bitcoin/pull/29195#issuecomment-1880728913)
> pull title should be "build: Fix -Xclang -internal-isystem option"? Otherwise lgtm

Done.

💬 fanquake commented on pull request "build: Fix `-Xclang -internal-isystem` option":
(https://github.com/bitcoin/bitcoin/pull/29195#issuecomment-1880736065)
> The same Xcode version is used for the release binaries.

Can probably drop this, or be more specific, because we don't use Xcode to build release binaries (only the SDK, which is versioned differently).

💬 fanquake commented on pull request "ci: Do not set inane value for `LD_LIBRARY_PATH`":
(https://github.com/bitcoin/bitcoin/pull/29196#issuecomment-1880740854)
> For example, in the native macOS CI job,

Unless there's a downside to having this set, I don't think it's worth the extra code / shellcheck exceptions. i.e in this example, ld64 will never read this ENV var?

💬 hebasto commented on pull request "build: Fix `-Xclang -internal-isystem` option":
(https://github.com/bitcoin/bitcoin/pull/29195#issuecomment-1880740932)
> > The same Xcode version is used for the release binaries.
>
> Can probably drop this, or be more specific, because we don't use Xcode to build release binaries (only the SDK, which is versioned differently).

Dropped.

🚀 glozow merged a pull request: "RPC/Blockchain: scanblocks: Accept named param for filter_false_positives"
(https://github.com/bitcoin/bitcoin/pull/29184)