👍 TheCharlatan approved a pull request: "build: remove systemtap variadic patch"
(https://github.com/bitcoin/bitcoin/pull/29181#pullrequestreview-1805812259)
ACK 6047e25035b7dc07f25e8a756930d5cf3d92cd9f

🤔 hebasto reviewed a pull request: "crypto: remove use of BUILD_BITCOIN_INTERNAL macro in sha256"
(https://github.com/bitcoin/bitcoin/pull/29180#pullrequestreview-1805820587)
Approach ACK 9235801256a63a9ca4f8c95a005b5151afa9a5d4.

🤔 maflcko reviewed a pull request: "test: randomize perturbed files excluding ldb"
(https://github.com/bitcoin/bitcoin/pull/29182#pullrequestreview-1805830780)
Please keep your fixup commits squashed according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

💬 maflcko commented on pull request "test: randomize perturbed files excluding ldb":
(https://github.com/bitcoin/bitcoin/pull/29182#discussion_r1442799108)
are block files guaranteed to contain this many bytes of blocks, always?

💬 glozow commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1878572381)
This is a summary of the arguments on the PRs, mailing list posts, and some tweets.

### ACKs by reason

If you feel I have misrepresented something you said, feel free to let me know.

#### "Stop inscriptions, which are spam"

These types of transactions are used for ordinals, NFTs, data-carrying, or some use case that is not
financial transactions. This is "spam" and undermines the utility of Bitcoin for
payments due to high transaction traffic and fees.
- "these spam transactions m
...

💬 maflcko commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1878580405)
[clusterfuzz-testcase-tx_pool_standard-6515998551244800.bin.not.txt](https://github.com/bitcoin/bitcoin/files/13841869/clusterfuzz-testcase-tx_pool_standard-6515998551244800.bin.not.txt)


✅ TheCharlatan closed a pull request: "mempool: Don't sort in entryAll"
(https://github.com/bitcoin/bitcoin/pull/29019)

💬 TheCharlatan commented on pull request "mempool: Don't sort in entryAll":
(https://github.com/bitcoin/bitcoin/pull/29019#issuecomment-1878590817)
Seems like the new behavior incidentally fixed a bug, so closing this again in favor of #29179. Could do a follow-up eventually to make the `entryAll` call when processing the `getrawmempool` RPC call more efficient by skipping the sorting.

📝 glozow unlocked a pull request: "doc: revert clarify -datacarriersize"
(https://github.com/bitcoin/bitcoin/pull/29173)
The latest update of the help text of `-datacarriersize` is incorrect.

The purpose of this standardization rule is not to target only the data contained in the raw scriptPubKey, but all forms of arbitrary data.

It is incorrect to change the description of this option if an attempt to update it was made without being merged.

Context:

The [first inscription](https://mempool.space/tx/6fb976ab49dcec017f1e201e84395983204ae1a7c2abf7ced0a85d692e442799) appeared December 14, 2022 at the heig
...

💬 theuni commented on pull request "crypto: remove use of BUILD_BITCOIN_INTERNAL macro in sha256":
(https://github.com/bitcoin/bitcoin/pull/29180#issuecomment-1878604328)
Added a brief description of crypto_base.

💬 brunoerg commented on pull request "fuzz: set `nMaxOutboundLimit` in connman target":
(https://github.com/bitcoin/bitcoin/pull/29172#discussion_r1442825960)
The `ConsumeBool` is to ensure that the default value will be used in most cases.

👍 hebasto approved a pull request: "doc: Clarify C++20 comments"
(https://github.com/bitcoin/bitcoin/pull/29042#pullrequestreview-1805901540)
ACK fa87f8feb76da42eeb5c4d32ee7be070b2bd559f, I verified the code with clang-{16,17}.

💬 brunoerg commented on pull request "fuzz: set `nMaxOutboundLimit` in connman target":
(https://github.com/bitcoin/bitcoin/pull/29172#discussion_r1442832240)
No objections on calling `CConnman::Init` instead. With `SetMaxOutboundLimit` we ensure we're only messing with `nMaxOutboundLimit` and perhaps we avoid other locks (?).

💬 jangorecki commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1878619928)
You missed the most important, censorship

💬 dergoegge commented on pull request "fuzz: set `nMaxOutboundLimit` in connman target":
(https://github.com/bitcoin/bitcoin/pull/29172#discussion_r1442916555)
`Init` is called in the connman constructor: https://github.com/bitcoin/bitcoin/blob/c80f57ba575af96890f185765a53a62ef58ef2c8/src/net.cpp#L3117-L3118

Calling it again and only changing `nMaxOutboundLimit` achieves the same as you have here with less new code.

💬 dergoegge commented on pull request "fuzz: set `nMaxOutboundLimit` in connman target":
(https://github.com/bitcoin/bitcoin/pull/29172#discussion_r1442914249)
> The ConsumeBool is to ensure that the default value will be used in most cases.

How does it ensure that and why is that useful?

💬 maflcko commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-1878712706)
Just tested https://github.com/bitcoin/bitcoin/pull/28657 on oss-fuzz:

```
AR libbitcoin_util.a
AR libbitcoin_consensus.a
CXXLD crypto/libbitcoin_crypto_base.la
CXXLD crypto/libbitcoin_crypto_sse41.la
CXXLD crypto/libbitcoin_crypto_avx2.la
CXXLD crypto/libbitcoin_crypto_x86_shani.la
AR libbitcoin_cli.a
CXXLD libunivalue.la
CXXLD crc32c/libcrc32c.la
CXXLD leveldb/libmemenv.la
AR minisketch/libminisketch.a
CXXLD
...

📝 maflcko converted_to_draft a pull request: "build: Bump clang minimum supported version to 15"
(https://github.com/bitcoin/bitcoin/pull/29165)
Most supported operating systems ship with clang-15 (or later), so bump the minimum to that and allow new code to drop workarounds for previous clang bugs.

For reference:
* https://packages.debian.org/bookworm/clang-15
* https://packages.ubuntu.com/jammy/clang-15
* CentOS-like 8/9 Stream: All Clang versions from 15 to 17
* FreeBSD 12/13: All Clang versions from 15 to 16
* OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (`clang17`); No idea about OpenSuse Leap

...

💬 murchandamus commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1878746998)
Concept NACK

### Purpose of `datacarriersize`

`datacarriersize` refers to the payload of OP_RETURN outputs, the output type that was introduced as a data carrier to provide an alternative for more harmful ways of embedding data. At that time, there was a worry that any blockspace production in excess of the demand from monetary transactions would be filled for cheap since demand for highly replicated perpetual storage is unbounded. Bounding standard transactions to a single data carrier ou
...

💬 cliobitcoinbank commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1878754502)
> > eragmus
>
> You are quite literally word for word repeating talking points made by BSV users who intend to harm Bitcoin by spamming the UTXO set and creating an unreasonably high fee environment in which the average end user is incentivised not to participate or if so forced into a custodial solution from which their Bitcoin fails to actually be a bearer instrument.
>
> https://www.youtube.com/watch?v=-RswZDQTqsI
>
> All the connections were made by a random pleb in this video, don'
...