💬 aureleoules commented on pull request "wallet, rpc: `FundTransaction` refactor":
(https://github.com/bitcoin/bitcoin/pull/28560#discussion_r1441984071)
```suggestion
if (sffo_set.contains(pos))
```

💬 aureleoules commented on pull request "wallet, rpc: `FundTransaction` refactor":
(https://github.com/bitcoin/bitcoin/pull/28560#discussion_r1441983854)
```suggestion
CRecipient recipient = {destination, amount, subtract_fee_outputs.contains(idx)};
```

💬 aureleoules commented on pull request "wallet, rpc: `FundTransaction` refactor":
(https://github.com/bitcoin/bitcoin/pull/28560#discussion_r1441984340)
```suggestion
if (recipients.empty())
```

📝 glozow opened a pull request: "test: wallet rescan with reorged parent + IsFromMe child in mempool"
(https://github.com/bitcoin/bitcoin/pull/29179)
Originally motivated by #29019, which reverts back to having `requestMempoolTransactions` emit `transactionAddedToMempool` in `mapTx` default order instead of `GetSortedDepthAndScore` order.

It's important that these notifications happen in topological order, otherwise the wallet rescan may miss transactions that belong to it. Notably, checking whether a transaction `IsFromMe` requires knowing its inputs, which may be from a mempool parent.

When using `mapTx` order, a parent may come later
...

💬 hebasto commented on issue "ubsan: misaligned-pointer-use in crc32c/src/crc32c_arm64.cc":
(https://github.com/bitcoin/bitcoin/issues/29178#issuecomment-1877397067)
Should we use the [`-mstrict-align`](https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html#index-mstrict-align) option?

💬 glozow commented on pull request "mempool: Don't sort in entryAll":
(https://github.com/bitcoin/bitcoin/pull/29019#issuecomment-1877401757)
> Will this PR not cause issues [here](https://github.com/TheCharlatan/bitcoin/blob/87fa444a04854a5d3a9ff283a8b6c34587e8430f/src/wallet/wallet.cpp#L1938)? In [`CWallet::transactionAddedToMempool`](https://github.com/TheCharlatan/bitcoin/blob/87fa444a04854a5d3a9ff283a8b6c34587e8430f/src/wallet/wallet.cpp#L1406), we eventually call `CWallet::AddToWalletIfInvolvingMe` where we have a [dependency](https://github.com/TheCharlatan/bitcoin/blob/87fa444a04854a5d3a9ff283a8b6c34587e8430f/src/wallet/wallet
...

💬 darosior commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1877414034)
Can a maintainer please close this PR? It's clear this is not going anywhere and is just **spamming** the repository.

Most regular contributors to this project who gave their opinion here and elsewhere are against making this change. Nothing's preventing people interested in this code change to fork the project and develop their own Bitcoin P2P client. (As a matter of fact OP is already maintaining such a client, people interested in this could contribute to this project instead of arguing he
...

📝 fanquake locked a pull request: "Update net.h bigger TCP socket using larger buffer"
(https://github.com/bitcoin/bitcoin/pull/29159)
completely sync a 2gb prune in 8-10 hours instead of 3 days see src/net_processing.cpp also

prototype https://github.com/c4pt000/bitcoin 2 years ago testing

📝 fanquake locked a pull request: "64bit arith"
(https://github.com/bitcoin/bitcoin/pull/29171)
https://github.com/bitcoin/bips/pull/1533

📝 fanquake locked a pull request: "[DONTMERGE] See if just constexpr->consteval for _mst works"
(https://github.com/bitcoin/bitcoin/pull/29167)

💬 hebasto commented on issue "Broken `--enable-suppress-external-warning` for Apple Clang 15 on `x86_64`":
(https://github.com/bitcoin/bitcoin/issues/29174#issuecomment-1877440314)
Here are more details:

1.
```
% clang -cc1 --help | grep -A 1 internal-isystem
-internal-isystem <directory>
Add directory to the internal system include search path; these are assumed to not be user-provided and are used to model system and standard headers' paths.
```


2.
> Is the issue here just the concatenation? Maybe that worked previously, but no-longer does? What happens if you change `-Xclang -internal-isystem/usr/local/include` to `-Xclang -inte
...

📝 glozow locked a pull request: "doc: revert clarify -datacarriersize"
(https://github.com/bitcoin/bitcoin/pull/29173)
The latest update of the help text of `-datacarriersize` is incorrect.

The purpose of this standardization rule is not to target only the data contained in the raw scriptPubKey, but all forms of arbitrary data.

It is incorrect to change the description of this option if an attempt to update it was made without being merged.

Context:

The [first inscription](https://mempool.space/tx/6fb976ab49dcec017f1e201e84395983204ae1a7c2abf7ced0a85d692e442799) appeared December 14, 2022 at the heig
...

🚀 glozow merged a pull request: "Update libsecp256k1 subtree to current master"
(https://github.com/bitcoin/bitcoin/pull/29169)

📝 theuni opened a pull request: "crypto: remove use of BUILD_BITCOIN_INTERNAL macro in sha256"
(https://github.com/bitcoin/bitcoin/pull/29180)
Replace it with a more explicit DISABLE_OPTIMIZED_SHA256 and clean up some.

The macro was originally only used by libbitcoinconsensus which opts out of optimized sha256 for the sake of simplicity. But now that libbitcoinkernel uses it as well, we need more fine-grained control.

As a result of this change, libbitcoinkernel's sha256 usage should now be optimized.

💬 theuni commented on pull request "crypto: remove use of BUILD_BITCOIN_INTERNAL macro in sha256":
(https://github.com/bitcoin/bitcoin/pull/29180#issuecomment-1877480455)
Ping @TheCharlatan @hebasto

I went around in circles several times on this. I think it accomplishes what we need, but please sanity check me :)

💬 hebasto commented on pull request "crypto: remove use of BUILD_BITCOIN_INTERNAL macro in sha256":
(https://github.com/bitcoin/bitcoin/pull/29180#discussion_r1442055466)
Is it needed to keep `-DBUILD_BITCOIN_INTERNAL` now?

💬 theuni commented on pull request "crypto: remove use of BUILD_BITCOIN_INTERNAL macro in sha256":
(https://github.com/bitcoin/bitcoin/pull/29180#discussion_r1442056422)
Yes, this macro is now exclusively used to control exports.

💬 furszy commented on issue "Wallets should update key/descriptor birthdates when txs older than current birthdates are found":
(https://github.com/bitcoin/bitcoin/issues/28897#issuecomment-1877494923)
Can be closed.

✅ maflcko closed an issue: "Wallets should update key/descriptor birthdates when txs older than current birthdates are found"
(https://github.com/bitcoin/bitcoin/issues/28897)

📝 fanquake opened a pull request: "build: remove systemtap variadic patch"
(https://github.com/bitcoin/bitcoin/pull/29181)
We now use C++20.