✅ stickies-v closed a pull request: "rest: Extend HTTPRequest interface to support querying path (parameters)"
(https://github.com/bitcoin/bitcoin/pull/25754)

💬 stickies-v commented on pull request "rest: Use from_blockhash and txdetails query parameters":
(https://github.com/bitcoin/bitcoin/pull/25755#issuecomment-1465972431)
Closing as per https://github.com/bitcoin/bitcoin/issues/25752#issuecomment-1465971535

✅ stickies-v closed a pull request: "rest: Use from_blockhash and txdetails query parameters"
(https://github.com/bitcoin/bitcoin/pull/25755)

💬 stickies-v commented on pull request "rest: Remove support for a number of `-deprecatedrest` options":
(https://github.com/bitcoin/bitcoin/pull/25756#issuecomment-1465972551)
Closing as per https://github.com/bitcoin/bitcoin/issues/25752#issuecomment-1465971535

✅ stickies-v closed a pull request: "rest: Remove support for a number of `-deprecatedrest` options"
(https://github.com/bitcoin/bitcoin/pull/25756)

💬 glozow commented on pull request "Add feerate histogram to getmempoolinfo":
(https://github.com/bitcoin/bitcoin/pull/21422#discussion_r1133744544)
fyi you can get the same information for each transaction by calling `infoAll()`. I think it's not great practice for outside callers to reach into `mapTx`

💬 MarcoFalke commented on issue "RFC: Miniscript integration":
(https://github.com/bitcoin/bitcoin/issues/18040#issuecomment-1465993119)
Closing for now. If there are new discussions or feature request (or ones missed here), a new issue can be created or this one reopened.

✅ MarcoFalke closed an issue: "RFC: Miniscript integration"
(https://github.com/bitcoin/bitcoin/issues/18040)

✅ MarcoFalke closed a pull request: "[WIP] DRAFT NOMERGE Tidy up RPCTxSerializationFlags"
(https://github.com/bitcoin/bitcoin/pull/23599)

👍 MarcoFalke approved a pull request: "Avoid integer overflow in CheckDiskSpace"
(https://github.com/bitcoin/bitcoin/pull/27235)
lgtm

💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#discussion_r1133824606)
```suggestion
self.log.info("Test that a manually pruned node does not run into integer overflow on first start")
```

nit: Not sure if more context is helpful. Otherwise, I suspect this test will be removed in the future due to being redundant.

💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#discussion_r1133825558)
Can also add my test to check that no false warning will be issued anymore? Integer overflow isn't the only issue you are fixing here.

💬 desirepl commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1466048126)
I see only translation changes 2 hours ago.
I'm not so familiar with git, so checked code updates here at main and other branches. Only your updates to translations 2 hours ago. Seems doing something wrong or don't understand, короче.

💬 MarcoFalke commented on pull request "wallet: ensure the wallet is unlocked when needed for rescanning":
(https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1133856319)
> However, for me this no longer fails without the fix.

For me, nothing fails. Unless I specifically add a manual sleep on the code before the fix:

```diff
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
index eed40f9462..d5b5af0d4c 100644
--- a/src/wallet/wallet.cpp
+++ b/src/wallet/wallet.cpp
@@ -1851,6 +1851,8 @@ CWallet::ScanResult CWallet::ScanForWalletTransactions(const uint256& start_bloc
WalletLogPrintf("Rescan started from block %s... (%s)\n", start_block.ToS
...

💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#discussion_r1133858582)
```suggestion
self.log.info("Test that no warning appears when assumed chain size fits on disk, but the prune target would not")
```

nit (if you retouch)

💬 theStack commented on issue "RFC: Replacing Boost Process":
(https://github.com/bitcoin/bitcoin/issues/24907#issuecomment-1466087049)
FWIW, I started working on replacing boost::process with cpp-subprocess on the following branch: https://github.com/theStack/bitcoin/tree/nuke_boost_process
Currently the unit tests (system_tests/run_command) and functional tests (rpc_signer.py, wallet_signer.py) pass on both Linux and OpenBSD, but compiling for Windows via g++-mingw-w64-x86-64-posix fails due to missing headers (`Windows.h`). The changes are not very invasive, most work was probably to change from passing a single string to a
...

🤔 MarcoFalke requested changes to a pull request: "test: fix race condition in encrypted wallet rescan tests"
(https://github.com/bitcoin/bitcoin/pull/27199)
Calling the cli constructor does not dispatch the rpc.

Otherwise this looks really nice.

I've tested this with https://github.com/bitcoin/bitcoin/pull/26347/commits/6a5b348f2e526f048d0b448b01f6c4ab608569af#r1133856319

💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1133892255)
```suggestion
minernode.cli("-rpcwallet=encrypted_wallet").walletlock()
```

💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1133892752)
```suggestion
self.nodes[0].cli("-rpcwallet=encrypted_wallet").walletlock()
```

⚠️ red0bear opened an issue: "Adding interprocess onion access instead local ip"
(https://github.com/bitcoin/bitcoin/issues/27252)
### Please describe the feature you'd like to see added.

- onion uses 127.0.0.1:9050 and i would like to set it to use unix:path_to_variable used by tor

### Is your feature related to a problem, if so please describe it.

Avoid people try access local ips or 127.0.0.1 with miss configured torcc.

### Describe the solution you'd like

_No response_

### Describe any alternatives you've considered

_No response_

### Please leave any additional context

_No response_