💬 1440000bytes commented on pull request "Remove `dnsseed.bitcoin.dashjr.org` temporarily":
(https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872063421)
@achow101 why is this pull request closed?

💬 1440000bytes commented on pull request "init: handle empty settings file gracefully":
(https://github.com/bitcoin/bitcoin/pull/29144#discussion_r1438254888)
NACK for this PR

Core does not works for umbrel

This is external and need to maintain outside of core: https://community.umbrel.com/t/bitcoin-docker-container-keeps-restarting/2144

💬 furszy commented on pull request "test: test_bitcoin: allow -testdatadir=<datadir>":
(https://github.com/bitcoin/bitcoin/pull/26564#discussion_r1438256160)
```c++
fs::path dir = m_node.args->GetPathArg("-testdatadir");
// todo: check if path is valid
m_path_root = dir / "test_temp";
```

💬 furszy commented on pull request "test: test_bitcoin: allow -testdatadir=<datadir>":
(https://github.com/bitcoin/bitcoin/pull/26564#discussion_r1438257281)
> Good idea, but what do you mean by path correctness?

Probably we should fail when `-testdatadir` is an empty string.

💬 furszy commented on pull request "test: test_bitcoin: allow -testdatadir=<datadir>":
(https://github.com/bitcoin/bitcoin/pull/26564#discussion_r1438258663)
This should use the `EXIT_FAILURE` constant, not exit(1).

Also, I would move the print + exit to a standalone function to dedup code. Like `Shutdown(const std::string& err_msg);`.

⚠️ etfmoon opened an issue: "Mark Transactions with OFAC Addresses as Non-Standard"
(https://github.com/bitcoin/bitcoin/issues/29151)
### Please describe the feature you'd like to see added.

>Bitcoin core arbitrarily censors a lot of transactions, not just op_return data carrier size. There's an entire suite of functions in policy.cpp that define Bitcoin's censorship algorithm - isDust(), isValid(), isStandard(), isStandardTx(), AreInputsStandard(), IsWitnessStandard(). The original and sole purpose of those functions is to promote censorship.

https://x.com/AsherHopp/status/1740191968834310654

Use these functions to mak
...

✅ fanquake closed an issue: "Mark Transactions with OFAC Addresses as Non-Standard"
(https://github.com/bitcoin/bitcoin/issues/29151)

💬 furszy commented on pull request "init: handle empty settings file gracefully":
(https://github.com/bitcoin/bitcoin/pull/29144#discussion_r1438263758)
> Core does not works for umbrel

@1440000bytes, I did not know about umbrel existence until you pointed it out.

The PR tries to improve a confusing situation reported by users who did not understand why a settings parsing error occurred when the file was empty and did not know how to solve it.

📝 1440000bytes opened a pull request: "Remove luke from dns seeds"
(https://github.com/bitcoin/bitcoin/pull/29152)
No reason shared to closed in this PR : https://github.com/bitcoin/bitcoin/pull/28936

💬 kristapsk commented on issue "Mark Transactions with OFAC Addresses as Non-Standard":
(https://github.com/bitcoin/bitcoin/issues/29151#issuecomment-1872115179)
> Mark transactions containing OFAC addresses as non-standard to ensure that they are not relayed by bitcoin nodes.

You cannot enforce other people to run any code like this on their nodes. You are free to patch your node and do it yourself. But that doesn't mean such transactions can't be mined by the miners. 4G inscription transaction was non-standard, not relayed by nodes, was sent directly to miner and mined.

💬 benpbolton commented on pull request "Remove `dnsseed.bitcoin.dashjr.org` temporarily":
(https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872130515)
> So it doesn't matter that much what features these initial peers support, as long as they can give us more peers.

But this seeder was

> intentionally excluding old nodes which didn't enforce Taproot.

and did so in a manner that was static (used a filtering method at the time that wasn't updated) and the DNS seed policy states ...

> ...the results may be randomized but must not single-out any group of hosts to receive different results unless due to an urgent technical necessity a
...

💬 achow101 commented on pull request "Remove `dnsseed.bitcoin.dashjr.org` temporarily":
(https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872136121)
The issue with old nodes was resolved. There is no evidence otherwise that the seeder violates the DNS seed policy.

💬 achow101 commented on pull request "Remove luke from dns seeds":
(https://github.com/bitcoin/bitcoin/pull/29152#issuecomment-1872136680)
Do not open duplicate PRs. If you believe a PR should be reopened, then you can comment and discuss on the closed one.

✅ achow101 closed a pull request: "Remove luke from dns seeds"
(https://github.com/bitcoin/bitcoin/pull/29152)

📝 achow101 locked a pull request: "Remove luke from dns seeds"
(https://github.com/bitcoin/bitcoin/pull/29152)
No reason shared to closed in this PR : https://github.com/bitcoin/bitcoin/pull/28936

💬 etfmoon commented on pull request "Remove `dnsseed.bitcoin.dashjr.org` temporarily":
(https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872161052)
> https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872136121



> A DNS seed operating organization or person is expected to follow good host security practices
> The DNS seed results must consist exclusively of fairly selected and functioning Bitcoin nodes from the public network to the best of the operator's understanding and capability.

Evidence: https://pastebin.com/raw/Cwk2a1xr

Maybe read descriptions and https://github.com/bitcoin/bitcoin/blob/master/doc/dnsseed-polic
...

💬 1440000bytes commented on pull request "Remove `dnsseed.bitcoin.dashjr.org` temporarily":
(https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872169440)
Do not close PRs. If you believe a PR should not need more research, then you can comment.

💬 achow101 commented on pull request "Remove `dnsseed.bitcoin.dashjr.org` temporarily":
(https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872189682)
> > [#29149 (comment)](https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872136121)
>
> > A DNS seed operating organization or person is expected to follow good host security practices
> > The DNS seed results must consist exclusively of fairly selected and functioning Bitcoin nodes from the public network to the best of the operator's understanding and capability.
>
> Evidence: https://pastebin.com/raw/Cwk2a1xr
>
> Maybe read descriptions and https://github.com/bitcoin/bitco
...

💬 1440000bytes commented on pull request "Remove `dnsseed.bitcoin.dashjr.org` temporarily":
(https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872200086)



💬 1440000bytes commented on pull request "Remove `dnsseed.bitcoin.dashjr.org` temporarily":
(https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1872201337)
Why not remove that policy doc that this point? bunch of hypocrites