💬 pablomartin4btc commented on pull request "cli: add validation to cli side commands besides when it's used with -rpcwallet":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1133339434)
I've re-tweaked it a bit, added a `\n` as current implementation and just set the error message that comes from the `utils` in the test's constant:
```
Multiple wallets are loaded. Please specify a wallet to use by requesting the RPC through the /wallet/<filename> URI path.
Using "bitcoin-cli", add the "-rpcwallet=<filename>" option before the command.
Run "bitcoin-cli -h" for help or "bitcoin-cli listwallets" to see which wallets are currently loaded.
````
WALLET_NOT_SPECIFIED = 'Multiple
...

📝 fanquake locked a pull request: "test"
(https://github.com/bitcoin/bitcoin/pull/27250)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 elonmusk-inv commented on issue "failure in wallet_basic.py --descriptors":
(https://github.com/bitcoin/bitcoin/issues/27249#issuecomment-1465691055)
Hello

💬 elonmusk-inv commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1465691588)
Hello

💬 dergoegge commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#issuecomment-1465815466)
> Should be trivial to add a test, no?

- I don't want to add a new functional test just for this.
- I tried to add a unit test but all our testing setups don't use the actual init logic.
- Maybe it can be added to one of the existing functional tests that do pruning, but I don't know which one. I tried but it always ends up being a bigger change to the test than I think would be justified for this trivial change.

If you know an easy way to add a test let me know, happy to add it.

💬 kiminuo commented on pull request "Add feerate histogram to getmempoolinfo":
(https://github.com/bitcoin/bitcoin/pull/21422#issuecomment-1465824503)
(2️ year anniversary today 🎉)

💬 MarcoFalke commented on issue "failure in wallet_basic.py --descriptors":
(https://github.com/bitcoin/bitcoin/issues/27249#issuecomment-1465836612)
Looks like a bug in the wallet? Wild guess:

* Tx is added to mempool (validationinterface event is scheduled)
* Tx is mined (and recorded by wallet as mined)
* event is executed and tx is marked as not in mempool and untrusted??

💬 MarcoFalke commented on issue "failure in wallet_basic.py --descriptors":
(https://github.com/bitcoin/bitcoin/issues/27249#issuecomment-1465839557)
<details><summary>longer log</summary>


```
test 2023-03-12T18:59:06.353000Z TestFramework (INFO): Testing 'listunspent' outputs the parent descriptor(s) of coins
node0 2023-03-12T18:59:06.354968Z [http] [httpserver.cpp:257] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:59490
node0 2023-03-12T18:59:06.355165Z [httpworker.0] [rpc/request.cpp:179] [parse] [rpc] ThreadRPCServer method=deriveaddresses user=__cookie__
node0 2023-03-12T18:59:06.369434Z [http] [h
...

📝 hebasto opened a pull request: "[24.x] qt: 24.1rc1 translations update"
(https://github.com/bitcoin/bitcoin/pull/27251)
This PR pulls the recent translations from the [Transifex.com](https://www.transifex.com/bitcoin/bitcoin) using the [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) tool.

According to our [Release Process docs](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-every-release-candidate), it is supposed to be merged before `v24.1rc1` tagging (#27247).

Will keep this PR upda
...

💬 MarcoFalke commented on pull request "rest: Move format string from path-like parameter to query parameter":
(https://github.com/bitcoin/bitcoin/pull/25753#issuecomment-1465864323)
@stickies-v Looks like this was opened as draft a year ago with no further activity from you. Can this be closed?

💬 MarcoFalke commented on pull request "rest: Remove support for a number of `-deprecatedrest` options":
(https://github.com/bitcoin/bitcoin/pull/25756#issuecomment-1465864763)
@stickies-v Looks like this was opened as draft a year ago with no further activity from you. Can this be closed?

💬 MarcoFalke commented on pull request "rest: Use from_blockhash and txdetails query parameters":
(https://github.com/bitcoin/bitcoin/pull/25755#issuecomment-1465865114)
@stickies-v Looks like this was opened as draft a year ago with no further activity from you. Can this be closed?

💬 MarcoFalke commented on pull request "rest: Extend HTTPRequest interface to support querying path (parameters)":
(https://github.com/bitcoin/bitcoin/pull/25754#issuecomment-1465865472)
@stickies-v Looks like this was opened as draft a year ago with no further activity from you. Can this be closed?

💬 hebasto commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1465872252)
There were some changes in the code which is responsible for handling settings.

@desirepl

Mind checking out the recent master branch please?

💬 dergoegge commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#issuecomment-1465873177)
> How about setting nPruneTarget to something smaller, like std::numeric_limits<uint64_t>::max() / 2? That's still large enough

@martinus That wouldn't quite work because `CheckDiskSpace` would return false then, given that `std::numeric_limits<uint64_t>::max() / 2 + 50MB` would likely not be available in free disk space on any system (https://github.com/bitcoin/bitcoin/blob/1884b71b1dc1fe463a2f00e61bcc56e4720cbc69/src/util/system.cpp#LL138). Currently the overflow works out because it just e
...

💬 rodentrabies commented on pull request "wallet: do not backdate locktime if it may lead to fingerprinting":
(https://github.com/bitcoin/bitcoin/pull/26902#discussion_r1133748788)
Thanks! Will do.

💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#issuecomment-1465942262)
All you need to do to add a test is adding a call to start a node with the `prune=1` arg. For example:


```diff
diff --git a/test/functional/rpc_blockchain.py b/test/functional/rpc_blockchain.py
index 7a0cedb1f5..8e086cf268 100755
--- a/test/functional/rpc_blockchain.py
+++ b/test/functional/rpc_blockchain.py
@@ -69,6 +69,7 @@ class BlockchainTest(BitcoinTestFramework):

def run_test(self):
self.wallet = MiniWallet(self.nodes[0])
+ self._test_prune_disk_space()
...

💬 willcl-ark commented on issue "RFC: Miniscript integration":
(https://github.com/bitcoin/bitcoin/issues/18040#issuecomment-1465966738)
@michaelfolkson do you think this can be closed now that we have #24149 (amongst other capabilities)?

💬 stickies-v commented on issue "rest: Further API and code cleanup with query parameters":
(https://github.com/bitcoin/bitcoin/issues/25752#issuecomment-1465971535)
Closing this (and draft PRs). I still think the suggested changes are an improvement, and that the state of our current interfaces is an impediment to (new) developers building on Bitcoin Core instead of using third-party services, but as evidenced by my lack of activity on this issue I don't feel anymore like this is currently a particularly worthwhile endeavour given current development resources and other active projects that require developer attention.

Moreover, I think I'm now leaning m
...

✅ stickies-v closed an issue: "rest: Further API and code cleanup with query parameters"
(https://github.com/bitcoin/bitcoin/issues/25752)