💬 achow101 commented on pull request "[24.x] Bump version to v24.1rc1":
(https://github.com/bitcoin/bitcoin/pull/27247#issuecomment-1465245481)
ACK 932a609312cb7b72bf5f23112763ab933a54389c

💬 fjahr commented on pull request "assumeutxo: net_processing changes":
(https://github.com/bitcoin/bitcoin/pull/24008#discussion_r1133292021)
This function could have an early return of `m_ibd_chainstate` if there is no `m_snapshot_chainstate` which should be the base case, i.e. when assumeutxo is not used?

💬 fjahr commented on pull request "assumeutxo: net_processing changes":
(https://github.com/bitcoin/bitcoin/pull/24008#discussion_r1133294858)
nit: `m_chainstate_to_last_common_block`

💬 fanquake commented on pull request "guix: use osslsigncode 2.5":
(https://github.com/bitcoin/bitcoin/pull/27179#issuecomment-1465270059)
@achow101 thanks for taking a look. Rebased, and pulled your changes in here, for further testing.

💬 fanquake commented on pull request "guix: use osslsigncode 2.5":
(https://github.com/bitcoin/bitcoin/pull/27179#issuecomment-1465274765)
```bash
c1471783bd078d094d886dc010ba6798c6d6abbd3b5329d7ce0ff3df05a3bcd9 guix-build-285edfadcacd/output/dist-archive/bitcoin-285edfadcacd.tar.gz
151e208ad965f1c89dda0ea01cff659930cdce060e1fc32e7db474fe5814a4a1 guix-build-285edfadcacd/output/x86_64-w64-mingw32/SHA256SUMS.part
d83fb0326d5c195d32a3243d494c34b6d0810c0aa36e174ff0d1eb1664f40413 guix-build-285edfadcacd/output/x86_64-w64-mingw32/bitcoin-285edfadcacd-win64-debug.zip
6f557b84042874ffbb6755cd279b3e45fa16b89eece12f8c3ab2546d4222c129
...

⚠️ fanquake opened an issue: "failure in wallet_basic.py --descriptors"
(https://github.com/bitcoin/bitcoin/issues/27249)
https://cirrus-ci.com/task/6282049166770176?logs=ci#L3112
```bash
node0 2023-03-12T18:59:07.047547Z [scheduler] [wallet/wallet.h:840] [WalletLogPrintf] [default_wallet] AddToWallet 0a94aab7b4dc8ba22b88ccd6b2c9898936c7d36bf8b3e1789f6083b85f6d752a new
test 2023-03-12T18:59:07.053000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc
...

💬 jonatack commented on pull request "[24.x] Bump version to v24.1rc1":
(https://github.com/bitcoin/bitcoin/pull/27247#issuecomment-1465283925)
Maybe also https://github.com/bitcoin/bitcoin/pull/27138 and (updating it today) https://github.com/bitcoin/bitcoin/pull/27231.

📝 JoaoLobo94 opened a pull request: "test"
(https://github.com/bitcoin/bitcoin/pull/27250)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ JoaoLobo94 closed a pull request: "test"
(https://github.com/bitcoin/bitcoin/pull/27250)

💬 pablomartin4btc commented on pull request "cli: add validation to cli side commands besides when it's used with -rpcwallet":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1133339434)
I've re-tweaked it a bit, added a `\n` as current implementation and just set the error message that comes from the `utils` in the test's constant:
```
Multiple wallets are loaded. Please specify a wallet to use by requesting the RPC through the /wallet/<filename> URI path.
Using "bitcoin-cli", add the "-rpcwallet=<filename>" option before the command.
Run "bitcoin-cli -h" for help or "bitcoin-cli listwallets" to see which wallets are currently loaded.
````
WALLET_NOT_SPECIFIED = 'Multiple
...

📝 fanquake locked a pull request: "test"
(https://github.com/bitcoin/bitcoin/pull/27250)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 elonmusk-inv commented on issue "failure in wallet_basic.py --descriptors":
(https://github.com/bitcoin/bitcoin/issues/27249#issuecomment-1465691055)
Hello

💬 elonmusk-inv commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1465691588)
Hello

💬 dergoegge commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#issuecomment-1465815466)
> Should be trivial to add a test, no?

- I don't want to add a new functional test just for this.
- I tried to add a unit test but all our testing setups don't use the actual init logic.
- Maybe it can be added to one of the existing functional tests that do pruning, but I don't know which one. I tried but it always ends up being a bigger change to the test than I think would be justified for this trivial change.

If you know an easy way to add a test let me know, happy to add it.

💬 kiminuo commented on pull request "Add feerate histogram to getmempoolinfo":
(https://github.com/bitcoin/bitcoin/pull/21422#issuecomment-1465824503)
(2️ year anniversary today 🎉)

💬 MarcoFalke commented on issue "failure in wallet_basic.py --descriptors":
(https://github.com/bitcoin/bitcoin/issues/27249#issuecomment-1465836612)
Looks like a bug in the wallet? Wild guess:

* Tx is added to mempool (validationinterface event is scheduled)
* Tx is mined (and recorded by wallet as mined)
* event is executed and tx is marked as not in mempool and untrusted??

💬 MarcoFalke commented on issue "failure in wallet_basic.py --descriptors":
(https://github.com/bitcoin/bitcoin/issues/27249#issuecomment-1465839557)
<details><summary>longer log</summary>


```
test 2023-03-12T18:59:06.353000Z TestFramework (INFO): Testing 'listunspent' outputs the parent descriptor(s) of coins
node0 2023-03-12T18:59:06.354968Z [http] [httpserver.cpp:257] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:59490
node0 2023-03-12T18:59:06.355165Z [httpworker.0] [rpc/request.cpp:179] [parse] [rpc] ThreadRPCServer method=deriveaddresses user=__cookie__
node0 2023-03-12T18:59:06.369434Z [http] [h
...

📝 hebasto opened a pull request: "[24.x] qt: 24.1rc1 translations update"
(https://github.com/bitcoin/bitcoin/pull/27251)
This PR pulls the recent translations from the [Transifex.com](https://www.transifex.com/bitcoin/bitcoin) using the [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) tool.

According to our [Release Process docs](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-every-release-candidate), it is supposed to be merged before `v24.1rc1` tagging (#27247).

Will keep this PR upda
...

💬 MarcoFalke commented on pull request "rest: Move format string from path-like parameter to query parameter":
(https://github.com/bitcoin/bitcoin/pull/25753#issuecomment-1465864323)
@stickies-v Looks like this was opened as draft a year ago with no further activity from you. Can this be closed?

💬 MarcoFalke commented on pull request "rest: Remove support for a number of `-deprecatedrest` options":
(https://github.com/bitcoin/bitcoin/pull/25756#issuecomment-1465864763)
@stickies-v Looks like this was opened as draft a year ago with no further activity from you. Can this be closed?