💬 fjahr commented on pull request "net: Add -allowinbound config option":
(https://github.com/bitcoin/bitcoin/pull/25718#issuecomment-1465226643)
Closing this for now as I currently don't have time to continue with this. I hope I can revisit it in the future.

✅ fjahr closed a pull request: "net: Add -allowinbound config option"
(https://github.com/bitcoin/bitcoin/pull/25718)

👍 fanquake approved a pull request: "Update src/secp256k1 subtree to upstream release v0.3.0"
(https://github.com/bitcoin/bitcoin/pull/27230)
ACK e5c7fcb361d3379c254a52104b4ba25907cd07bb

🚀 fanquake merged a pull request: "Update src/secp256k1 subtree to upstream release v0.3.0"
(https://github.com/bitcoin/bitcoin/pull/27230)

💬 fjahr commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1133279555)
Just catching up... Not sure if intentional or not but maybe the XXX here was something you still wanted to address but missed @jamesob ?

💬 desirepl commented on issue "Bitcoin ignores datadir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1465235684)
@fanquake, I suppose it can be OS independent bug.

📝 fanquake opened a pull request: "[24.x] Bump version to v24.1rc1"
(https://github.com/bitcoin/bitcoin/pull/27247)
Bump the version number to v24.1rc1.
Regenerate the man pages.
Update the version number in bips.md.
Move the v24.0.1 release notes to doc/release-notes.
Add initial release notes for v24.1.

Merged changes to the 24.x branch since v24.0.1:
- https://github.com/bitcoin/bitcoin/pull/26457
- https://github.com/bitcoin/bitcoin/pull/26735
- https://github.com/bitcoin/bitcoin/pull/26878
- https://github.com/bitcoin/bitcoin/pull/26880

💬 fanquake commented on issue "Opening bitcoin-24.0rc1-arm64-apple-darwin.dmg does not open Finder window":
(https://github.com/bitcoin/bitcoin/issues/26176#issuecomment-1465244200)
Moving this to 25.x. See one potential fix in #27099.

💬 achow101 commented on pull request "[24.x] Bump version to v24.1rc1":
(https://github.com/bitcoin/bitcoin/pull/27247#issuecomment-1465245481)
ACK 932a609312cb7b72bf5f23112763ab933a54389c

💬 fjahr commented on pull request "assumeutxo: net_processing changes":
(https://github.com/bitcoin/bitcoin/pull/24008#discussion_r1133292021)
This function could have an early return of `m_ibd_chainstate` if there is no `m_snapshot_chainstate` which should be the base case, i.e. when assumeutxo is not used?

💬 fjahr commented on pull request "assumeutxo: net_processing changes":
(https://github.com/bitcoin/bitcoin/pull/24008#discussion_r1133294858)
nit: `m_chainstate_to_last_common_block`

💬 fanquake commented on pull request "guix: use osslsigncode 2.5":
(https://github.com/bitcoin/bitcoin/pull/27179#issuecomment-1465270059)
@achow101 thanks for taking a look. Rebased, and pulled your changes in here, for further testing.

💬 fanquake commented on pull request "guix: use osslsigncode 2.5":
(https://github.com/bitcoin/bitcoin/pull/27179#issuecomment-1465274765)
```bash
c1471783bd078d094d886dc010ba6798c6d6abbd3b5329d7ce0ff3df05a3bcd9 guix-build-285edfadcacd/output/dist-archive/bitcoin-285edfadcacd.tar.gz
151e208ad965f1c89dda0ea01cff659930cdce060e1fc32e7db474fe5814a4a1 guix-build-285edfadcacd/output/x86_64-w64-mingw32/SHA256SUMS.part
d83fb0326d5c195d32a3243d494c34b6d0810c0aa36e174ff0d1eb1664f40413 guix-build-285edfadcacd/output/x86_64-w64-mingw32/bitcoin-285edfadcacd-win64-debug.zip
6f557b84042874ffbb6755cd279b3e45fa16b89eece12f8c3ab2546d4222c129
...

⚠️ fanquake opened an issue: "failure in wallet_basic.py --descriptors"
(https://github.com/bitcoin/bitcoin/issues/27249)
https://cirrus-ci.com/task/6282049166770176?logs=ci#L3112
```bash
node0 2023-03-12T18:59:07.047547Z [scheduler] [wallet/wallet.h:840] [WalletLogPrintf] [default_wallet] AddToWallet 0a94aab7b4dc8ba22b88ccd6b2c9898936c7d36bf8b3e1789f6083b85f6d752a new
test 2023-03-12T18:59:07.053000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc
...

💬 jonatack commented on pull request "[24.x] Bump version to v24.1rc1":
(https://github.com/bitcoin/bitcoin/pull/27247#issuecomment-1465283925)
Maybe also https://github.com/bitcoin/bitcoin/pull/27138 and (updating it today) https://github.com/bitcoin/bitcoin/pull/27231.

📝 JoaoLobo94 opened a pull request: "test"
(https://github.com/bitcoin/bitcoin/pull/27250)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ JoaoLobo94 closed a pull request: "test"
(https://github.com/bitcoin/bitcoin/pull/27250)

💬 pablomartin4btc commented on pull request "cli: add validation to cli side commands besides when it's used with -rpcwallet":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1133339434)
I've re-tweaked it a bit, added a `\n` as current implementation and just set the error message that comes from the `utils` in the test's constant:
```
Multiple wallets are loaded. Please specify a wallet to use by requesting the RPC through the /wallet/<filename> URI path.
Using "bitcoin-cli", add the "-rpcwallet=<filename>" option before the command.
Run "bitcoin-cli -h" for help or "bitcoin-cli listwallets" to see which wallets are currently loaded.
````
WALLET_NOT_SPECIFIED = 'Multiple
...

📝 fanquake locked a pull request: "test"
(https://github.com/bitcoin/bitcoin/pull/27250)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 elonmusk-inv commented on issue "failure in wallet_basic.py --descriptors":
(https://github.com/bitcoin/bitcoin/issues/27249#issuecomment-1465691055)
Hello