💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433283984)
Added a comment. The purpose is to be consistent so that the user is not confused. Otherwise an import could change the result of `gethdkey` unexpectedly. With the future `sethdseed` change, `gethdkey`'s result being different will at least be explicit, whereas an import may or may not change the detection of the hd key, depending on what else is/has been imported.

💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433284084)
Done as suggested.

💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433284159)
Removed

💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433284534)
I prefer these checks to be in the function itself rather than the caller for these upgrades as we may want to call these from elsewhere in the future.

⚠️ FUSION9999 opened an issue: "Transfer from closed coinbase acc."
(https://github.com/bitcoin/bitcoin/issues/29126)
My coinbase acc was closed for unknown reason, called and dowloaded bitcoin wallet transfered funds but was 13hrs to sync. Now its only 15% in 24hrs. WHF I have no idea what to do need help.

💬 stickies-v commented on pull request "Nuke adjusted time (attempt 2)":
(https://github.com/bitcoin/bitcoin/pull/28956#discussion_r1433289091)
This does seem to change warning behaviour, in that:
1. it isn't logged anymore
2. there's no more pop-up message for bitcoin-qt

Is that intentional?

💬 achow101 commented on pull request "sqlite: Disallow writing from multiple `SQLiteBatch`s":
(https://github.com/bitcoin/bitcoin/pull/29112#discussion_r1433301783)
Fixed. Also pulled the test with a few changes.

💬 achow101 commented on pull request "sqlite: Disallow writing from multiple `SQLiteBatch`s":
(https://github.com/bitcoin/bitcoin/pull/29112#discussion_r1433301862)
Fixed

💬 achow101 commented on pull request "sqlite: Disallow writing from multiple `SQLiteBatch`s":
(https://github.com/bitcoin/bitcoin/pull/29112#discussion_r1433301957)
Fixed

📝 maaku opened a pull request: "Use hardened runtime on macOS release builds."
(https://github.com/bitcoin/bitcoin/pull/29127)
The Apple notary service requires submitted app bundles to be configured to use the hardened runtime libraries. This is configured at signing time, and supported by the signapple tool Bitcoin Core uses for reproduceable signed binaries. We simply need to pass "--hardened-runtime" when the signature is created. Once attached to the bundle, the resulting codesigned binary can be successfully submitted to the Apple binary notarization service by any Apple Developer.

This partially resolves #1
...

💬 achow101 commented on pull request "fuzz: coinselection, improve `min_viable_change`/`change_output_size`":
(https://github.com/bitcoin/bitcoin/pull/28372#issuecomment-1865318624)
ACK cd810075eddd8b1a7139559b475b56126f70a93d

💬 ariard commented on pull request "Ephemeral Anchors":
(https://github.com/bitcoin/bitcoin/pull/29001#issuecomment-1865322967)
> @ariard I'd rather talk downstream details over here https://github.com/bitcoin/bips/pull/1524

Thanks good to me - Answered strong conceptual issues there.

🚀 achow101 merged a pull request: "fuzz: coinselection, improve `min_viable_change`/`change_output_size`"
(https://github.com/bitcoin/bitcoin/pull/28372)

✅ achow101 closed an issue: "Transfer from closed coinbase acc."
(https://github.com/bitcoin/bitcoin/issues/29126)

💬 achow101 commented on issue "Transfer from closed coinbase acc.":
(https://github.com/bitcoin/bitcoin/issues/29126#issuecomment-1865324105)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base. General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat.

💬 maaku commented on issue "macOS App Notarization":
(https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-1865330437)
I'm a bit mystified that this issue is over 4 years old. Near as I can tell, the release manager just needs to pas `--hardened-runtime` to the signing command, and the resulting binaries will be notorizable. I've personally tested this on v26.

💬 achow101 commented on issue "macOS App Notarization":
(https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-1865370047)
> I'm a bit mystified that this issue is over 4 years old. Near as I can tell, the release manager just needs to pas `--hardened-runtime` to the signing command, and the resulting binaries will be notorizable. I've personally tested this on v26.

I don't think it's technically difficult, although it will probably need additional tooling and procedural changes to work in the Guix build system.

I believe the current main objection is a philosophical one to the fact that notarizing means that
...

🤔 ryanofsky reviewed a pull request: "wallet: Have the wallet store the key for automatically generated descriptors"
(https://github.com/bitcoin/bitcoin/pull/26728#pullrequestreview-1791999003)
re: https://github.com/bitcoin/bitcoin/pull/26728#issuecomment-1865160784
re: https://github.com/bitcoin/bitcoin/pull/26728#pullrequestreview-1791595622

> This is essentially what we do today, albeit with hd keys rather than hd seeds.

Right. It seems like we can add the features we want without making the wallet data model more complicated, so I think we should do that. If there are features that can't work under the current model, or would work worse under the current model, that would c
...

💬 ryanofsky commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433383580)
In commit "test: add coverage for re-opening a downgraded encrypted wallet on master" (98b6fad226640a0827e39574a91dd3d2fdeac94a)

I think your renaming script went too far 😁, this commit used to be authored by furszy (db6b61e9e7635c9cb97d73fd44b9e7266b8eef51)

💬 ryanofsky commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433362520)
In commit "wallet: Automatically upgrade a wallet to have global hd key" (442962d4410edd985fe336f29070c55516ae7de4)

It seems like these variables are unnecessary, and CWallet::UpgradeToGlobalHDKey could just get the keys from the descriptors in the wallet instance, instead of requiring them to be passed as extra argument. This would require adding an extra loop to UpgradeToGlobalHDKey, but also make it less fragile, simpler to call, and easier to understand without having to look at outside c
...