🚀 glozow merged a pull request: "[doc]: add doxygen comment describing what `CheckPackageLimits` returns"
(https://github.com/bitcoin/bitcoin/pull/29115)

✅ maflcko closed an issue: "bitcoind ubuntu generating fake addresses ?"
(https://github.com/bitcoin/bitcoin/issues/29116)

💬 maflcko commented on issue "bitcoind ubuntu generating fake addresses ?":
(https://github.com/bitcoin/bitcoin/issues/29116#issuecomment-1864265280)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat, or one of the Bitcoin subreddits, or any other place that you feel is well suited.

💬 glozow commented on pull request "mempool / rpc: followup to getprioritisedtransactions and delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/28885#discussion_r1432569676)
That's fine for lines that you're adding or already changing (which iiuc is what jonatack was suggesting as well). To make review easier, I wouldn't recommend reformatting other lines, as it crowds the diff.

💬 fanquake commented on pull request "build: switch to using LLVM 17.x for macOS builds":
(https://github.com/bitcoin/bitcoin/pull/28880#issuecomment-1864277320)
Added more patching to Qt. There is one issue left to fixup:
```bash
_void std::__1::__buffered_inplace_merge[abi:v160006]<std::__1::_ClassicAlgPolicy, bool (*&)(QPersistentModelIndex const&, QPersistentModelIndex const&), QPersistentModelIndex*>(QPersistentModelIndex*, QPersistentModelIndex*, QPersistentModelIndex*, bool (*&)(QPersistentModelIndex const&, QPersistentModelIndex const&), std::__1::iterator_traits<QPersistentModelIndex*>::difference_type, std::__1::iterator_traits<QPersistentMod
...

💬 glozow commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#discussion_r1432576558)
Maybe just use `TxValidationState`?

✅ glozow closed a pull request: "rpc: Add options argument to listtransactions, with paginatebypointer options"
(https://github.com/bitcoin/bitcoin/pull/19443)

💬 glozow commented on pull request "rpc: Add options argument to listtransactions, with paginatebypointer options":
(https://github.com/bitcoin/bitcoin/pull/19443#issuecomment-1864299069)
Closing due to lack of activity. Feel free to ping if this is picked up again.

💬 glozow commented on pull request "RPC: Add universal options argument to listtransactions":
(https://github.com/bitcoin/bitcoin/pull/22807#issuecomment-1864300507)
Are you still working on this?

💬 c0deright commented on issue "Old wallet.dat: Error reading wallet database: keymeta found with unexpected path / All keys read correctly, but transaction data or address metadata may be missing or incorrect":
(https://github.com/bitcoin/bitcoin/issues/29109#issuecomment-1864352916)
I used https://github.com/dan-da/hd-wallet-derive to derive

* 301 keys in path `m/0'/0'/0'` to `m/0'/0'/300'`
* 301 keys in path `m/0'/1'/0'` to `m/0'/1'/300'`

from the **xprv** like so:
```
php hd-wallet-derive.php -g --cols=path,privkey --key=xprv... --path="m/0'/0'/x'" --numderive 301 > xprv-0.txt
php hd-wallet-derive.php -g --cols=path,privkey --key=xprv... --path="m/0'/1'/x'" --numderive 301 > xprv-1.txt
```

Then I took all the private keys from the `walletdump` output and gre
...

🤔 glozow reviewed a pull request: "RPC: Add maxfeerate and maxburnamount args to submitpackage"
(https://github.com/bitcoin/bitcoin/pull/28950#pullrequestreview-1790751210)
Concept ACK

My ideal approach would be to not check client-side stuff inside validation, e.g. by adding a helper that loads coins (probably not extensible to chunk feerate but could maybe be a sufficient sanity check), or a test package accept + real submit (like the way `BroadcastTransaction` does it). But if it's unavoidable, then this seems fine. AFAICT it's extensible to checking chunk feerate in the future.

💬 kristapsk commented on pull request "RPC: Add universal options argument to listtransactions":
(https://github.com/bitcoin/bitcoin/pull/22807#issuecomment-1864433342)
> Are you still working on this?

Not at the moment. Feel free to close. Will open a new PR in future if will get back to this.

💬 mononaut commented on issue "Assertion failed: (data.size() > node.nSendOffset), function SocketSendData, file net.cpp, line 837":
(https://github.com/bitcoin/bitcoin/issues/27963#issuecomment-1864484504)
I believe I just saw the same issue reproduce on two separate instances running on the same machine:

```
2023-12-20T10:28:46Z UpdateTip: new best=00000000000000000001036517697dfb912067d7f66f311d815a568b2c9dc166 height=822072 version=0x2d338000 log2_work=94.612828 tx=939105193 date='2023-12-20T10:28:26Z' progress=1.000000 cache=119.3MiB(745842txo)
2023-12-20T10:29:02Z New outbound peer connected: version: 70016, blocks=822072, peer=722 (block-relay-only)
2023-12-20T10:31:50Z New outbound pe
...

🤔 furszy reviewed a pull request: "wallet: Have the wallet store the key for automatically generated descriptors"
(https://github.com/bitcoin/bitcoin/pull/26728#pullrequestreview-1787001982)
Finished another round, only small findings.

💬 furszy commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1432698232)
In 8bb7a8b0:

This is moved without an explanation. Could mention the rationale in the commit description.

💬 furszy commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1430231352)
In 2e840bcfc03:

Would be good to cleanup `m_hd_key` when `m_hd_crypted_key` is set and vice versa. Just as a safety measure in case this method is called twice pre and post encryption.

💬 furszy commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1432718349)
In 2e2545c3a:

Missing check for `LoadActiveHDPubKey()` output.

💬 furszy commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1430209041)
in 8bb7a8b06:

nit: as `ACTIVEHDKEY` is unique, we don't need to call `LoadRecords` here. Could call a bare `Read()` or implement a `GetActiveHDKey()` at the `WalletBatch` level.

💬 furszy commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1432692273)
In 8bb7a8b06:

`EXCLUSIVE_LOCKS_REQUIRED` annotation is not required.

💬 furszy commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1432727652)
In ce5495a4b27f:

Need to check `SetActiveHDKey()` output. If it fails, the procedure should fail.