💬 S3RK commented on issue "doc: Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/issues/18085#issuecomment-1859720008)
@Thanos107 #28974 already addresses this issue. Maybe you want to take a look at another one?

💬 Thanos107 commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#discussion_r1429642554)
Actually, yeah. I used Chatgpt to refine it.

Should I not have done that?

Actually, this is my first pull request, so I don't have any idea how this works.

I will remove this pull request and push another one if that's okay with you.

✅ maflcko closed an issue: "Any plans to implement the concepts Kaspa has?"
(https://github.com/bitcoin/bitcoin/issues/29105)

💬 maflcko commented on issue "Any plans to implement the concepts Kaspa has?":
(https://github.com/bitcoin/bitcoin/issues/29105#issuecomment-1859834282)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat, or one of the Bitcoin subreddits, or any other place that you feel is well suited.

Network-wide consensus and/or P2P changes first need to be discussed with the greater community, for example the `bitcoin-dev` maili
...

💬 maflcko commented on issue "rpc: decodescript fails for witness scripts with length larger than uint16":
(https://github.com/bitcoin/bitcoin/issues/29103#issuecomment-1859838225)
See also https://github.com/bitcoin/bitcoin/issues?q=is%3Aissue+%22Argument+list+too+long%22+is%3Aclosed

💬 Sjors commented on pull request "wallet, mempool: propagete `checkChainLimits` error message to wallet":
(https://github.com/bitcoin/bitcoin/pull/28863#discussion_r1429730115)
Indeed, or it could even be done as part of that PR. It depends on which one gets merged first.

💬 maflcko commented on pull request "NOMERGE UFG Default permitbaremultisig=0":
(https://github.com/bitcoin/bitcoin/pull/29093#issuecomment-1859845096)
If you want to learn more about contributing to Bitcoin Core, you can refer to the `CONTRIBUTING.md` file, which should answer any questions.

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1429782917)
Nice :+1:

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1859928729)
> Here's a small patch to add sigops-adjusted coverage for v3 children

Nice, taken

💬 fanquake commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#issuecomment-1859940781)
Closing in favour of #28974.

✅ fanquake closed a pull request: "Explain what the wallet password does"
(https://github.com/bitcoin/bitcoin/pull/29101)

:lock: fanquake locked an issue: "Any plans to implement the concepts Kaspa has?"
(https://github.com/bitcoin/bitcoin/issues/29105)

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#issuecomment-1859942803)
The code looks good. That's quite a small change and fully fixes the problem. Didn't repeat manual tests though, but there is an automatic test coverage. Great job!

CI failure seems relevant. I was able to reproduce locally, didn't have time to debug yet though. Will look tomorrow if nobody beats me to it.
```
Traceback (most recent call last):
File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/
...

💬 naumenkogs commented on pull request "p2p: attempt to fill full outbound connection slots with peers that support tx relay":
(https://github.com/bitcoin/bitcoin/pull/28538#discussion_r1429773492)
1393bf67b26c000483c750258ca9d1daeab8a2cb

not super clear why we won't do this `if full_outbound_delta > 0`?
Maybe a comment explaining why this could be possible in the first place could help (probably above the first if block).
Even now it's hard to tell if it's possible to be over the limit most-of-the-time, let alone if we add some new complexity for being over the limit more frequently (for some security reason or whatever).

💬 naumenkogs commented on pull request "p2p: attempt to fill full outbound connection slots with peers that support tx relay":
(https://github.com/bitcoin/bitcoin/pull/28538#discussion_r1429786276)
ad48667ec8e8d563550df768d0b45abf800662d9

gotta drop the second condition here?

💬 naumenkogs commented on pull request "p2p: attempt to fill full outbound connection slots with peers that support tx relay":
(https://github.com/bitcoin/bitcoin/pull/28538#discussion_r1429781523)
68769ff7c3252c7cfb8758459218979eacba7acb

You could expand this test by adding some irrelevant peers (e.g. ADDRFETCH), but no big deal.

💬 naumenkogs commented on pull request "p2p: attempt to fill full outbound connection slots with peers that support tx relay":
(https://github.com/bitcoin/bitcoin/pull/28538#discussion_r1429789777)
ad48667ec8e8d563550df768d0b45abf800662d9

might update this too `if (!Assume(state)) return` and drop the comment if you feel like it :)

💬 glozow commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#issuecomment-1859954716)
Not intended for merge. Not planning on rebasing right now since this should be built on top of cluster mempool and other WIP projects.

👍 Sjors approved a pull request: "wallet, mempool: propagete `checkChainLimits` error message to wallet"
(https://github.com/bitcoin/bitcoin/pull/28863#pullrequestreview-1786351038)
utACK 8dec9c560b53488c1e71d8f74241c7dce42cb387

💬 Sjors commented on pull request "wallet, mempool: propagete `checkChainLimits` error message to wallet":
(https://github.com/bitcoin/bitcoin/pull/28863#discussion_r1429805433)
```cpp
* @returns {} or the error reason if a limit is hit.
```