👍 luke-jr approved a pull request: "Update doc/policy/README.md"
(https://github.com/bitcoin/bitcoin/pull/29095#pullrequestreview-1785255931)
utACK, but maybe we should just have a table with them all somewhere instead?
(https://github.com/bitcoin/bitcoin/pull/29095#pullrequestreview-1785255931)
utACK, but maybe we should just have a table with them all somewhere instead?
💬 luke-jr commented on pull request "Ephemeral Anchors":
(https://github.com/bitcoin/bitcoin/pull/29001#issuecomment-1858907861)
>BIP text here: https://github.com/instagibbs/bips/blob/ephemeral_anchor/bip-ephemeralanchors.mediawiki
Node policy is not a subject matter for standardization in itself. It's the transaction format that the BIP (if there is one) should focus on, not speculative behaviour of individual nodes.
(https://github.com/bitcoin/bitcoin/pull/29001#issuecomment-1858907861)
>BIP text here: https://github.com/instagibbs/bips/blob/ephemeral_anchor/bip-ephemeralanchors.mediawiki
Node policy is not a subject matter for standardization in itself. It's the transaction format that the BIP (if there is one) should focus on, not speculative behaviour of individual nodes.
💬 AdamISZ commented on pull request "init: Error if ignored bitcoin.conf file is found":
(https://github.com/bitcoin/bitcoin/pull/27302#issuecomment-1858929206)
@ryanofsky I just wanted to give feedback that this kind of bit me [\*], in running Joinmarket tests - the `pytest` invocation just started hanging when using Bitcoin Core 26.0 and it took some investigating to see why. Not disastrous of course, but I was left bewildered - why would Core be complaining that there existed another `bitcoin.conf` in `~/.bitcoin` when I had explicitly set `-conf=/somewhere/else/bitcoin.conf`? I've skimmed the thread but I don't really get the logic. Is it something
...
(https://github.com/bitcoin/bitcoin/pull/27302#issuecomment-1858929206)
@ryanofsky I just wanted to give feedback that this kind of bit me [\*], in running Joinmarket tests - the `pytest` invocation just started hanging when using Bitcoin Core 26.0 and it took some investigating to see why. Not disastrous of course, but I was left bewildered - why would Core be complaining that there existed another `bitcoin.conf` in `~/.bitcoin` when I had explicitly set `-conf=/somewhere/else/bitcoin.conf`? I've skimmed the thread but I don't really get the logic. Is it something
...
🤔 pablomartin4btc reviewed a pull request: "Wallet: Calculate used balance from GetBalance(...)"
(https://github.com/bitcoin/bitcoin/pull/29062#pullrequestreview-1785308728)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/29062#pullrequestreview-1785308728)
Concept ACK
💬 pablomartin4btc commented on pull request "Wallet: Calculate used balance from GetBalance(...)":
(https://github.com/bitcoin/bitcoin/pull/29062#discussion_r1428925448)
What about caculating `avoid_reuse` locally (e.g. `const bool avoid = !(m_wallet->IsWalletFlagSet(WALLET_FLAG_AVOID_REUSE));` at the beginning of the function), instead of passing it? I thought @achow101's [comment](https://github.com/bitcoin/bitcoin/pull/28776/files#r1407875236) was referring to include that too but maybe I'm wrong.
(https://github.com/bitcoin/bitcoin/pull/29062#discussion_r1428925448)
What about caculating `avoid_reuse` locally (e.g. `const bool avoid = !(m_wallet->IsWalletFlagSet(WALLET_FLAG_AVOID_REUSE));` at the beginning of the function), instead of passing it? I thought @achow101's [comment](https://github.com/bitcoin/bitcoin/pull/28776/files#r1407875236) was referring to include that too but maybe I'm wrong.
💬 andrewtoth commented on pull request "sync: improve CCoinsViewCache ReallocateCache":
(https://github.com/bitcoin/bitcoin/pull/28945#discussion_r1428946493)
The purpose of `ReallocateCache` originally was to balance the snapshot and background chainstate caches (see https://github.com/bitcoin/bitcoin/pull/18637). However, in https://github.com/bitcoin/bitcoin/pull/25325/commits/5e4ac5abf54f8e6d6330df0c73119aa0cca4c103 this function was removed from `ResizeCoinsCaches` and moved to `Flush`. This created an implicit assumption that calling `Flush` would clear the memory in the cache. This change violates that assumption, since the memory will no longe
...
(https://github.com/bitcoin/bitcoin/pull/28945#discussion_r1428946493)
The purpose of `ReallocateCache` originally was to balance the snapshot and background chainstate caches (see https://github.com/bitcoin/bitcoin/pull/18637). However, in https://github.com/bitcoin/bitcoin/pull/25325/commits/5e4ac5abf54f8e6d6330df0c73119aa0cca4c103 this function was removed from `ResizeCoinsCaches` and moved to `Flush`. This created an implicit assumption that calling `Flush` would clear the memory in the cache. This change violates that assumption, since the memory will no longe
...
💬 andrewtoth commented on pull request "sync: improve CCoinsViewCache ReallocateCache":
(https://github.com/bitcoin/bitcoin/pull/28945#discussion_r1428961040)
Should this parameter be added to the fuzz targets or unit tests?
(https://github.com/bitcoin/bitcoin/pull/28945#discussion_r1428961040)
Should this parameter be added to the fuzz targets or unit tests?
🤔 luke-jr reviewed a pull request: "versionbits refactoring"
(https://github.com/bitcoin/bitcoin/pull/29039#pullrequestreview-1785323162)
Concept NACK, refactoring without a purpose, and probably makes more work for merging BIP8.
(https://github.com/bitcoin/bitcoin/pull/29039#pullrequestreview-1785323162)
Concept NACK, refactoring without a purpose, and probably makes more work for merging BIP8.
📝 SatoshiNT0 opened a pull request: "Update COPYING"
(https://github.com/bitcoin/bitcoin/pull/29099)
<!--
That must be the correct MIT license. Because it was taken from my original project.
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core
...
(https://github.com/bitcoin/bitcoin/pull/29099)
<!--
That must be the correct MIT license. Because it was taken from my original project.
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core
...
🤔 SatoshiNT0 reviewed a pull request: "Update COPYING"
(https://github.com/bitcoin/bitcoin/pull/29099#pullrequestreview-1785331767)
That must be the correct MIT license. Because it was taken from my original project.
(https://github.com/bitcoin/bitcoin/pull/29099#pullrequestreview-1785331767)
That must be the correct MIT license. Because it was taken from my original project.
✅ achow101 closed a pull request: "Update COPYING"
(https://github.com/bitcoin/bitcoin/pull/29099)
(https://github.com/bitcoin/bitcoin/pull/29099)
📝 achow101 locked a pull request: "Update COPYING"
(https://github.com/bitcoin/bitcoin/pull/29099)
<!--
That must be the correct MIT license. Because it was taken from my original project.
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core
...
(https://github.com/bitcoin/bitcoin/pull/29099)
<!--
That must be the correct MIT license. Because it was taken from my original project.
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core
...
💬 BrandonOdiwuor commented on pull request "Wallet: Calculate used balance from GetBalance(...)":
(https://github.com/bitcoin/bitcoin/pull/29062#discussion_r1429014044)
> have it always compute the used balance for us rather than having the caller do this extra computation.
My understanding of this part of @achow101 [comment](https://github.com/bitcoin/bitcoin/pull/28776/files#r1407875236) was to move the calculation for the `used` balance to `GetBalance(...)`
I have updated the PR and added `GetFullBalance()` which adds `used` balance to `GetBalance(...)`
(https://github.com/bitcoin/bitcoin/pull/29062#discussion_r1429014044)
> have it always compute the used balance for us rather than having the caller do this extra computation.
My understanding of this part of @achow101 [comment](https://github.com/bitcoin/bitcoin/pull/28776/files#r1407875236) was to move the calculation for the `used` balance to `GetBalance(...)`
I have updated the PR and added `GetFullBalance()` which adds `used` balance to `GetBalance(...)`
📝 gosu93 opened a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/29100)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/29100)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
📝 achow101 locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29100)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/29100)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
💬 maflcko commented on pull request "Update doc/policy/README.md":
(https://github.com/bitcoin/bitcoin/pull/29095#issuecomment-1859154827)
> table with them all somewhere instead?
Are they not listed in the `-help` already? There is even a category for them, no?
(https://github.com/bitcoin/bitcoin/pull/29095#issuecomment-1859154827)
> table with them all somewhere instead?
Are they not listed in the `-help` already? There is even a category for them, no?
📝 fanquake locked a pull request: "ci: uninstall aws-sam-cli"
(https://github.com/bitcoin/bitcoin/pull/29092)
Test alternative to #29080.
(https://github.com/bitcoin/bitcoin/pull/29092)
Test alternative to #29080.
📝 LarryRuane converted_to_draft a pull request: "test: test_bitcoin: allow -testdatadir=<datadir>"
(https://github.com/bitcoin/bitcoin/pull/26564)
This backward-compatible change would help with code review and testing. When `test_bitcoin` runs, it creates a working or data directory within `/tmp/test_common_Bitcoin\ Core/`, named as a long random (hex) string.
This small patch does three things:
- If the (new) argument `-testdatadir=<datadir>` is given, it replaces the random string path component with this argument as the test's working directory
- When the test starts, remove the working directory if it exists from an earlier run
...
(https://github.com/bitcoin/bitcoin/pull/26564)
This backward-compatible change would help with code review and testing. When `test_bitcoin` runs, it creates a working or data directory within `/tmp/test_common_Bitcoin\ Core/`, named as a long random (hex) string.
This small patch does three things:
- If the (new) argument `-testdatadir=<datadir>` is given, it replaces the random string path component with this argument as the test's working directory
- When the test starts, remove the working directory if it exists from an earlier run
...
💬 andrewtoth commented on pull request "sync: improve CCoinsViewCache ReallocateCache":
(https://github.com/bitcoin/bitcoin/pull/28945#issuecomment-1859181762)
Ran same hyperfine benchmark with base, 985ddd954199cb7686ac75d12492d25b16d235c8, and head of branch. Got similar results :rocket:.
```
Summary
./src/bitcoind -dbcache=500 -reindex-chainstate -printtoconsole=0 -stopatheight=500000 (commit = ceeb71816512642e92a110b2cf5d2549d090fe78) ran
1.06 ± 0.00 times faster than ./src/bitcoind -dbcache=500 -reindex-chainstate -printtoconsole=0 -stopatheight=500000 (commit = 985ddd954199cb7686ac75d12492d25b16d235c8)
1.07 ± 0.00 times faster th
...
(https://github.com/bitcoin/bitcoin/pull/28945#issuecomment-1859181762)
Ran same hyperfine benchmark with base, 985ddd954199cb7686ac75d12492d25b16d235c8, and head of branch. Got similar results :rocket:.
```
Summary
./src/bitcoind -dbcache=500 -reindex-chainstate -printtoconsole=0 -stopatheight=500000 (commit = ceeb71816512642e92a110b2cf5d2549d090fe78) ran
1.06 ± 0.00 times faster than ./src/bitcoind -dbcache=500 -reindex-chainstate -printtoconsole=0 -stopatheight=500000 (commit = 985ddd954199cb7686ac75d12492d25b16d235c8)
1.07 ± 0.00 times faster th
...