💬 fanquake commented on pull request "wallet: birth time update during tx scanning":
(https://github.com/bitcoin/bitcoin/pull/28920#issuecomment-1857652507)
Adding to #29011 for backporting to 26.x.

💬 maflcko commented on pull request "refactor: Remove gmtime*":
(https://github.com/bitcoin/bitcoin/pull/29081#discussion_r1427839317)
Thx, done

💬 maflcko commented on pull request "refactor: Remove gmtime*":
(https://github.com/bitcoin/bitcoin/pull/29081#issuecomment-1857683898)
> Concept ACK - can we also drop the Boost date_time usage from `ParseISO8601DateTime` in favour of the std lib?

Probably no. `std::chrono::parse` isn't released yet in gcc at all, or did you mean something else?

💬 fanquake commented on pull request "refactor: Remove gmtime*":
(https://github.com/bitcoin/bitcoin/pull/29081#issuecomment-1857693940)
> Probably no. std::chrono::parse isn't released yet in gcc at all, or did you mean something else?

Damn. I just meant any possibility to get rid of Boost.

💬 eriknylund commented on pull request "test: verify spend from 999-of-999 taproot multisig wallet":
(https://github.com/bitcoin/bitcoin/pull/28212#discussion_r1427850857)
I'll lower it to 100 unless @achow101 thinks the `send` RPC approach would work efficiently here.

👍 maflcko approved a pull request: "logging: Simplify API for level based logging"
(https://github.com/bitcoin/bitcoin/pull/28318#pullrequestreview-1783613918)
re-ACK 16dd9042ea81412607c0645e4a3cc152abdc4d9a 😹

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: re-ACK 16dd9042ea81412607c0
...

💬 maflcko commented on pull request "logging: Simplify API for level based logging":
(https://github.com/bitcoin/bitcoin/pull/28318#discussion_r1427853723)
nit (same): "with the startup options `-debug...`."

💬 maflcko commented on pull request "refactor: Remove gmtime*":
(https://github.com/bitcoin/bitcoin/pull/29081#issuecomment-1857706842)
> > Probably no. std::chrono::parse isn't released yet in gcc at all, or did you mean something else?
>
> Damn. I just meant any possibility to get rid of Boost.

At least this one is header-only in a single translation unit, so should be fine to stay around for another 3 years

💬 eriknylund commented on pull request "test: verify spend from 999-of-999 taproot multisig wallet":
(https://github.com/bitcoin/bitcoin/pull/28212#discussion_r1427861597)
@Sjors just to make sure, did you mean 100-of-100? Or should I leave this out completely and just keep the 1-of-0 and 1-of-1000 tests further down that utilises the same new helper method?
```
# Test 100-of-100
self.do_test_k_of_n(100, 100)
```

💬 Ayush170-Future commented on pull request "fuzz: wallet, add target for Spend":
(https://github.com/bitcoin/bitcoin/pull/28236#discussion_r1427877760)
Yeah, I can create a separate PR for this immediately. Once it's ready, we can merge it, and I can continue working on this. Thanks!

📝 maflcko opened a pull request: "[28.x] build: Bump g++ minimum supported version to 11"
(https://github.com/bitcoin/bitcoin/pull/29091)
This drops support for vanilla Ubuntu Focal 20.04 and Debian (Oldstable) Bullseye. User on those operating systems would have to stick with a previous release branch of Bitcoin Core, upgrade their system, compile their own compiler, or use a non-vanilla package manager.

Otherwise, g++-11 is offered by common distributions:

* https://packages.ubuntu.com/jammy/g++ (`g++-11`)
* https://packages.debian.org/bookworm/g++ (`g++-12`)
* FreeBSD 12/13 ships with g++ 12
* CentOS-like 9 ships with
...

💬 fanquake commented on pull request "ci: Set `HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK` to avoid unrelated failures":
(https://github.com/bitcoin/bitcoin/pull/29080#issuecomment-1857782568)
This, or some other solution will also need to be backported to 26.x. I think a simpler solution would have just been to uninstall `aws-sam-cli` as the first step. Which should solve the problem, have no other side-effects, and retain the speedup, given it's related to upgrading it's deps.

💬 maflcko commented on pull request "ci: Set `HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK` to avoid unrelated failures":
(https://github.com/bitcoin/bitcoin/pull/29080#issuecomment-1857785266)
Won't the other dependencies also be upgraded and thus slow down the CI?

💬 fanquake commented on pull request "ci: Set `HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK` to avoid unrelated failures":
(https://github.com/bitcoin/bitcoin/pull/29080#issuecomment-1857792354)
I don't know. However If the issue was sub dependencies (`Fetching dependencies for aws-sam-cli: python-setuptools, python-attrs, python-dateutil, python-networkx, python-pbr, python-mpmath, python-sympy, python-urllib3, ca-certificates, cfn-lint, pygments, python-click, python-markupsafe, python-jinja, python-certifi, python-charset-normalizer, python-idna, python-requests, cookiecutter and python-cryptography`) of something being upgraded (`aws-sam-cli`), also being upgraded, if (`aws-sam-cli`
...

💬 maflcko commented on pull request "fuzz: Limit p2p fuzz targets to MAX_PROTOCOL_MESSAGE_LENGTH":
(https://github.com/bitcoin/bitcoin/pull/29079#issuecomment-1857793891)
(CI failure can be ignored)

💬 eriknylund commented on pull request "test: verify spend from 999-of-999 taproot multisig wallet":
(https://github.com/bitcoin/bitcoin/pull/28212#discussion_r1427914041)
The CI machines seem to make it through without timeout:
https://github.com/bitcoin/bitcoin/actions/runs/7221218374/job/19675746505?pr=28212#step:7:3594
https://github.com/bitcoin/bitcoin/actions/runs/7221218374/job/19675746796?pr=28212#step:27:330

However, the test runs for 15 minutes on the Win64 job and for 20 minutes on the macOS job, making it the longest running functional test by far.

💬 maflcko commented on pull request "build: Bump guix time-machine to unlock riscv64 metal":
(https://github.com/bitcoin/bitcoin/pull/29078#issuecomment-1857797253)
Looks like it just built the first host and hopped over to the next. 🥹


```
+ echo /outdir-base/dist-archive/bitcoin-fa87a2072b91.tar.gz
+ find /outdir-base/x86_64-linux-gnu -type f
+ xargs realpath --relative-base=/outdir-base
+ xargs sha256sum
+ sponge /outdir-base/x86_64-linux-gnu/SHA256SUMS.part
+ sort -k2
INFO: Building fa87a2072b91 for platform triple arm-linux-gnueabihf:
...using reference timestamp: 1702550613
...running at most 4 jobs
...from worktree di
...

📝 fanquake opened a pull request: "ci: uninstall aws-sam-cli"
(https://github.com/bitcoin/bitcoin/pull/29092)
Test alternative to #29080.

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1427921363)
Yep good catch! I've now built this into `PackageV3Checks` instead of a separate function, so marking this as resolved.

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1427921992)
This line ended up going away since I wrote slightly smarter ancestor limit checking in `PackageV3Checks`, marking as resolved