🤔 Mita23456 reviewed a pull request: "[26.x] Changes for rc3"
(https://github.com/bitcoin/bitcoin/pull/28872#pullrequestreview-1783218094)
So not doing at

🤔 Mita23456 reviewed a pull request: "[26.x] Changes for rc3"
(https://github.com/bitcoin/bitcoin/pull/28872#pullrequestreview-1783220557)
Hello

💬 Mita23456 commented on pull request "[26.x] Changes for rc3":
(https://github.com/bitcoin/bitcoin/pull/28872#discussion_r1427615063)
Yep

💬 Mita23456 commented on pull request "[26.x] Changes for rc3":
(https://github.com/bitcoin/bitcoin/pull/28872#discussion_r1427614919)
Ok

📝 achow101 opened a pull request: "Update security.md contact for achow101"
(https://github.com/bitcoin/bitcoin/pull/29087)

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1857419461)
> This is clearly a local issue / misconfiguration, not a problem with Core.

Changing the terminal config to running it without rosetta worked, Thanks Guys!

📝 ajtowns opened a pull request: "tests: Don't depend on value of DEFAULT_PERMIT_BAREMULTISIG"
(https://github.com/bitcoin/bitcoin/pull/29088)
Update unit and functional tests so that they continue to work if the default for `-permitbaremultisig` is changed.

💬 maflcko commented on pull request "tests: Don't depend on value of DEFAULT_PERMIT_BAREMULTISIG":
(https://github.com/bitcoin/bitcoin/pull/29088#issuecomment-1857486872)
```
elay_fee, std::string& reason);
| ^
test/script_p2sh_tests.cpp:29:43: error: argument name 'permit_baremultisig' in comment does not match parameter name 'permit_bare_multisig' [bugprone-argument-comment,-warnings-as-errors]
29 | IsStandardTx(tx, std::nullopt, /*permit_baremultisig=*/false, CFeeRate{DUST_RELAY_TX_FEE}, reason);
|
...

✅ maflcko closed an issue: "Not able to build and compile on macos"
(https://github.com/bitcoin/bitcoin/issues/29083)

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1857487522)
Good to hear. Closing for now.

💬 maflcko commented on pull request "Update security.md contact for achow101":
(https://github.com/bitcoin/bitcoin/pull/29087#issuecomment-1857489114)
lgtm ACK e7d66509dc393400079eb885a497dd4e968eade6

💬 maflcko commented on issue "Discussion: Upgrading to C++20":
(https://github.com/bitcoin/bitcoin/issues/23363#issuecomment-1857497397)
> Having `std::span<>` with the size as part of the type rather than a runtime thing could be nice for the various crypto things where we currently do things like `assert(key.size() == KEYLEN)`.

I guess this requires a helper method to safely convert to a fixed-size span, internally preferring a compile-time check, or falling back to an assert, if it isn't available?

💬 maflcko commented on pull request "refactor: C++20: Use lambda implicit capture and std::rotl":
(https://github.com/bitcoin/bitcoin/pull/29085#issuecomment-1857506138)
Not sure. This needs a benchmark to check against slowdown, see https://github.com/bitcoin/bitcoin/pull/29057#issuecomment-1854487602

Also, C++20 is enabled for years, so I don't understand the other commit. I think you either forgot to compile locally, or your compiler doesn't emit any warnings that the changes are wrong?

💬 maflcko commented on pull request "tests: Don't depend on value of DEFAULT_PERMIT_BAREMULTISIG":
(https://github.com/bitcoin/bitcoin/pull/29088#issuecomment-1857548697)
lgtm ACK 7b45744df33c6a4759eae1a3984f389cbac837c2

⚠️ ChrisMartl opened an issue: "Bitcoin's systemic flaw"
(https://github.com/bitcoin/bitcoin/issues/29089)
“Bitcoin” doesn’t have a government (a coercion power), and thus must really on **market processes** i.e. on prices, which are determined by supply and demand. Consumer's wants and needs are signaled through prices, which are in turn satisfied by producers, who want to make a **profit**.

In this sense, it seems to be a “Bitcoin” systemic flaw, that a valuable information like the “**timechain**” is not provided to the consumer in exchange for Sats; i.e. no market, no price mechanism and thus no
...

💬 brunoerg commented on pull request "fuzz: coinselection, improve `min_viable_change`/`change_output_size`":
(https://github.com/bitcoin/bitcoin/pull/28372#issuecomment-1857557432)
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/28372#issuecomment-1856559034 and https://github.com/bitcoin/bitcoin/pull/28372#discussion_r1427177813. Thanks @murchandamus and @furszy for the review!

Left it running for 10h before pushing and did not crash.

💬 TheCharlatan commented on pull request "[refactor] Check CTxMemPool options in ctor":
(https://github.com/bitcoin/bitcoin/pull/28830#issuecomment-1857559238)
Rebased 3aa41a31690da2ae22b6a15a9a5de0de78a01757 -> 571fa4f4c5c9792457a8a6ec77da980ae2d239e7 ([mempoolArgs_2](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_2) -> [mempoolArgs_3](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/mempoolArgs_2..mempoolArgs_3))

Updated 571fa4f4c5c9792457a8a6ec77da980ae2d239e7 -> 364456f6598b135fcc0acab8a660658b4407f837 ([mempoolArgs_3](https://github.com/TheCharlatan/bitcoin/tree/me
...

💬 fanquake commented on pull request "refactor: C++20: Use lambda implicit capture and std::rotl":
(https://github.com/bitcoin/bitcoin/pull/29085#issuecomment-1857585948)
```bash
txmempool.cpp:88:61: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
88 | mapTx.modify(mapTx.iterator_to(descendant), [=, this](CTxMemPoolEntry& e) {
| ~~^~~~
txmempool.cpp:99:32: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
99 | mapTx.modify(updateIt, [=, this](CTxMemPoolEntry& e) { e.UpdateDescendantState(modifySize, modifyFee, modifyCount)
...

⚠️ fanquake opened an issue: "ci: feature_proxy failing in MSVC job"
(https://github.com/bitcoin/bitcoin/issues/29090)
https://github.com/bitcoin/bitcoin/actions/runs/7219794888/job/19671475361?pr=29088#step:27:73:
```bash
288/288 - feature_proxy.py failed, Duration: 2410 s

stdout:
2023-12-15T08:53:02.026000Z TestFramework (INFO): PRNG seed is: 197024891591373016

2023-12-15T08:53:02.026000Z TestFramework (INFO): Initializing test directory D:\a\_temp\test_runner_₿_🏃_20231215_084456\feature_proxy_168

2023-12-15T09:33:11.259000Z TestFramework (ERROR): Assertion failed

Traceback (most recent call la
...

💬 fanquake commented on pull request "Revert "ci: Only run functional tests on windows in master"":
(https://github.com/bitcoin/bitcoin/pull/29059#issuecomment-1857593249)
Looks like these are still just randomly failing: #29090 ?