💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856567568)
> @sarthak13gupta
>
> Did you move your macOS from x86_64 (Intel) machine to a new Apple Silicon based one?
>
> (I saw a similar issue back then)

Nope it's an m1 so I guess that would be arm64 since the start.

💬 hebasto commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856580214)
If nothing else helps, I would suggest to remove and reinstall Homebrew from scratch.

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856587924)
The issue persists... this is what I'm getting after running
`./configure`
https://gist.github.com/sarthak13gupta/6ab7cf9b402a3695b20da574a5957804
and
`make`
https://gist.github.com/sarthak13gupta/a993a3f2eb2183b32c1e6042fe7d96db
commands.
also, another command used initially was `git checkout v26.0` to checkout to 26.0

Also, should I reinstall command line tools as well, given the issue below?
<img width="1256" alt="Screenshot 2023-12-15 at 2 32 40 AM" src="https://github.com/bit
...

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856597168)
For reference, the configure output seems to target x86:

```
% ./configure --disable-bench --disable-fuzz-binary --enable-debug --without-gui --enable-suppress-external-warnings --without-bdb
checking for pkg-config... /opt/homebrew/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking build system type... x86_64-apple-darwin22.1.0
checking host system type... x86_64-apple-darwin22.1.0
...

💬 fanquake commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856600045)
You said you're running on arm, but configure says otherwise:
> checking build system type... x86_64-apple-darwin22.1.0

Is your terminal running under Rosetta or something.

💬 fanquake commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856603897)
This is clearly a local issue / misconfiguration, not a problem with Core.

💬 achow101 commented on pull request "wallet: birth time update during tx scanning":
(https://github.com/bitcoin/bitcoin/pull/28920#issuecomment-1856605477)
ACK 1ce45baed7dd2da3f1cb85c9c25110e5537451ae

💬 murchandamus commented on pull request "Add multiplication operator to CFeeRate":
(https://github.com/bitcoin/bitcoin/pull/29037#issuecomment-1856612479)
Thanks @kashifs, I’ve merged your pull request into my pull request and pushed it.

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856618608)
Could this be due to an env var? Maybe check `env | grep 'HOST='`?

💬 brunoerg commented on pull request "fuzz: coinselection, improve `min_viable_change`/`change_output_size`":
(https://github.com/bitcoin/bitcoin/pull/28372#issuecomment-1856620276)
> So, instead of passing coin_params.m_cost_of_change and 0, we should be passing coin_params.min_viable_change and coin_params.m_change_fee. Just fixing one or the other was insufficient, but when I replace both all my fuzz crashes pass.

Cool, I think the 0 came from the way we call `ComputeAndSetWaste` internally in `SelectCoinsBnB`.

💬 brunoerg commented on pull request "fuzz: coinselection, improve `min_viable_change`/`change_output_size`":
(https://github.com/bitcoin/bitcoin/pull/28372#issuecomment-1856623275)
Thanks, @furszy and @murchandamus. I will address the suggestions and leave it running for some time before pushing.

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856629535)
> You said you're running on arm, but configure says otherwise:
>
> > checking build system type... x86_64-apple-darwin22.1.0
>
> Is your terminal running under Rosetta or something.

Yes, now that I checked because it gives compatibility issues with dependencies sometimes.

Should I change it and run it without Rosseta?

But I don't know why this would happen , also when brew is located at `/opt/homebrew/bin/brew`
and I'm installing dependencies using
`arch -arm64 brew install
...

💬 amitiuttarwar commented on pull request "p2p: Increase tx relay rate":
(https://github.com/bitcoin/bitcoin/pull/28592#issuecomment-1856639108)
posted a topic to [delving bitcoin](https://delvingbitcoin.org/t/warnet-increase-tx-relay-rate/294) to brainstorm using warnet to evaluate the impacts of this change

🚀 achow101 merged a pull request: "wallet: birth time update during tx scanning"
(https://github.com/bitcoin/bitcoin/pull/28920)

🤔 mzumsande reviewed a pull request: "test: create deterministic addrman in the functional tests"
(https://github.com/bitcoin/bitcoin/pull/29007#pullrequestreview-1782655123)
Concept ACK

Needs rebase due to a silent conflict with #27581 (`feature_asmap.py`).

💬 mzumsande commented on pull request "test: create deterministic addrman in the functional tests":
(https://github.com/bitcoin/bitcoin/pull/29007#discussion_r1427230831)
nit: code style, `relay_for_tests`

💬 achow101 commented on pull request "refactor: Remove pre-C++20 code, fs::path cleanup":
(https://github.com/bitcoin/bitcoin/pull/29040#issuecomment-1856669579)
ACK 66667130416b86208e01a0eb5541a15ea805ac26

💬 mzumsande commented on pull request "test: create deterministic addrman in the functional tests":
(https://github.com/bitcoin/bitcoin/pull/29007#discussion_r1427322222)
Are you suggesting to have to move other existing test-only options (`-acceptstalefeeestimates` or `-fastprune` come to mind) under this command?

💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#issuecomment-1856680153)
> I think that it should be possible to resolve the problem in a simpler way and without touching unrelated stuff (like when to start "extra block-relay-only connections")

Please look https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1296355296.
The convo started from a different angle but I think the outcome addresses your concern.
We ended up agreeing that keeping the extra block relay connection logic as is in the current change set actually improves certain scenarios. For instan
...

💬 furszy commented on pull request "fuzz: coinselection, improve `min_viable_change`/`change_output_size`":
(https://github.com/bitcoin/bitcoin/pull/28372#issuecomment-1856697460)
> Just an observation on @furszy's suggestion - I think it will cause `stack-buffer-overflow`:
>
> ```diff
> - const auto dust{GetDustThreshold(change_prototype_txout, coin_params.m_discard_feerate)};
> + // We only care about the change output size
> + CScript change_out_script;
> + std::fill_n(change_out_script.begin(), coin_params.change_output_size, OP_TRUE);
> + const auto dust{GetDustThreshold(CTxOut{/*nValueIn=*/0, change_out_script}, coin_params.m_discard_feerate)}
...