Bitcoin Core Github
44 subscribers
121K links
Download Telegram
👋 TheCharlatan's pull request is ready for review: "refactor: Split logging utilities from system.h"
(https://github.com/bitcoin/bitcoin/pull/27238)
💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1132331631)
You'll have to do this sync on `t.start`, *before* `walletlock`, not *after* `walletlock`, no?

Otherwise this doesn't achieve what you want and will fail anyway:

```
AssertionError: [node 0] Expected messages "['Rescan started from block 0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206... (slow variant inspecting all blocks)']" does not partially match log:
```

To test:

```diff
diff --git a/test/functional/wallet_importdescriptors.py b/test/functional/wallet_import
...
💬 MarcoFalke commented on issue "Issue with `wallet_importdescriptors.py --descriptors` under valgrind":
(https://github.com/bitcoin/bitcoin/issues/27229#issuecomment-1463760044)
Maybe re-try after https://github.com/bitcoin/bitcoin/pull/27199 ?
👍 TheCharlatan approved a pull request: "refactor: Consistenly use context args over gArgs in node/interfaces"
(https://github.com/bitcoin/bitcoin/pull/27239)
ACK [facbb44](https://github.com/bitcoin/bitcoin/pull/27239/commits/facbb444bf5aea2bbaa4a4246a8a2c661d9bf314)

This has been confusing me recently, thank you for cleaning this up. I reproduced the patchset and did not find similar mixed uses of context and gArgs in other files.
💬 MarcoFalke commented on pull request "doc: Show how less noisy clang-tidy output can be achieved":
(https://github.com/bitcoin/bitcoin/pull/27205#discussion_r1132336428)
Why not just modify the above command to include this? (And then mention that `--config` can be omitted, if someone really wants to)

I'd suspect that you run into a wall of errors anyway without `--config`
💬 Sjors commented on issue "ops: Enable DNSSEC on all Bitcoin DNS Seed domain names":
(https://github.com/bitcoin/bitcoin/issues/19714#issuecomment-1463768303)
I just noticed @Emzy's script and PR on the seeder repo. Will look into it soon(tm).
💬 Sjors commented on pull request "assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/15606#discussion_r1132363873)
Optimistically bumping the block, but also making sure I don't keep putting the wrong numbers here:

```cpp
/*height=*/780000,
{AssumeutxoHash{uint256S(/*txoutset_hash=*/"0x97d2989ab4c1b2cfb4eaa37788aeea08a3a6757eabd94ae9b7cdde07e79381da")},
/*nchaintx=*/812391117},
```

Maybe also add a string initialiser to `AssumeutxoHash` to avoid the extra `uint256S`.
🚀 fanquake merged a pull request: "Add test and docs for getblockfrompeer with pruning"
(https://github.com/bitcoin/bitcoin/pull/23813)
🚀 fanquake merged a pull request: "test: Use self.wait_until over wait_until_helper"
(https://github.com/bitcoin/bitcoin/pull/27226)
💬 fanquake commented on issue "Issue in `p2p_ibd_stalling.py` under Valgrind":
(https://github.com/bitcoin/bitcoin/issues/27208#issuecomment-1463802608)
Fixed by #27226.
fanquake closed an issue: "Issue in `p2p_ibd_stalling.py` under Valgrind"
(https://github.com/bitcoin/bitcoin/issues/27208)
💬 TheCharlatan commented on pull request "doc: Show how less noisy clang-tidy output can be achieved":
(https://github.com/bitcoin/bitcoin/pull/27205#discussion_r1132379578)
I don't mind either way. I added a separate explainer, because it felt a bit too information-dense otherwise. Also, I only have bear version 3 to test. Does bear version 2 also accept `--config`?
🚀 fanquake merged a pull request: "test: add coverage for sigop limit policy (`-bytespersigop` setting)"
(https://github.com/bitcoin/bitcoin/pull/27171)
💬 fanquake commented on issue "Issue with `wallet_importdescriptors.py --descriptors` under valgrind":
(https://github.com/bitcoin/bitcoin/issues/27229#issuecomment-1463812501)
> Maybe re-try after https://github.com/bitcoin/bitcoin/pull/27199 ?

Running that on master at the moment.
💬 MarcoFalke commented on pull request "doc: Show how less noisy clang-tidy output can be achieved":
(https://github.com/bitcoin/bitcoin/pull/27205#discussion_r1132385355)
Seems fine to drop version 2
fanquake closed a pull request: "Scale network graph based on time interval"
(https://github.com/bitcoin-core/gui/pull/539)
💬 MarcoFalke commented on issue "Issue with `wallet_importdescriptors.py --descriptors` under valgrind":
(https://github.com/bitcoin/bitcoin/issues/27229#issuecomment-1463817073)
I don't think it currently works in the current form.
💬 Sjors commented on pull request "assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/15606#discussion_r1132390967)
It would be useful to have information about dbcache allocation (and usage) here.
💬 MarcoFalke commented on issue "Run functional tests from make check":
(https://github.com/bitcoin/bitcoin/issues/18816#issuecomment-1463821930)
Given that we will switch from cmake to make, it could make sense to wait for that and then only implement this in cmake?
🚀 fanquake merged a pull request: "Use string interpolation for default value of -listen"
(https://github.com/bitcoin/bitcoin/pull/27232)