💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413211947)
Thanks, also removed the following line and tweaked the return statement.

📝 BoyManWamen opened a pull request: "Create bitcoin.txt"
(https://github.com/bitcoin/bitcoin/pull/28991)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ BoyManWamen closed a pull request: "Create bitcoin.txt"
(https://github.com/bitcoin/bitcoin/pull/28991)

📝 fanquake locked a pull request: "Create bitcoin.txt"
(https://github.com/bitcoin/bitcoin/pull/28991)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#issuecomment-1837610357)
Updates: addressed @andrewtoth's feedback, thanks again!

💬 andrewtoth commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413214496)
Sorry, not sure what you mean here. It looks to me like this function is called for every argument passed to bitcoin-cli, and therefore this set will be initialized for every argument instead of just once.

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413216635)
Right, sorry, I haven't expressed myself correctly, I meant that the validation was only "used" once but you are right, the `IsExclusivelyCliCommand` function is called for every argument passed to `bitcoin-cli`, still, `static` would keep the set throughout the lifetime of the program.

💬 ariard commented on pull request "Nuke adjusted time (attempt 2)":
(https://github.com/bitcoin/bitcoin/pull/28956#discussion_r1413301629)
I think one advance in term of robustness of this local time monitoring mechanism could be to add feeler ’s time offset (`ConnectionType::FEELER`) to reserved slots in the index (e.g +3 on the 10 full-outbound connections). Those peers connections are already triggered at regular interval, which is not necessarily the case of outbound peer topology if the peers are stable and performant.

I guess a NTP-attacker could silently time shift the local clock of a victim, without this warning logic e
...

🤔 ariard reviewed a pull request: "Nuke adjusted time (attempt 2)"
(https://github.com/bitcoin/bitcoin/pull/28956#pullrequestreview-1761497233)
Concept ACK

I would recommend to add an explicit release note, inciting nodes operators to monitor this new warning, especially if they’re running time-sensitive apps. Exploiting NTP to target bitcoin has been suggested both in NTP security literature and the time-dilation paper (I’ve never seen or heard any in the wild, contrary to some BGP attacks in other cryptos though I believe this is fairly practical). E.g

```
new local clock monitoring
==========================

The notion of
...

💬 ariard commented on pull request "doc: Add multiprocess design doc":
(https://github.com/bitcoin/bitcoin/pull/28978#discussion_r1413316233)
- Generating server / client code in different langages (e.g C++ -> Rust or Rust -> C++) from a common set of `capnp` files and with compatible interfaces.

💬 ariard commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1837780398)
> Also I think we should resurrect https://github.com/bitcoin/bitcoin/pull/27018 so that we will mine everything in the mempool, but that doesn't need to be in this PR (and probably isn't strictly necessary either).

I don’t know about automatically flushing out <= 0 fees even when the local mempool is empty. One could add significant computing payload on its mining competitors by throwing buffy packages with 0 fees parent and then replace the high-fee child (in a cycle). A more robust approac
...

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#issuecomment-1837840851)
Added this to the tracking issue

💬 maflcko commented on pull request "util/blockstorage: Add `TRACE_RAII`, slightly faster -reindex-chainstate with CBufferedFile":
(https://github.com/bitcoin/bitcoin/pull/28226#issuecomment-1837969022)
I tried to remove BufferedFile, but it seemed non-trivial. I think it is needed to recover from datadir corruption caused by previous releases of Bitcoin Core. I wonder how relevant this still is, and whether it is simpler to require those affected to re-do an IBD. Another small benefit would be that the fuzz timeout in `load_external_block_file` would likely be fixed, see https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1807801984. (Attempting to read a block at every byte position
...

💬 maflcko commented on pull request "test: Fix test by checking the actual exception instance":
(https://github.com/bitcoin/bitcoin/pull/28989#issuecomment-1837981733)
lgtm ACK 55e3dc3e03510e97caba1547a82e3e022b0bbd42

📝 maflcko opened a pull request: "ci: Use Ubuntu 24.04 Noble for tsan,tidy,fuzz"
(https://github.com/bitcoin/bitcoin/pull/28992)
23.10 will be EOL mid next year, so a bump is needed before then for the `master` branch (and possibly the `26.x` branch).

Doing the bump now is fine, because the clang version is pinned to 17 inside the CI tasks. So a default clang version change in the system image should not affect the tasks. Once clang-18 is available and the default in April next year (https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649#planned-and-potentially-disruptive-archive-wide-activities-2), the pin
...

💬 naumenkogs commented on pull request "p2p: Fill reconciliation sets (Erlay)":
(https://github.com/bitcoin/bitcoin/pull/28765#issuecomment-1838126153)
Addressed all comments. Ready for review.

💬 maflcko commented on issue "p2p_filter intermittent failure (assert not filter_peer.tx_received)":
(https://github.com/bitcoin/bitcoin/issues/25128#issuecomment-1838244265)
Locally: https://drahtbot.space/temp_scratch/p2p_filter_2.tar.xz

💬 fanquake commented on issue "getrawtransaction xxxxxx.... 2 causes a segfault":
(https://github.com/bitcoin/bitcoin/issues/28986#issuecomment-1838271681)
> configurations commands for the build shown above are incorrect, should be....

Note that you are passing options to configure that will have no effect.
`--enable-glibc-back-compat` no-longer exists, and will do nothing.
`--enable-cxx` is not one of our configure options, so will also do nothing (might have been copy-pasted from a BDB configure?).
I would suggest switching `--prefix=xxx` for `CONFIG_SITE=xxx ./configure your-other-options`.

> CPPFLAGS="-fPIC -O2 --param ggc-min-expand=
...

💬 maflcko commented on issue "p2p_filter intermittent failure (assert not filter_peer.tx_received)":
(https://github.com/bitcoin/bitcoin/issues/25128#issuecomment-1838273450)
> However, from the log it looks like the p2p_lock was intermittently released in the on_message function??
>
> ```
> test 2022-12-30T09:33:48.464000Z TestFramework (INFO): Check that request for filtered blocks is ignored if no filter is set
> test 2022-12-30T09:33:48.288000Z TestFramework.p2p (DEBUG): Received message from 127.0.0.1:12488: msg_tx(tx=CTransaction(nVersion=2 vin=[CTxIn(prevout=COutPoint(hash=17576cfafe2ea026d9ab00f6082fe7cc81caf31f5060a1872693f5bf73bf6b11 n=0) scriptSi
...

🚀 fanquake merged a pull request: "[26.0] Finalize or rc4"
(https://github.com/bitcoin/bitcoin/pull/28959)