💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1410653204)
> Instead, I'd suggest that we not bother enforcing the v3 rules on a reorg.

I'm a fan of this approach. I want to spend a little bit of time thinking about what the possibilities are - I guess we can have some incorrect assumptions about transactions (resulting in e.g. incorect MinerScores) but it wouldn't be problematic if a reorg is the only way to get there, as you say.

💬 sipa commented on pull request "refactor: Remove unused SER_DISK, SER_NETWORK, CDataStream":
(https://github.com/bitcoin/bitcoin/pull/28451#issuecomment-1833766618)
utACK fa98a097a30bc39f2424c0efd28a7979155faae6

💬 brunoerg commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1833771857)
> The "Reproducer Testcase" should be public.

"Access denied" when I try to access it.

🤔 furszy reviewed a pull request: "test: add coverage for bech32m in `wallet_keypool_topup`"
(https://github.com/bitcoin/bitcoin/pull/28928#pullrequestreview-1757470863)
how much faster the test got? Some numbers would encourage more reviewers to come here.

📝 maflcko opened a pull request: "test: Add and use option for tx-version in MiniWallet methods"
(https://github.com/bitcoin/bitcoin/pull/28972)
Fixes https://github.com/bitcoin/bitcoin/pull/26657#discussion_r1071362636 by adding a `version` keyword-argument to `create_self_transfer_multi`, and by passing it via `kwargs` from all other methods.

💬 maflcko commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1833845779)
Ok, I see. I guess google requires login now, starting at some point in the past.

💬 instagibbs commented on pull request "bugfix, Change up submitpackage results to return results for all transactions":
(https://github.com/bitcoin/bitcoin/pull/28848#issuecomment-1833887261)
ping @Sjors @darosior @glozow should be ready for re-acks

💬 ajtowns commented on pull request "refactor: Remove unused SER_DISK, SER_NETWORK, CDataStream":
(https://github.com/bitcoin/bitcoin/pull/28451#issuecomment-1833929465)
ACK fa98a097a30bc39f2424c0efd28a7979155faae6

💬 Sjors commented on pull request "[WIP] add a stratum v2 template provider":
(https://github.com/bitcoin/bitcoin/pull/27854#issuecomment-1833934826)
I have a rebased and reorganised branch in progress that I'll link to here in a bit.

@ccdle12 are you still working on this? If not, I could take over and open a new PR. Otherwise, you could check if my branch is useful and use it here.

💬 instagibbs commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1410793961)
good news: this issue was discovered in less than a minute on a single core with the package fuzzer

🚀 fanquake merged a pull request: "guix: switch from `guix environment` to `guix shell`"
(https://github.com/bitcoin/bitcoin/pull/26077)

🚀 fanquake merged a pull request: "ci: Reduce use of bash -c"
(https://github.com/bitcoin/bitcoin/pull/28954)

🚀 fanquake merged a pull request: "fuzz: BIP324: damage ciphertext/aad in full byte range"
(https://github.com/bitcoin/bitcoin/pull/28951)

👍 fanquake approved a pull request: "msvc: Update vcpkg manifest"
(https://github.com/bitcoin/bitcoin/pull/28938#pullrequestreview-1757694045)
ACK 6d05c4fd138b80168d14a8cf1dbcca43782851af

🚀 fanquake merged a pull request: "msvc: Update vcpkg manifest"
(https://github.com/bitcoin/bitcoin/pull/28938)

💬 sdaftuar commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1410816950)
I just think that the point of the policy rule is not to enforce a particular sigops limit, but instead to ensure that the total fee required to replace a child transaction is only high if the child itself has a high feerate, which is defined as `fee / sigops_adjusted_vsize`. So there doesn't seem to me to be a benefit to thinking about two different limits.

🚀 fanquake merged a pull request: "guix: remove input labels"
(https://github.com/bitcoin/bitcoin/pull/28965)

💬 fanquake commented on pull request "depends: fix libmultiprocess build on aarch64":
(https://github.com/bitcoin/bitcoin/pull/28846#discussion_r1410822923)
> Is this workaround still needed with

I think this can be deffered for #28856. I haven't tested everything, but with that change, we seem to avoid the issues here. I'll close this for now in favour of that change, and properly review shortly.

✅ fanquake closed a pull request: "depends: fix libmultiprocess build on aarch64"
(https://github.com/bitcoin/bitcoin/pull/28846)

💬 fanquake commented on pull request "depends: Build the `native_capnp` and `capnp` packages with CMake":
(https://github.com/bitcoin/bitcoin/pull/28856#issuecomment-1833975742)
Concept ACK - I think this will now also fix #26943, and the build failure coming from the lib vs lib64 discrepency.