📝 pablomartin4btc reopened a pull request: "doc: update broken str util reference links on developer-notes"
(https://github.com/bitcoin/bitcoin/pull/27220)
References to `utilstrencodings` and `lint-locale-dependence.sh` where incorrect, updating them accordingly.

Also, adding another reference to util function [`LocaleIndependentAtoi`](https://github.com/bitcoin/bitcoin/blob/master/src/util/strencodings.h#L108-L118), which is related with the updated section of the guide:

```
// LocaleIndependentAtoi is provided for backwards compatibility reasons.
//
// New code should use ToIntegral or the ParseInt* functions
// which provide parse err
...

✅ pablomartin4btc closed a pull request: "doc: update broken str util reference links on developer-notes"
(https://github.com/bitcoin/bitcoin/pull/27220)

💬 fanquake commented on pull request "test: Use self.wait_until over wait_until_helper":
(https://github.com/bitcoin/bitcoin/pull/27226#issuecomment-1460862661)
I'm no-longer seeing #27208 with this change: `p2p_ibd_stalling.py | ✓ Passed | 951 s`.

📝 pablomartin4btc reopened a pull request: "doc: update broken str util reference links on developer-notes"
(https://github.com/bitcoin/bitcoin/pull/27220)
References to `utilstrencodings` and `lint-locale-dependence.sh` where incorrect, updating them accordingly.

Also, adding another reference to util function [`LocaleIndependentAtoi`](https://github.com/bitcoin/bitcoin/blob/master/src/util/strencodings.h#L108-L118), which is related with the updated section of the guide:

```
// LocaleIndependentAtoi is provided for backwards compatibility reasons.
//
// New code should use ToIntegral or the ParseInt* functions
// which provide parse err
...

⚠️ fanquake opened an issue: "Issue with `wallet_importdescriptors.py --descriptors` under valgrind"
(https://github.com/bitcoin/bitcoin/issues/27229)
This was running #27226 rebased on master (at the time 8d12127a9c19cb218d661a88ab9b6871c9d853b9).
```bash
256/256 - wallet_importdescriptors.py --descriptors failed, Duration: 3065 s

stdout:
2023-03-08T19:51:27.647000Z TestFramework (INFO): PRNG seed is: 266766692547859291
2023-03-08T19:51:27.648000Z TestFramework (INFO): Initializing test directory /home/ubuntu/ci_scratch/ci/scratch/test_runner/test_runner_₿_🏃_20230308_165259/wallet_importdescriptors_86
2023-03-08T19:51:44.422000Z Te
...

💬 pablomartin4btc commented on pull request "doc: update broken str util reference links on developer-notes":
(https://github.com/bitcoin/bitcoin/pull/27220#discussion_r1130023648)
ok

💬 pablomartin4btc commented on pull request "doc: update broken str util reference links on developer-notes":
(https://github.com/bitcoin/bitcoin/pull/27220#discussion_r1130024468)
updated it.

💬 MarcoFalke commented on issue "Issue with `wallet_importdescriptors.py --descriptors` under valgrind":
(https://github.com/bitcoin/bitcoin/issues/27229#issuecomment-1460877892)
Looks like node0 exits the http thread, but forgets to actually shut down?

```
node0 2023-03-08T20:02:32.703470Z [http] [httpserver.cpp:307] [ThreadHTTP] [http] Exited http event loop
node0 2023-03-08T20:06:42.411033Z [scheduler] [net.cpp:1532] [DumpAddresses] [net] Flushed 0 addresses to peers.dat 14ms
node0 2023-03-08T20:21:42.423331Z [scheduler] [net.cpp:1532] [DumpAddresses] [net] Flushed 0 addresses to peers.dat 10ms
node0 2023-03-08T20:36:42.434867Z [scheduler] [net.cpp:153
...

💬 MarcoFalke commented on issue ""error reading from database. shutting down"":
(https://github.com/bitcoin/bitcoin/issues/22426#issuecomment-1460887481)
We get a few data corruption reports regularly, however, no developer could reproduce them yet. So fixing them is hard and for debugging one can only throw blind guesses.

My next guess would be to check if Anti-Virus Software was involved.

If you can reliably reproduce this, it can help us if you shared the steps. Though, your Windows installation might largely differ from a fresh install of Windows. So if you can reproduce on a fresh install of Windows, that'd be ideal for finding the bug
...

💬 mzumsande commented on pull request "gui: use the stored CSubNet entry when unbanning":
(https://github.com/bitcoin-core/gui/pull/717#discussion_r1130039145)
Not a major issue, but this looks like it's designed to supports unbanning multiple nodes with one click, but the GUI doesn't allow me to select multiple entries when I try (unlike in the peertable where banning multiple nodes with once click works).

💬 mzumsande commented on pull request "gui: use the stored CSubNet entry when unbanning":
(https://github.com/bitcoin-core/gui/pull/717#discussion_r1130020981)
If this comment is fixed anyway (it was copied from `peertablemodel.h`), could also replace "getpeerinfo" with "listbanned".

💬 ryanofsky commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1130015697)
In commit "Decouple RegTestChainParams from ArgsManager" (66b17894185e0cda3ea7cbec77cc771a7ba41d56)

Probably better to merge the option instead of overwriting it:

```c++
if (auto value = args.GetBoolArg("-fastprune")) options.fastprune = *value;
```

This would avoid needing to hardcode the default `false` value here, and would be more more consistent with `version_bits_parameters` and `activation_heights` handling below which keep preexisting values if arguments are unset.

Alternat
...

💬 ryanofsky commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1130052484)
re: https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1126829031

> Thanks, updated. [Diff](https://github.com/TheCharlatan/bitcoin/compare/tc/2022-09-libbitcoinkernel-chainparams-args_1..tc/2022-09-libbitcoinkernel-chainparams-args_2)

This looks the same as before. I was suggesting dropping the `chainparams_ptr` variable and just writing `*chainparams` directly below.

💬 ryanofsky commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1130039156)
In commit "split non/kernel chainparamsbase" (341be7fa680e9dcdbaa46db0194833b5d0229394)

I still don't think it makes sense to have `CBaseChainParams` in the kernel. Like the comment above says, the point of the `CBaseChainParams` class and the reason it is separate from `CChainParams` is that it is shared between bitcoin-cli and bitcoind. I think of `CBaseChainParams` as client parameters, and `CChainParams` as server parameters. Practically speaking, `bitcoin-cli` or other clients that needs
...

💬 pablomartin4btc commented on pull request "cli: add validation to cli side commands besides when it's used with -rpcwallet":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1130071627)
done

💬 pablomartin4btc commented on pull request "cli: add validation to cli side commands besides when it's used with -rpcwallet":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1130071906)
done

💬 pablomartin4btc commented on pull request "cli: add validation to cli side commands besides when it's used with -rpcwallet":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1130104615)
On this one, when I raise the error or when I have to pass the strings for the insertion into the chain, it doesn't look right to pass twice the same variable (e.g.: `INVALID_CLI_COMMAND_ARGUMENT.format(rpcwallet3, rpcwallet3, "-generate"`).

Would you accept:

`INVALID_CLI_COMMAND_ARGUMENT = 'Error: invalid cli-command argument. If \"{}\" is a valid option try passing it before the \"{}\" command.'`

💬 pablomartin4btc commented on pull request "cli: add validation to cli side commands besides when it's used with -rpcwallet":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1130114475)
fixed

💬 achow101 commented on pull request "Switch hardened derivation marker to h (in normalized descriptors and new wallets)":
(https://github.com/bitcoin/bitcoin/pull/26076#issuecomment-1460962371)
reACK 4677f1923c9509025de0e77892638d5013f044bf

📝 sipa opened a pull request: "Update src/secp256k1 subtree to upstream release v0.3.0"
(https://github.com/bitcoin/bitcoin/pull/27230)
This updates the libsecp256k1 subtree to v0.3.0. I don't believe there are code changes that are particularly important to Bitcoin Core, apart from the added CMake build system support.