Bitcoin Core Github
44 subscribers
121K links
Download Telegram
💬 pinheadmz commented on issue "OS-specific background service for bitcoind":
(https://github.com/bitcoin/bitcoin/issues/9005#issuecomment-1460657175)
Was this solved by https://github.com/bitcoin/bitcoin/pull/21007 ? I think that PR removed `daemon()` from the codebase. I run macOS 12.3.1 and don't have any issues running with `bitcoind -daemon`
💬 MarcoFalke commented on issue "OS-specific background service for bitcoind":
(https://github.com/bitcoin/bitcoin/issues/9005#issuecomment-1460702016)
Closing for now. Can be reopened if this is still an issue.
MarcoFalke closed an issue: "OS-specific background service for bitcoind"
(https://github.com/bitcoin/bitcoin/issues/9005)
💬 MarcoFalke commented on issue ""error reading from database. shutting down"":
(https://github.com/bitcoin/bitcoin/issues/22426#issuecomment-1460703843)
Is this an external hard drive? Otherwise:

Bitcoin Core makes heavy use of CPU, RAM and disk IO. Hardware defects might only become visible when running Bitcoin Core. You might want to check your hardware for defects.

* memtest86 to check your RAM
* to check the CPU behaviour under load, use linpack or Prime95
* to test your storage device use smartctl or CrystalDiskInfo

Source: https://bitcoin.stackexchange.com/a/12206
💬 Ayms commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1460704159)
Cool, I am a bit like @ChristopherA probably , even if still operating a bitcoin node that I did compile myself (+ some slight modifications for testing), I did not work on it since years
💬 pinheadmz commented on issue "Many sendcmpct messages are sent during UpdateActiveChain()":
(https://github.com/bitcoin/bitcoin/issues/21903#issuecomment-1460734624)
> IsIBD() should be changed to return true while the Tip is still far behind the best known header

`IsInitialBlockDownload()` also checks if the timestamp in the tip is less than 24 hours old (`DEFAULT_MAX_TIP_AGE`) which I think means that at most we're probably only sending around 144 `sendcmpct` before we really need to.

I used `invalidateblock`/`reconsiderblock` to re-enter IBD and re-download the last 1000 blocks with net logging, and the only `sendcmpct` messages I saw go out were to
...
💬 pinheadmz commented on issue "Doc: Consolidate documentation of functional test parameters.":
(https://github.com/bitcoin/bitcoin/issues/17380#issuecomment-1460742502)
> Hi @jachiang, I have a few test runner improvement PRs written last July that I was thinking of opening at some point

@jonatack did this happen? ;-)
💬 ntherrien commented on issue ""error reading from database. shutting down"":
(https://github.com/bitcoin/bitcoin/issues/22426#issuecomment-1460751900)
Hi, thanks for looking into this over-a-year-old issue.

About the hardware defects suggestion, I remember trying it on two different computers and had the same issue. Likelihood of a hardware issue is very low in my opinion because im still using both computers a year later with other intensive tasks.

As for whether or not this would still be an issue in a newer version, I could not say because I abandoned that project because I could not get it running properly. I would have to try again
...
💬 pinheadmz commented on issue "Mac OS latest Bitcoin core latest release will not run as Mac OS, "you can't open the application 'Bitcoin core'"":
(https://github.com/bitcoin/bitcoin/issues/25834#issuecomment-1460754246)
I think this is essentially a duplicate of https://github.com/bitcoin/bitcoin/issues/15774
💬 jonatack commented on issue "Doc: Consolidate documentation of functional test parameters.":
(https://github.com/bitcoin/bitcoin/issues/17380#issuecomment-1460765343)
> @jonatack did this happen? ;-)

No, they are still in my local git. I don't propose most of the things I write to not have dozens of open unmerged PRs. It's hard to assess which ones to open, though :)
💬 jessebarton commented on pull request "doc: FreeBSD DataDirectoryGroupReadable Setting":
(https://github.com/bitcoin/bitcoin/pull/26741#issuecomment-1460812766)
The Tor project has this set (Default: 0) freebsd takes the same Default. Makes sense to me to follow what the Tor docs show rather than each individual project.
💬 ryanofsky commented on pull request "refactor: Remove CAddressBookData::destdata":
(https://github.com/bitcoin/bitcoin/pull/27224#discussion_r1129950744)
re: https://github.com/bitcoin/bitcoin/pull/27224#discussion_r1129250725

Thanks, fixed now
pablomartin4btc closed a pull request: "doc: update broken str util reference links on developer-notes"
(https://github.com/bitcoin/bitcoin/pull/27220)
📝 pablomartin4btc reopened a pull request: "doc: update broken str util reference links on developer-notes"
(https://github.com/bitcoin/bitcoin/pull/27220)
References to `utilstrencodings` and `lint-locale-dependence.sh` where incorrect, updating them accordingly.

Also, adding another reference to util function [`LocaleIndependentAtoi`](https://github.com/bitcoin/bitcoin/blob/master/src/util/strencodings.h#L108-L118), which is related with the updated section of the guide:

```
// LocaleIndependentAtoi is provided for backwards compatibility reasons.
//
// New code should use ToIntegral or the ParseInt* functions
// which provide parse err
...
pablomartin4btc closed a pull request: "doc: update broken str util reference links on developer-notes"
(https://github.com/bitcoin/bitcoin/pull/27220)
💬 fanquake commented on pull request "test: Use self.wait_until over wait_until_helper":
(https://github.com/bitcoin/bitcoin/pull/27226#issuecomment-1460862661)
I'm no-longer seeing #27208 with this change: `p2p_ibd_stalling.py | ✓ Passed | 951 s`.
📝 pablomartin4btc reopened a pull request: "doc: update broken str util reference links on developer-notes"
(https://github.com/bitcoin/bitcoin/pull/27220)
References to `utilstrencodings` and `lint-locale-dependence.sh` where incorrect, updating them accordingly.

Also, adding another reference to util function [`LocaleIndependentAtoi`](https://github.com/bitcoin/bitcoin/blob/master/src/util/strencodings.h#L108-L118), which is related with the updated section of the guide:

```
// LocaleIndependentAtoi is provided for backwards compatibility reasons.
//
// New code should use ToIntegral or the ParseInt* functions
// which provide parse err
...
⚠️ fanquake opened an issue: "Issue with `wallet_importdescriptors.py --descriptors` under valgrind"
(https://github.com/bitcoin/bitcoin/issues/27229)
This was running #27226 rebased on master (at the time 8d12127a9c19cb218d661a88ab9b6871c9d853b9).
```bash
256/256 - wallet_importdescriptors.py --descriptors failed, Duration: 3065 s

stdout:
2023-03-08T19:51:27.647000Z TestFramework (INFO): PRNG seed is: 266766692547859291
2023-03-08T19:51:27.648000Z TestFramework (INFO): Initializing test directory /home/ubuntu/ci_scratch/ci/scratch/test_runner/test_runner_₿_🏃_20230308_165259/wallet_importdescriptors_86
2023-03-08T19:51:44.422000Z Te
...
💬 pablomartin4btc commented on pull request "doc: update broken str util reference links on developer-notes":
(https://github.com/bitcoin/bitcoin/pull/27220#discussion_r1130023648)
ok
💬 pablomartin4btc commented on pull request "doc: update broken str util reference links on developer-notes":
(https://github.com/bitcoin/bitcoin/pull/27220#discussion_r1130024468)
updated it.