📝 fanquake opened a pull request: "doc: remove mingw-w64 install for "older" systems"
(https://github.com/bitcoin/bitcoin/pull/28900)
Now that we require GCC 10.1+, the posix variant is available on supported systems.

i.e:
https://packages.debian.org/bullseye/g++-mingw-w64-x86-64-posix
https://packages.ubuntu.com/jammy/g++-mingw-w64-x86-64-posix

⚠️ fanquake opened an issue: "ci: failure in Windows MSVC build"
(https://github.com/bitcoin/bitcoin/issues/28901)
https://github.com/bitcoin/bitcoin/actions/runs/6902633477/job/18779735457#step:20:2859:
```bash
LINK : fatal error C1900: Il mismatch between 'P1' version '20230904' and 'P2' version '20221215' [D:\a\bitcoin\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\a\bitcoin\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
LINK : fatal error LNK1327: failure during running link.exe [D:\a\bitcoin\bitcoin\build_msvc\test_bitcoin\test_bi
...

💬 maflcko commented on pull request "doc: remove mingw-w64 install for "older" systems":
(https://github.com/bitcoin/bitcoin/pull/28900#issuecomment-1816172539)
ACK 656a7e9de626ea76f377c7e1e3370a869d7bcca9

🤔 BrandonOdiwuor reviewed a pull request: "Update Node window title with the chain type"
(https://github.com/bitcoin-core/gui/pull/758#pullrequestreview-1736655591)
Is this a platform specific issue?

This currently how my GUI behaves on `master` branch. [Platform: Ubuntu: 22]
![Screenshot from 2023-11-17 14-01-40](https://github.com/bitcoin-core/gui/assets/15610188/6de3d3e9-0a71-4228-8ef4-aec1d144
...

💬 hebasto commented on issue "ci: failure in Windows MSVC build":
(https://github.com/bitcoin/bitcoin/issues/28901#issuecomment-1816190278)
I'll look into it.

🚀 fanquake merged a pull request: "test: refactor: use built-in collection types for type hints (Python 3.9 / PEP 585)"
(https://github.com/bitcoin/bitcoin/pull/28725)

💬 hebasto commented on issue "ci: failure in Windows MSVC build":
(https://github.com/bitcoin/bitcoin/issues/28901#issuecomment-1816227964)
The new windows-2022 image version 20231115.2.0 is being rolling out by GHA at the moment. However, in the [release notes](https://github.com/actions/runner-images/releases/tag/win22%2F20231115.2), I did not spot any breaking changes for now. Keep investigating further.

📝 maflcko opened a pull request: "doc: Simplify guix install doc, after 1.4 release"
(https://github.com/bitcoin/bitcoin/pull/28902)
Now that 1.4 is out (for a while), remove the recommendation to build a random commit.

👍 BrandonOdiwuor approved a pull request: "doc: remove mingw-w64 install for "older" systems"
(https://github.com/bitcoin/bitcoin/pull/28900#pullrequestreview-1736742985)
ACK 656a7e9de626ea76f377c7e1e3370a869d7bcca9

👍 fanquake approved a pull request: "doc: Simplify guix install doc, after 1.4 release"
(https://github.com/bitcoin/bitcoin/pull/28902#pullrequestreview-1736746203)
ACK fa552e8a4e4fc61b01eb36387bdf86b27c6893c3

💬 pinheadmz commented on issue "v26.0 Testing":
(https://github.com/bitcoin/bitcoin/issues/28718#issuecomment-1816281195)
So, I got an OOM on a Raspberry Pi as well, syncing 26.0rc2 from genesis. My Pi actually has 8 GB RAM. I have been running 25.0 on this same device ever since its release but I did not have to sync from genesis because I was just upgrading.

System (Raspberry Pi 4 Model B Rev 1.5)

```
$ uname -a
Linux zippi 5.10.103-v8+ #1529 SMP PREEMPT Tue Mar 8 12:26:46 GMT 2022 aarch64 GNU/Linux

$ free -m
total used free shared buff/cache available
Mem:
...

👍 hebasto approved a pull request: "doc: remove mingw-w64 install for "older" systems"
(https://github.com/bitcoin/bitcoin/pull/28900#pullrequestreview-1736860397)
ACK 656a7e9de626ea76f377c7e1e3370a869d7bcca9.

In the following code:https://github.com/bitcoin/bitcoin/blob/98b0acda0f00df3f62a61646d323c8367ddebd68/depends/hosts/mingw32.mk#L1-L3
a condition might be removed as well.

💬 brunoerg commented on pull request "p2p: Allow whitelisting outgoing connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1397230333)
Fair enough, gonna add comments.

💬 brunoerg commented on pull request "p2p: Allow whitelisting outgoing connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1397234085)
I don't think it's unused because you can specify `-whitelist=noban,in@ipaddr -whitelist=mempool,out@sameipaddr`.

👍 hebasto approved a pull request: "doc: Simplify guix install doc, after 1.4 release"
(https://github.com/bitcoin/bitcoin/pull/28902#pullrequestreview-1736886533)
ACK fa552e8a4e4fc61b01eb36387bdf86b27c6893c3.

💬 brunoerg commented on pull request "p2p: Allow whitelisting outgoing connections":
(https://github.com/bitcoin/bitcoin/pull/27114#issuecomment-1816366750)
Rebased

💬 maflcko commented on issue "ci: failure in Windows MSVC build":
(https://github.com/bitcoin/bitcoin/issues/28901#issuecomment-1816412924)
Is this still an issue?

💬 hebasto commented on issue "ci: failure in Windows MSVC build":
(https://github.com/bitcoin/bitcoin/issues/28901#issuecomment-1816414989)
> Is this still an issue?

Yes. Testing a fix at the moment.

💬 maflcko commented on issue "ci: failure in Windows MSVC build":
(https://github.com/bitcoin/bitcoin/issues/28901#issuecomment-1816421127)
Ok, I was asking because the latest build passed: https://github.com/bitcoin/bitcoin/actions/runs/6903309087/job/18781736984 So I guess GitHub only pushes out the new image to some tasks?

👍 vasild approved a pull request: "p2p: do not make automatic outbound connections to addnode peers"
(https://github.com/bitcoin/bitcoin/pull/28895#pullrequestreview-1737007109)
ACK 5e7cc4144bb09cfde48ba5bc055a2da3ca4252d1