✅ fanquake closed a pull request: "Update .cirrus.yml"
(https://github.com/bitcoin/bitcoin/pull/28889)

✅ fanquake closed a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/28888)

📝 fanquake locked a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/28888)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 fanquake locked a pull request: "Update .cirrus.yml"
(https://github.com/bitcoin/bitcoin/pull/28889)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 fanquake commented on pull request "doc: fixup help output for -upnp and -natpmp":
(https://github.com/bitcoin/bitcoin/pull/28874#discussion_r1395402441)
> if DEFAULT_UPNP flips to true.

I very much doubt we would ever return to shipping upnp/natpmp on by default.

🚀 fanquake merged a pull request: "contrib: use a raw string for a regular expression literal that contains backslashes in signet/miner"
(https://github.com/bitcoin/bitcoin/pull/28883)

📝 maflcko opened a pull request: "rpc: Remove deprecated -rpcserialversion"
(https://github.com/bitcoin/bitcoin/pull/28890)
The flag is problematic for many reasons:

* It is deprecated
* It is a global flag, requiring a restart to change, as opposed to a flag that can be set on each RPC invocation
* It may be hidden in config files by accident, hard to debug, causing LND crashes and bugs, see https://github.com/bitcoin/bitcoin/issues/28730#issuecomment-1780940868
* It makes performance improvements harder to implement: https://github.com/bitcoin/bitcoin/pull/17529#issuecomment-556082818

Fix all issues by rem
...

🚀 fanquake merged a pull request: "doc: remove mention of missing bdb being a configure error"
(https://github.com/bitcoin/bitcoin/pull/28881)

🚀 fanquake merged a pull request: "doc: remove x86_64 build assumption from depends doc"
(https://github.com/bitcoin/bitcoin/pull/28884)

🚀 fanquake merged a pull request: "bench: Update nanobench to 4.3.11"
(https://github.com/bitcoin/bitcoin/pull/28877)

💬 vasild commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#issuecomment-1814117821)
`2386ef0a54...0858b0c084`: remove duplicate `#include <sync.h>`

💬 hf5pro commented on pull request "policy: Enable full-rbf by default":
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-1814119792)
> The problem that RBF is trying to solve could simply be solved by increasing the acceptable blockweight.

Folks over at BSV are testing big blocks, may want take a look ;)
https://github.com/bitcoin-sv/bitcoin-sv

👍 fanquake approved a pull request: "tests: Fix LCOV_OPTS to be in the correct position"
(https://github.com/bitcoin/bitcoin/pull/28771#pullrequestreview-1734005073)
ACK 88e09ac2a15d674db9e814755602572be61241ff

> I mostly wonder why it was working fine previously, when it shouldn't.

It looks like when `LCOV_OPTS` is set, during branch coverage, and we end up with something like `lcov -a --rc lcov_branch_coverage=1 baseline_filtered.info`, lcov just reads pass the extra arguments, and still uses the file, i.e:
```bash
touch some_file
lcov -a --rc lcov_branch_coverage=1 some_file
Combining tracefiles.
.. found 1 files to aggregate.
Merging some_fi
...

🚀 fanquake merged a pull request: "fuzz: Minor improvements to tx_package_eval target"
(https://github.com/bitcoin/bitcoin/pull/28825)

🚀 fanquake merged a pull request: "depends: remove `PYTHONPATH` from config.site"
(https://github.com/bitcoin/bitcoin/pull/28845)

🚀 fanquake merged a pull request: "tests: Fix LCOV_OPTS to be in the correct position"
(https://github.com/bitcoin/bitcoin/pull/28771)

💬 fanquake commented on pull request "test: refactor: use built-in collection types for type hints (Python 3.9 / PEP 585)":
(https://github.com/bitcoin/bitcoin/pull/28725#issuecomment-1814165459)
Concept ACK

💬 maflcko commented on pull request "tests: Fix LCOV_OPTS to be in the correct position":
(https://github.com/bitcoin/bitcoin/pull/28771#issuecomment-1814170922)
Thanks for taking a look. The `--rc` seems wrong as well? Previously it was ignored, but now I wonder why it doesn't lead to errors, because, according to the manpage:

```
Only one of -z, -c, -a, -e, -r, -l and --diff may be specified at a time.

💬 fanquake commented on pull request "Fix typos":
(https://github.com/bitcoin/bitcoin/pull/28605#issuecomment-1814183016)
There are even more since this was last updated, but going to merge this now, and we can follow up again later.

🚀 fanquake merged a pull request: "Fix typos"
(https://github.com/bitcoin/bitcoin/pull/28605)