💬 maflcko commented on issue "Verfication of provided pruned database":
(https://github.com/bitcoin/bitcoin/issues/28887#issuecomment-1813998365)
Ok, closing for now. Let us know if you have any other questions.

Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base. General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat.

✅ maflcko closed an issue: "Verfication of provided pruned database"
(https://github.com/bitcoin/bitcoin/issues/28887)

🤔 S3RK reviewed a pull request: "wallet: Have the wallet store the key for automatically generated descriptors"
(https://github.com/bitcoin/bitcoin/pull/26728#pullrequestreview-1726760385)
I finished going through all commits one-by-one. Need a bit more time to check comprehensively how HD flag is set at creation/migration/upgrade and redo my manual tests.

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1390757392)
in 18dc28f14ee1de561625913d286d68031ab9b3dd

nit: it could've been just `std:map<keyid, key>` since `desc_id` is not used

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1395327696)
in e3c292b298e5e6f2ec319fb93ba67fd64a0f4ac1

if `key_hex not in k` then `ckey_hex not in k` is always true by definition
Therefore `key_hex not in k and ckey_hex not in k` seems redundant to me.

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1390758254)
in 18dc28f14ee1de561625913d286d68031ab9b3dd

nit: it could've been just `std::map<keyid, ckey>` since `desc_id` and `pubkey` are not used

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1392138071)
@achow101 IIUC you addressed this as well

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1395310367)
in 2657c1295cb156d6021844edf18b1a4dc5ce7136

nit: can also check that HD key is the same as return by the old version (e.g. by checking fingerprint with `hdmasterfingerprint`)

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1390768618)
in 52697ecc3fd46fdf3c02eba0d474949a9d05d885

nit: can test that `gethdkey(False)` succeeds on encrypted and locked wallet

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1390770187)
in 52697ecc3fd46fdf3c02eba0d474949a9d05d885

nit: maybe add a comment, that you're checking key rotation and non-active descriptors should have pre-rotation key

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1395330786)
in e3c292b298e5e6f2ec319fb93ba67fd64a0f4ac1

Relying that all encrypted keys contain `ckey` seems fragile. Can we maybe list all the encrypted key records?

📝 miz1choobi opened a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/28888)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 airdropbaaz opened a pull request: "Update .cirrus.yml"
(https://github.com/bitcoin/bitcoin/pull/28889)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ fanquake closed a pull request: "Update .cirrus.yml"
(https://github.com/bitcoin/bitcoin/pull/28889)

✅ fanquake closed a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/28888)

📝 fanquake locked a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/28888)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 fanquake locked a pull request: "Update .cirrus.yml"
(https://github.com/bitcoin/bitcoin/pull/28889)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 fanquake commented on pull request "doc: fixup help output for -upnp and -natpmp":
(https://github.com/bitcoin/bitcoin/pull/28874#discussion_r1395402441)
> if DEFAULT_UPNP flips to true.

I very much doubt we would ever return to shipping upnp/natpmp on by default.

🚀 fanquake merged a pull request: "contrib: use a raw string for a regular expression literal that contains backslashes in signet/miner"
(https://github.com/bitcoin/bitcoin/pull/28883)

📝 maflcko opened a pull request: "rpc: Remove deprecated -rpcserialversion"
(https://github.com/bitcoin/bitcoin/pull/28890)
The flag is problematic for many reasons:

* It is deprecated
* It is a global flag, requiring a restart to change, as opposed to a flag that can be set on each RPC invocation
* It may be hidden in config files by accident, hard to debug, causing LND crashes and bugs, see https://github.com/bitcoin/bitcoin/issues/28730#issuecomment-1780940868
* It makes performance improvements harder to implement: https://github.com/bitcoin/bitcoin/pull/17529#issuecomment-556082818

Fix all issues by rem
...