💬 Sjors commented on pull request "[WIP] Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r1392640692)
54f39ca8f101483f5f82707689ca49431d4091e5: So you're creating a chunk for each new transaction and then erasing it if the fee rate goes down. Why not the other way around?

✅ hebasto closed an issue: "An overflow in `TapSatisfier::FromPKHBytes`?"
(https://github.com/bitcoin/bitcoin/issues/28871)

💬 BrandonOdiwuor commented on pull request "GUI getrawtransaction implementation":
(https://github.com/bitcoin-core/gui/pull/777#issuecomment-1810358549)
> Cool, that's pretty nice!
>
> Just thinking out loud, but it does make me wonder if perhaps a new `Verify` or `Utils` button, in line with "Send | Recieve | Transactions" could be even nicer? If we added it there, we might consider adding a few more utils to the GUI like "Decode raw transaction", "Decode Script", "Get Descriptor Info", "Verify Message" etc. which folks who use the gui generally use other software for today...

@willcl-ark would love to hear more opinions on this, I also t
...

💬 willcl-ark commented on pull request "gui: getrawtransaction implementation":
(https://github.com/bitcoin-core/gui/pull/777#issuecomment-1810365085)
Yeah I don't want to derail this pr, which I think looks good on its own!

If there was desire to add more utils we could always move this later; I think this looks nice.

💬 jb55 commented on issue "macOS qt QTimer::stop crash on v26.0rc2":
(https://github.com/bitcoin/bitcoin/issues/28867#issuecomment-1810415284)
I haven't been able to reproduce it since it happened

⚠️ MarnixCroes opened an issue: "Send: ability to (re)view automatically selected coins "
(https://github.com/bitcoin-core/gui/issues/778)
### Please describe the feature you'd like to see added.

Ability to see the automatic coin selection in the GUI.

### Is your feature related to a problem, if so please describe it.

Even people who "know" how to use coin control may use the automatic coin selection with the assumption that it will select the "best" coin(s) for the tx. Especially when having many utxo's.

So user wants to use the automatic coin selection, but at the same time review the automatically selected coin(s). For exa
...

🚀 fanquake merged a pull request: "test, refactor: Magic bytes array followup"
(https://github.com/bitcoin/bitcoin/pull/28857)

✅ fanquake closed an issue: "Manpage for `-par` bolds lower bound"
(https://github.com/bitcoin/bitcoin/issues/28850)

🚀 fanquake merged a pull request: "doc: rewrite explanation for `-par=`"
(https://github.com/bitcoin/bitcoin/pull/28858)

📝 fanquake opened a pull request: "[26.x] rc3 or finalize"
(https://github.com/bitcoin/bitcoin/pull/28872)
It's not clear if an rc3 will happen, and there is currently nothing further marked for backport to 26.x. If an rc3 does happen, any additional backports can be pushed here, if it doesn't, we can pull in the release notes/make the final version changes before release.

Currently backports:
* https://github.com/bitcoin/bitcoin/pull/28858 (doesn't require an rc3)

💬 fanquake commented on pull request "wallet: Fix migration of wallets with txs that have both spendable and watchonly outputs":
(https://github.com/bitcoin/bitcoin/pull/28868#issuecomment-1810500867)
Is (some part of) this meant for backport to 26.x?

💬 fanquake commented on issue "build: Configuring with `-mno-sse4.1` does not fail the sse4.1 instrinsics check":
(https://github.com/bitcoin/bitcoin/issues/28864#issuecomment-1810503305)
Note that this ultimately results in compile failure, but because we try and compile the `sha256_x86_shani.cpp` code, but fail because it `"needs isa option -msse4.1"`:
```bash
In file included from /usr/lib/gcc/x86_64-linux-gnu/13/include/immintrin.h:39,
from crypto/sha256_x86_shani.cpp:12:
In function 'void {anonymous}::Shuffle(__m128i&, __m128i&)',
inlined from 'void sha256_x86_shani::Transform(uint32_t*, const unsigned char*, size_t)' at crypto/sha256_x86_shani.cpp:
...

👋 fanquake's pull request is ready for review: "test: migrate to some per-symbol ubsan suppressions"
(https://github.com/bitcoin/bitcoin/pull/28865)

💬 fanquake commented on pull request "test: migrate to some per-symbol ubsan suppressions":
(https://github.com/bitcoin/bitcoin/pull/28865#issuecomment-1810521898)
Pushed up a few more changes.

💬 maflcko commented on pull request "test: migrate to some per-symbol ubsan suppressions":
(https://github.com/bitcoin/bitcoin/pull/28865#issuecomment-1810538701)
lgtm ACK fd30e9688e15fe6e0f8b64202a6e9c7d96333394

💬 0xB10C commented on pull request "p2p: Increase inbound capacity for block-relay only connections":
(https://github.com/bitcoin/bitcoin/pull/28463#issuecomment-1810590275)
A few stats:

I've been running this for about a week now. I currently have 161 inbound connections: 113 (maximum) full-relay connections and 48 block-relay-only connections.


💬 0xB10C commented on pull request "p2p: Increase inbound capacity for block-relay only connections":
(https://github.com/bitcoin/bitcoin/pull/28463#issuecomment-1810591988)
In https://github.com/bitcoin/bitcoin/pull/28463#issuecomment-1716393675 you mention that:

> [we] don't want to **significantly** change the number of tx-relaying inbound peers, because we don’t want to radically change the memory and traffic requirements that come with running a full node with the default configuration.

On multiple full-inbound `master` nodes I'm getting roughly an 80%/20% full-relay/block-relay-only inbound split. This makes sense as we currently open 8 full-relay outbo
...

💬 fanquake commented on pull request "guix: update time-machine":
(https://github.com/bitcoin/bitcoin/pull/28580#issuecomment-1810592496)
The LLVM 17 that was merged into Guix is currently 17.0.3. That is fine for our usage, but I've also sent a patch upstream to try get it bumped to 17.0.5: https://lists.gnu.org/archive/html/guix-patches/2023-11/msg00964.html.

📝 maflcko opened a pull request: " fuzz: AutoFile with XOR "
(https://github.com/bitcoin/bitcoin/pull/28873)
This should help to get fuzz coverage for https://maflcko.github.io/b-c-cov/fuzz.coverage/src/streams.cpp.gcov.html

Also, remove unused code and fix a timeout bug.

💬 fanquake commented on pull request "depends: remove `PYTHONPATH` from config.site":
(https://github.com/bitcoin/bitcoin/pull/28845#issuecomment-1810625090)
I think we can drop everything. Pushed that up.