💬 glozow commented on pull request "bugfix, Change up submitpackage results to return results for all transactions":
(https://github.com/bitcoin/bitcoin/pull/28848#discussion_r1391368212)
also, why have this intermediate map? can't you do this in the loop at the end that populates `rpc_result`?

🚀 fanquake merged a pull request: "guix: update time-machine"
(https://github.com/bitcoin/bitcoin/pull/28580)

👋 fanquake's pull request is ready for review: "guix: update signapple (drop macho & altgraph)"
(https://github.com/bitcoin/bitcoin/pull/28859)

💬 glozow commented on pull request "bugfix, Change up submitpackage results to return results for all transactions":
(https://github.com/bitcoin/bitcoin/pull/28848#discussion_r1391386220)
Prefer using underscores https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1184510850

📝 ismaelsadeeq opened a pull request: "wallet: propagete `checkChainLimits` error message to wallet"
(https://github.com/bitcoin/bitcoin/pull/28863)
- Requested in [#28391 comment](https://github.com/bitcoin/bitcoin/pull/28391#discussion_r1382997719)

* The error message is static when a new transaction is created and package limit is reached.
`Transaction has too long of a mempool chain`
While the [`CTxMempool::CheckPackageLimits`](https://github.com/bitcoin/bitcoin/blob/5800c558eb5efb4839ed00d6967e43306d68e1c3/src/txmempool.cpp#L199) provide explicit information about the error message.

* This PR updates [`checkChainLimits`](https:/
...

⚠️ dergoegge opened an issue: "build: Compiling with `-mno-sse4.1` does not fail the sse4.1 instrinsics check"
(https://github.com/bitcoin/bitcoin/issues/28864)
I would have expected that `CXXFLAGS="-mno-sse4.1" ./configure` would make the sse4.1 intrinsics check fail but it doesn't:

```
configure:23377: checking for SSE4.1 intrinsics
configure:23396: clang++ -std=c++17 -c -msse4.1 -mno-sse4.1 conftest.cpp >&5
configure:23396: $? = 0
configure:23398: result: yes
```

Not sure what is going on here, seems like a bug.

💬 fanquake commented on pull request "build: Windows SSP roundup":
(https://github.com/bitcoin/bitcoin/pull/28461#discussion_r1391405285)
Pretty sure I did this so we could consolidate the gcc hardening options, doesn't need to be a blocker for this, so droppe for now.

💬 fanquake commented on pull request "guix: update signapple (drop macho & altgraph)":
(https://github.com/bitcoin/bitcoin/pull/28859#issuecomment-1808598108)
Guix Build (aarch64):
```bash
7ea71c9d553c8afaa6c1f8ba72b643783910a972faabd6712f85020dbe8dbdae guix-build-f718a74b124c/output/arm64-apple-darwin/SHA256SUMS.part
3263327cbd4ee22c21256410da377b38399d07f163a6d1c6c266aa1f9024de64 guix-build-f718a74b124c/output/arm64-apple-darwin/bitcoin-f718a74b124c-arm64-apple-darwin-unsigned.tar.gz
dc639d8aff10827c0e1a24e4edf16425cf08d443948659ecdb76bb9d2bcae90e guix-build-f718a74b124c/output/arm64-apple-darwin/bitcoin-f718a74b124c-arm64-apple-darwin-unsign
...

💬 luke-jr commented on pull request "util: Replace std::filesystem with util/fs.h":
(https://github.com/bitcoin/bitcoin/pull/28076#issuecomment-1808599588)
This remains NACK'd and should not have been merged. Please revert it ASAP.

💬 Riahiamirreza commented on pull request "rpc: show P2(W)SH redeemScript in getrawtransaction #27637":
(https://github.com/bitcoin/bitcoin/pull/27638#discussion_r1391415349)
@sipa Do you think this is a proper way of accessing the last push of the `scriptSig`? Or there are utilities in the codebase to do this for me?
```c++
while (true) {
if (txin.scriptSig.GetOp(pc, opcode, vch))
break;
}
```

💬 Ayush170-Future commented on pull request "fuzz: wallet, add target for Spend":
(https://github.com/bitcoin/bitcoin/pull/28236#discussion_r1391438669)
Yeah, this should make it more deterministic. As you said, it's causing some compilation errors with other code. I'll force-push once I've fixed them.

💬 Ayush170-Future commented on pull request "fuzz: wallet, add target for `Crypter`":
(https://github.com/bitcoin/bitcoin/pull/28074#discussion_r1391440365)
Yes, I'm on it. Will try to reproduce it once again and create an issue then.

📝 fanquake opened a pull request: "[WIP] test: migrate to some per-symbol ubsan suppressions"
(https://github.com/bitcoin/bitcoin/pull/28865)
Now that the symbolizer should be hanging around (#28814), migrate some file-wide suppressions to be symbol specific. Should assist in catching new issues that may otherwise go unnoticed due to file-wide suppression.

Only tested (so far) on aarch64 using the native ASAN & FUZZ CI.

💬 Riahiamirreza commented on pull request "rpc: show P2(W)SH redeemScript in getrawtransaction #27637":
(https://github.com/bitcoin/bitcoin/pull/27638#discussion_r1391468842)
@sipa How can I access the `CTxout` from the `COutPoint`? For a given `CTxIn` I want to reach the `scriptPubKey` of its output. The `COutPoint` only has transaction hash and index of that specific output in the `vout`. I don't know how can I reach a transaction output using `COutPoint`. Should I use `CCoinsViewDB::GetCoin`? Does it contains all the transactions? (not only mempool transactions)
```cpp
bool GetCoin(const COutPoint &outpoint, Coin &coin) const override;
```

💬 sipa commented on pull request "rpc: show P2(W)SH redeemScript in getrawtransaction #27637":
(https://github.com/bitcoin/bitcoin/pull/27638#discussion_r1391472823)
You can't use the UTXO set for this as I pointed out elsewhere. The spent UTXO is however in the undo data that's passed to TxToUniv.

💬 instagibbs commented on pull request "bugfix, Change up submitpackage results to return results for all transactions":
(https://github.com/bitcoin/bitcoin/pull/28848#discussion_r1391493778)
I think the check would be for `Txid` since different witness isn't considered a failure? added

💬 instagibbs commented on pull request "bugfix, Change up submitpackage results to return results for all transactions":
(https://github.com/bitcoin/bitcoin/pull/28848#discussion_r1391493855)
From my understanding: The current behavior in master is to re-broadcast anything in our mempool provided the txid matches something in the proposed package. If something in our mempool matches the `txid`, we (re)`BroadcastTransaction`. If it's not in our mempool, it means it was rejected, and we don't want to re-validate one by one.

I think this is the behavior we want.

💬 instagibbs commented on pull request "bugfix, Change up submitpackage results to return results for all transactions":
(https://github.com/bitcoin/bitcoin/pull/28848#discussion_r1391493917)
fixed

💬 instagibbs commented on pull request "bugfix, Change up submitpackage results to return results for all transactions":
(https://github.com/bitcoin/bitcoin/pull/28848#discussion_r1391493972)
removed the cruft

💬 instagibbs commented on pull request "bugfix, Change up submitpackage results to return results for all transactions":
(https://github.com/bitcoin/bitcoin/pull/28848#discussion_r1391494055)
done