🚀 fanquake merged a pull request: "doc: update docs for `CHECK_ATOMIC` macro"
(https://github.com/bitcoin/bitcoin/pull/28777)

📝 TheCharlatan opened a pull request: "test, refactor: Magic bytes array followup"
(https://github.com/bitcoin/bitcoin/pull/28857)
This is a followup-PR for #28423

* Initialize magic bytes in constructor
* Add a small unit test for serializing arrays.

🚀 fanquake merged a pull request: "test: Avoid intermittent failures in feature_init"
(https://github.com/bitcoin/bitcoin/pull/28831)

💬 TheCharlatan commented on pull request "refactor: Simplify CTxMempool/BlockAssembler fields, remove some external mapTx access":
(https://github.com/bitcoin/bitcoin/pull/28391#discussion_r1390901971)
Will push this if there are further things that come up.

🤔 dergoegge requested changes to a pull request: "fuzz: wallet, add target for Spend"
(https://github.com/bitcoin/bitcoin/pull/28236#pullrequestreview-1726964487)
Coverage looks decent: https://dergoegge.github.io/bitcoin-coverage/pr28236/fuzz.coverage/index.html

💬 dergoegge commented on pull request "fuzz: wallet, add target for Spend":
(https://github.com/bitcoin/bitcoin/pull/28236#discussion_r1390888668)
```suggestion
const CWallet& GetWallet()

```

It's otherwise hard to tell if the global wallet instance is mutated. Same for `GetCoins()`.

If the global instance is mutated, the target is likely to be non-deterministic which hurts fuzzer efficiency. The target should behave exactly the same when given the same input, but that might not be the case if global state is used and modified.

(The suggested change might not compile if `wallet` or `available_coins` are used as non-const/m
...

💬 maflcko commented on pull request "test, refactor: Magic bytes array followup":
(https://github.com/bitcoin/bitcoin/pull/28857#discussion_r1390907969)
```suggestion
CMessageHeader::CMessageHeader(const MessageStartChars& pchMessageStartIn, const char* pszCommand, unsigned int nMessageSizeIn)
: pchMessageStart{pchMessageStartIn}
```

nit: on the next line, according to clang-format?

👍 dergoegge approved a pull request: "fuzz: Minor improvements to tx_package_eval target"
(https://github.com/bitcoin/bitcoin/pull/28825#pullrequestreview-1726994935)
https://dergoegge.github.io/bitcoin-coverage/pr28825/fuzz.coverage/src/validation.cpp.gcov.html

Coverage looks good to me ACK 6a917918b76eef154c6757fe9ecf7713d526c3dd

💬 maflcko commented on pull request "guix: update time-machine":
(https://github.com/bitcoin/bitcoin/pull/28580#issuecomment-1807876054)
Unrelated: I've been trying to run `guix pull` on riscv64. However, it failed. Let me try again and come back with a result next week.

👍 dergoegge approved a pull request: "fuzz: call lookup functions before calling `Ban`"
(https://github.com/bitcoin/bitcoin/pull/27935#pullrequestreview-1727011437)
ACK fca0a8938e34cb4f6c400e1d1d0be02f027d80c5

💬 fanquake commented on pull request "build: LLD based macOS toolchain":
(https://github.com/bitcoin/bitcoin/pull/21778#issuecomment-1807893266)
Rebased on #28580 (LLVM 17 in Guix) and #28783, which should be the last blockers for this.

👍 maflcko approved a pull request: "fuzz: Minor improvements to tx_package_eval target"
(https://github.com/bitcoin/bitcoin/pull/28825#pullrequestreview-1727032774)
Nice

💬 maflcko commented on pull request "fuzz: Minor improvements to tx_package_eval target":
(https://github.com/bitcoin/bitcoin/pull/28825#discussion_r1390931631)
```suggestion
static const std::vector<std::vector<uint8_t>> P2WSH_EMPTY_TRUE_STACK{{uint8_t{OP_TRUE}}, {}};
static const std::vector<std::vector<uint8_t>> P2WSH_EMPTY_TWO_STACK{{uint8_t{OP_2}}, {}};
```

nit: Use the safe cast for new code, where possible, over the narrowing one.

Also, could use `EMPTY` instead of `{}`. But anything is fine here.

🚀 fanquake merged a pull request: "refactor: Simplify CTxMempool/BlockAssembler fields, remove some external mapTx access"
(https://github.com/bitcoin/bitcoin/pull/28391)

✅ fanquake closed an issue: "fuzz: banman, Assertion `banmap == banmap_read' failed"
(https://github.com/bitcoin/bitcoin/issues/27924)

🚀 fanquake merged a pull request: "fuzz: call lookup functions before calling `Ban`"
(https://github.com/bitcoin/bitcoin/pull/27935)

💬 fanquake commented on pull request "depends: Build `capnp` with CMake":
(https://github.com/bitcoin/bitcoin/pull/28856#issuecomment-1807936546)
Any reason to not change `native_capnp` at the same time?

💬 Sjors commented on pull request "test: add assumeutxo wallet test":
(https://github.com/bitcoin/bitcoin/pull/28838#discussion_r1390973314)
It's not. Replaced with a TODO comment to add wallet test for a pruned node.

💬 Sjors commented on pull request "test: add assumeutxo wallet test":
(https://github.com/bitcoin/bitcoin/pull/28838#discussion_r1390973698)
Also dropping this import since the wallet is no longer watch-only.

💬 fanquake commented on pull request "build: Patch Qt to handle minimum macOS version properly":
(https://github.com/bitcoin/bitcoin/pull/28851#issuecomment-1807988802)
Now we can actually almost do #21778, and avoid having to do this patching.