🚀 achow101 merged a pull request: "init: completely remove `-zapwallettxes` (remaining hidden option)"
(https://github.com/bitcoin/bitcoin/pull/28787)

👍 kristapsk approved a pull request: "rpc: keep `.cookie` file if it was not generated"
(https://github.com/bitcoin/bitcoin/pull/28784#pullrequestreview-1720723346)
utACK 7cb9367157eb42ee06bc6fa024522cc14a80138d

💬 pinheadmz commented on issue "whiteconnections should be re-added":
(https://github.com/bitcoin/bitcoin/issues/8798#issuecomment-1802198296)
Ping @theymos @asoltys take a look at #27600 please and leave a comment if this is still an issue that concerns you

📝 willcl-ark opened a pull request: "Use LE hex-encoded representations in script ASM for pushed values <= 4 bytes"
(https://github.com/bitcoin/bitcoin/pull/28824)
Closes: #27795
Closes: #7996

Previously `ScriptToAsmStr` returned hex-encoded integers, except if data length was <= 4 bytes, in which case it displayed using decimal encoding.

Remove the decimal encoding carve-out for small pushes and always display hex results from `decodescript` RPC.

There were [other suggestions](https://github.com/bitcoin/bitcoin/issues/27795#issuecomment-1692870456) for approaches in #27795, but IMO moving to hex-only-always makes the most sense.

💬 luke-jr commented on pull request "snapshots: don't core dump when running -checkblockindex after `loadtxoutset`":
(https://github.com/bitcoin/bitcoin/pull/28791#issuecomment-1802220054)
Maybe snapshots should include it?

💬 luke-jr commented on pull request "Embedding ASMap files as binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#issuecomment-1802223047)
Why is the option of loading it from a file even in dev builds, not considered?

💬 maflcko commented on pull request "snapshots: don't core dump when running -checkblockindex after `loadtxoutset`":
(https://github.com/bitcoin/bitcoin/pull/28791#discussion_r1386888196)
For reference, this whole assert block is likely wrong, see the thread at https://github.com/bitcoin/bitcoin/pull/28562#discussion_r1350470707

💬 maflcko commented on pull request "AssumeUTXO follow-ups":
(https://github.com/bitcoin/bitcoin/pull/28562#discussion_r1386889955)
Another report, which could replicate the crash, see #https://github.com/bitcoin/bitcoin/pull/28791

💬 luke-jr commented on pull request "contrib: Add asmap-tool":
(https://github.com/bitcoin/bitcoin/pull/28793#issuecomment-1802243288)
Concept NACK

>The motivation is that we should maintain the tooling for de- and encoding asmap files within the bitcoin core repository because it is not possible to use an asmap file that is not encoded.

That's not a reason. Ideally, the current repo should be split into several itself - but we have technical hurdles to get to that point. No reason to add more here "just because"

💬 pinheadmz commented on pull request "net: Add new permission `forceinbound` to evict a random unprotected connection if all slots are otherwise full":
(https://github.com/bitcoin/bitcoin/pull/27600#issuecomment-1802246176)
@naumenkogs If the user has *also* set a low `maxconnections` value then [`SelectNodeToEvict()`](https://github.com/bitcoin/bitcoin/blob/19d1ba1b4141f744cca291ff2d99d0b8ffcf946d/src/node/eviction.cpp#L186-L197) might return null.

Quick math 4+8+4+8+4 = 28 protected nodes. Plus 8 full outbound and 2 block only = 38. So if a user runs a full node on limited hardware (like my Raspberry Pi at home) and have something like `-maxconnections=30` then even with the existing `whitebind` permissions, t
...

🤔 luke-jr requested changes to a pull request: "rpc: Add script verification flags to getdeploymentinfo"
(https://github.com/bitcoin/bitcoin/pull/28806#pullrequestreview-1720807012)
Getting some deja vu here - is there another PR for this already?

💬 luke-jr commented on pull request "rpc: Add script verification flags to getdeploymentinfo":
(https://github.com/bitcoin/bitcoin/pull/28806#discussion_r1386914067)
Maybe number form should also be available for users of libbitcoinconsensus?

💬 luke-jr commented on pull request "rpc: Add script verification flags to getdeploymentinfo":
(https://github.com/bitcoin/bitcoin/pull/28806#discussion_r1386911888)
If we're exposing this, probably better to call it "BIP16" since p2wsh and p2tr(sometimes) are also p2sh.

💬 luke-jr commented on pull request "rpc: Add script verification flags to getdeploymentinfo":
(https://github.com/bitcoin/bitcoin/pull/28806#discussion_r1386913949)
This should not be a comma-deliminated string, but an array of strings.

💬 luke-jr commented on pull request "rpc: Add script verification flags to getdeploymentinfo":
(https://github.com/bitcoin/bitcoin/pull/28806#issuecomment-1802267067)
Ah, #10730

📝 instagibbs opened a pull request: "fuzz: Minor improvements to tx_package_eval target"
(https://github.com/bitcoin/bitcoin/pull/28825)
Exercises `DIFFERENT_WITNESS` and attempts to make invalid/duplicate inputs.

👍 hebasto approved a pull request: "ci: remove note re M1 usage"
(https://github.com/bitcoin/bitcoin/pull/28823#pullrequestreview-1720929884)
> M1 is now available in GitHub CI, but we don't currently have a plan to use it...

... for the only reason that it is not free for now. I believe, we still have a plan to use a free M1 runner in the future.

> ... so remove the comment.

Yes. It is outdated and misleading with the current wording.

ACK 8cbb6196913b22006dac75f719a2834ab0d6c94f.

💬 pinheadmz commented on pull request "net: support unix domain sockets for -proxy and -onion":
(https://github.com/bitcoin/bitcoin/pull/27375#discussion_r1386940970)
great catch thanks, will fix.

💬 pinheadmz commented on pull request "net: support unix domain sockets for -proxy and -onion":
(https://github.com/bitcoin/bitcoin/pull/27375#discussion_r1365894733)
thanks, removed

🤔 pinheadmz reviewed a pull request: "net: support unix domain sockets for -proxy and -onion"
(https://github.com/bitcoin/bitcoin/pull/27375#pullrequestreview-1688303909)
force pushed to clean up git commit history. diff is null