💬 naumenkogs commented on pull request "net: Add new permission `forceinbound` to evict a random unprotected connection if all slots are otherwise full":
(https://github.com/bitcoin/bitcoin/pull/27600#issuecomment-1801467007)
@pinheadmz Honestly I still struggle to understand what are the practical scenarios of using this. E.g., what could lead to not being able to evict a connection?

💬 naumenkogs commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1386309080)
`SyncState` yeah that would work if you come up with a good enum values.

🚀 fanquake merged a pull request: "test: Add missing sync on send_version in peer_connect"
(https://github.com/bitcoin/bitcoin/pull/28782)

🚀 fanquake merged a pull request: "tests: Increase wallet_miniscript.py rpc timeout to 90 seconds"
(https://github.com/bitcoin/bitcoin/pull/28820)

💬 maflcko commented on pull request "mempool: Persist with XOR":
(https://github.com/bitcoin/bitcoin/pull/28207#discussion_r1386333202)
Nice. Good idea. This drops a bunch of duplicate and dead code.

🚀 fanquake merged a pull request: "validation: return more helpful results for reconsiderable fee failures and skipped transactions"
(https://github.com/bitcoin/bitcoin/pull/28785)

💬 fanquake commented on pull request "build: remove `-bind_at_load` usage":
(https://github.com/bitcoin/bitcoin/pull/28783#issuecomment-1801565683)
> See https://github.com/theuni/bitcoin/commit/c61c9c5c772780be95ba7a8221ea13a72fe97d99 which is ugly but seems to work as intended.

I do hate `sed`. Pulled this is for now, but open to any other approaches if anyone has suggestions.

One other point is that last time I looked, `lld` only implemented a placeholder option for `-bind_at_load`, and I'd assume at this point, they won't bother actually implementing it, so after #21778 this flag will be even more of a no-op.

💬 maflcko commented on pull request "mempool: Persist with XOR":
(https://github.com/bitcoin/bitcoin/pull/28207#discussion_r1386407946)
The lambda is gone, so I think this is solved now.

📝 maflcko opened a pull request: "test: Add missing wait for version to be sent in add_outbound_p2p_connection"
(https://github.com/bitcoin/bitcoin/pull/28822)
Can be tested with:

```diff
diff --git a/test/functional/test_framework/p2p.py b/test/functional/test_framework/p2p.py
index b1ed97b794..eb4f72c6b6 100755
--- a/test/functional/test_framework/p2p.py
+++ b/test/functional/test_framework/p2p.py
@@ -205,6 +205,7 @@ class P2PConnection(asyncio.Protocol):
assert not self._transport
logger.debug("Connected & Listening: %s:%d" % (self.dstaddr, self.dstport))
self._transport = transport
+ import time;time.sl
...

💬 ismaelsadeeq commented on pull request "Fee Estimator updates from Validation Interface/CScheduler thread":
(https://github.com/bitcoin/bitcoin/pull/28368#discussion_r1386420330)
Done

💬 ismaelsadeeq commented on pull request "Fee Estimator updates from Validation Interface/CScheduler thread":
(https://github.com/bitcoin/bitcoin/pull/28368#discussion_r1386420913)
👍🏾 Done

💬 ismaelsadeeq commented on pull request "Fee Estimator updates from Validation Interface/CScheduler thread":
(https://github.com/bitcoin/bitcoin/pull/28368#discussion_r1386421361)
Updated, thank you

💬 ismaelsadeeq commented on pull request "Fee Estimator updates from Validation Interface/CScheduler thread":
(https://github.com/bitcoin/bitcoin/pull/28368#discussion_r1386422006)
Thanks, its now as you suggested

💬 ismaelsadeeq commented on pull request "Fee Estimator updates from Validation Interface/CScheduler thread":
(https://github.com/bitcoin/bitcoin/pull/28368#discussion_r1386422215)
Done

💬 fanquake commented on pull request "build: remove `-bind_at_load` usage":
(https://github.com/bitcoin/bitcoin/pull/28783#issuecomment-1801614766)
Guix Build (arm64):
```bash
cf3250e32cf25ee1a75372bed2fb105fc893abd40662ed60b6376cd1f77586a1 guix-build-144deffe35b7/output/arm64-apple-darwin/SHA256SUMS.part
11a505365063b6234a8e205e3b30a5a7a9bb1b1cc6bf266b5038b18474edbd1f guix-build-144deffe35b7/output/arm64-apple-darwin/bitcoin-144deffe35b7-arm64-apple-darwin-unsigned.tar.gz
674f71f6c59e064e8f42a2f11c2406fea08873b6369b472f9662e8ee0c5567e4 guix-build-144deffe35b7/output/arm64-apple-darwin/bitcoin-144deffe35b7-arm64-apple-darwin-unsigned
...

💬 ismaelsadeeq commented on pull request "mempool: Persist with XOR":
(https://github.com/bitcoin/bitcoin/pull/28207#discussion_r1386428470)
Yes resolve, will review soon ✅

💬 dergoegge commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1801622789)
Are the graphs for the entire corpus or just the slow inputs?

💬 maflcko commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1801626636)
Just the slow inputs. I can add steps to reproduce, if you want.

💬 kristapsk commented on pull request "rpc: Add script verification flags to getdeploymentinfo":
(https://github.com/bitcoin/bitcoin/pull/28806#issuecomment-1801643452)
Concept ACK

💬 dergoegge commented on pull request "fuzz: Avoid timeout and bloat in fuzz targets":
(https://github.com/bitcoin/bitcoin/pull/28815#issuecomment-1801699456)
There seems to be a pattern here, maybe it makes sense to have something like a `RepeatedCallOneOf` that does the exit on bad data internally?