💬 maflcko commented on pull request "tests: Increase wallet_miniscript.py rpc timeout to 90 seconds":
(https://github.com/bitcoin/bitcoin/pull/28820#issuecomment-1801255879)
lgtm ACK 6559e4d27ac9e8344d1211239cffab427b94bc23

💬 maflcko commented on pull request "fuzz: Avoid timeout and bloat in fuzz targets":
(https://github.com/bitcoin/bitcoin/pull/28815#issuecomment-1801265842)
> Question: What is the difference compared to #27552 ("partial" fuzzers)?

As I said on that pull request, it needs benchmarks and review on a case-by-case basis to check whether it is useful for a specific fuzz target. If someone wants to do those benchmarks on the fuzz targets touched in this pull request, and finds a positive outcome, nothing is holding anyone back from applying the concept.

The goal of this pull request is to prevent the fuzz engine from exploring invalid serialization
...

👍 ismaelsadeeq approved a pull request: "validation: return more helpful results for reconsiderable fee failures and skipped transactions"
(https://github.com/bitcoin/bitcoin/pull/28785#pullrequestreview-1719641686)
ACK 1147e00e59e47f27024ec96629993c66a3ce4ef0

looks good to me.

💬 maflcko commented on pull request "sanitizer: symbolizer improvements":
(https://github.com/bitcoin/bitcoin/pull/28814#issuecomment-1801296876)
Missing test prefix in pull title?

💬 maflcko commented on pull request "fuzz: call lookup functions before calling `Ban`":
(https://github.com/bitcoin/bitcoin/pull/27935#issuecomment-1801300389)
Are you still working on this?

💬 maflcko commented on pull request "fuzz: Avoid timeout and bloat in fuzz targets":
(https://github.com/bitcoin/bitcoin/pull/28815#issuecomment-1801380939)
Did the same for coins_view, because it followed the same pattern, even though a timeout is currently not reported by Oss-Fuzz.

💬 brunoerg commented on pull request "fuzz: call lookup functions before calling `Ban`":
(https://github.com/bitcoin/bitcoin/pull/27935#issuecomment-1801397067)
> Are you still working on this?

Yes

💬 maflcko commented on pull request "test/BIP324: functional tests for v2 P2P encryption":
(https://github.com/bitcoin/bitcoin/pull/24748#issuecomment-1801417208)
CI:

```
�[0m�[0;31mp2p_v2_earlykeyresponse.py | ✖ Failed | 1 s

🚀 fanquake merged a pull request: "test: symbolizer improvements"
(https://github.com/bitcoin/bitcoin/pull/28814)

👍 fanquake approved a pull request: "init: completely remove `-zapwallettxes` (remaining hidden option)"
(https://github.com/bitcoin/bitcoin/pull/28787#pullrequestreview-1719838322)
ACK 5039c346ca87d6112ea1eb124bdc622ba9e9a513

💬 naumenkogs commented on pull request "net: Add new permission `forceinbound` to evict a random unprotected connection if all slots are otherwise full":
(https://github.com/bitcoin/bitcoin/pull/27600#issuecomment-1801467007)
@pinheadmz Honestly I still struggle to understand what are the practical scenarios of using this. E.g., what could lead to not being able to evict a connection?

💬 naumenkogs commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1386309080)
`SyncState` yeah that would work if you come up with a good enum values.

🚀 fanquake merged a pull request: "test: Add missing sync on send_version in peer_connect"
(https://github.com/bitcoin/bitcoin/pull/28782)

🚀 fanquake merged a pull request: "tests: Increase wallet_miniscript.py rpc timeout to 90 seconds"
(https://github.com/bitcoin/bitcoin/pull/28820)

💬 maflcko commented on pull request "mempool: Persist with XOR":
(https://github.com/bitcoin/bitcoin/pull/28207#discussion_r1386333202)
Nice. Good idea. This drops a bunch of duplicate and dead code.

🚀 fanquake merged a pull request: "validation: return more helpful results for reconsiderable fee failures and skipped transactions"
(https://github.com/bitcoin/bitcoin/pull/28785)

💬 fanquake commented on pull request "build: remove `-bind_at_load` usage":
(https://github.com/bitcoin/bitcoin/pull/28783#issuecomment-1801565683)
> See https://github.com/theuni/bitcoin/commit/c61c9c5c772780be95ba7a8221ea13a72fe97d99 which is ugly but seems to work as intended.

I do hate `sed`. Pulled this is for now, but open to any other approaches if anyone has suggestions.

One other point is that last time I looked, `lld` only implemented a placeholder option for `-bind_at_load`, and I'd assume at this point, they won't bother actually implementing it, so after #21778 this flag will be even more of a no-op.

💬 maflcko commented on pull request "mempool: Persist with XOR":
(https://github.com/bitcoin/bitcoin/pull/28207#discussion_r1386407946)
The lambda is gone, so I think this is solved now.

📝 maflcko opened a pull request: "test: Add missing wait for version to be sent in add_outbound_p2p_connection"
(https://github.com/bitcoin/bitcoin/pull/28822)
Can be tested with:

```diff
diff --git a/test/functional/test_framework/p2p.py b/test/functional/test_framework/p2p.py
index b1ed97b794..eb4f72c6b6 100755
--- a/test/functional/test_framework/p2p.py
+++ b/test/functional/test_framework/p2p.py
@@ -205,6 +205,7 @@ class P2PConnection(asyncio.Protocol):
assert not self._transport
logger.debug("Connected & Listening: %s:%d" % (self.dstaddr, self.dstport))
self._transport = transport
+ import time;time.sl
...

💬 ismaelsadeeq commented on pull request "Fee Estimator updates from Validation Interface/CScheduler thread":
(https://github.com/bitcoin/bitcoin/pull/28368#discussion_r1386420330)
Done