🤔 murchandamus reviewed a pull request: "validation: return more helpful results for reconsiderable fee failures and skipped transactions"
(https://github.com/bitcoin/bitcoin/pull/28785#pullrequestreview-1718852604)
reACK 1147e00e59e47f27024ec96629993c66a3ce4ef0

💬 murchandamus commented on pull request "validation: return more helpful results for reconsiderable fee failures and skipped transactions":
(https://github.com/bitcoin/bitcoin/pull/28785#discussion_r1385633055)
I was very confused by the changes in this vein, until I realized that `CheckPackageMempoolAcceptResult(…)` returns an error in case of a CPMA failure, but returns nothing in the case of a success. Per the name of this function my initial expectation was that we would expect a truthy return value in case of successful acceptance.

💬 mzumsande commented on pull request "net: improve max-connection limits code":
(https://github.com/bitcoin/bitcoin/pull/28464#discussion_r1385649907)
I forgot about this comment - I hadn't considered it, and I think I would prefer `maxautoconnections`, but changing it (even with keeping an alias) seems like too much effort for too little benefit for my taste .

⚠️ Polkadotclaim opened an issue: "Guide on How to Claim Kasuma Airdrop"
(https://github.com/bitcoin/bitcoin/issues/28818)
### Please describe the feature you'd like to see added.

Hey Kasuma Community! 👋



We understand that claiming the Kasuma Airdrop can be an exciting yet unfamiliar process for some. Fear not! We've created this issue to provide you with a step-by-step guide on how to claim your Kasuma Airdrop tokens effortlessly.

Steps to Claim Kasuma Airdrop:

Stay Updated:
Keep an eye on
...

✅ pinheadmz closed an issue: "Guide on How to Claim Kasuma Airdrop"
(https://github.com/bitcoin/bitcoin/issues/28818)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/28818)

💬 pray-for-paris commented on issue "doc: Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/issues/18085#issuecomment-1800346918)
Where in the existing documentation can one read about bitcoin core's use of **keypools**? That's the one part of the story scenarios (@jonasschnelli 2nd story) that I don't yet understand. Thanks!

💬 leotese commented on pull request "fuzz: Avoid timeout and bloat in fuzz targets":
(https://github.com/bitcoin/bitcoin/pull/28815#issuecomment-1800349248)
Testing

💬 jkyiv commented on issue "doc: Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/issues/18085#issuecomment-1800350253)
Where in the existing documentation can one read about bitcoin core's use of keypools? That's the one part of the story scenarios (@jonasschnelli 2nd story) that I don't yet understand. Thanks!

💬 leotese commented on pull request "Wallet: Functions to enable adding used balance to GUI overview page":
(https://github.com/bitcoin/bitcoin/pull/28776#issuecomment-1800350436)
Cool!

📝 achow101 opened a pull request: "tests: Increase wallet_miniscript.py rpc timeout to 90 seconds"
(https://github.com/bitcoin/bitcoin/pull/28820)
The signing test for the large miniscript can sometimes take longer than the 30 second timeout, depending on the load on my system. Increasing it to 90 seconds seems to be good enough.

💬 pablomartin4btc commented on pull request "snapshots: don't core dump when running -checkblockindex after `loadtxoutset`":
(https://github.com/bitcoin/bitcoin/pull/28791#issuecomment-1800634060)
I'll check this soon.

💬 kevkevinpal commented on pull request "tests: Increase wallet_miniscript.py rpc timeout to 90 seconds":
(https://github.com/bitcoin/bitcoin/pull/28820#issuecomment-1800823676)
looks like the default is 60 seconds according to this
https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/test_framework.py#L103

but increasing seems fine ACK [6559e4d](https://github.com/bitcoin/bitcoin/pull/28820/commits/6559e4d27ac9e8344d1211239cffab427b94bc23)

💬 kevkevinpal commented on pull request "log: torcontrol opt checks":
(https://github.com/bitcoin/bitcoin/pull/28780#issuecomment-1800844121)
looks like automated tests are failing

💬 stratospher commented on pull request "test/BIP324: functional tests for v2 P2P encryption":
(https://github.com/bitcoin/bitcoin/pull/24748#issuecomment-1801073913)
Updated since #28374 is merged.

👋 stratospher's pull request is ready for review: "test/BIP324: functional tests for v2 P2P encryption"
(https://github.com/bitcoin/bitcoin/pull/24748)

💬 kouloumos commented on issue "doc: Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/issues/18085#issuecomment-1801253405)
> Where in the existing documentation can one read about bitcoin core's use of keypools? That's the one part of the story scenarios (@jonasschnelli 2nd story) that I don't yet understand. Thanks!

The comments at the relevant class provide context about keypools
https://github.com/bitcoin/bitcoin/blob/82ea4e787c791acbc85fd3043dd6bae038cba4f2/src/wallet/scriptpubkeyman.h#L55-L108

Also, if you want to get a quick understanding of the wallet's inner workings (including encryption, use of pass
...

💬 maflcko commented on pull request "tests: Increase wallet_miniscript.py rpc timeout to 90 seconds":
(https://github.com/bitcoin/bitcoin/pull/28820#issuecomment-1801255879)
lgtm ACK 6559e4d27ac9e8344d1211239cffab427b94bc23

💬 maflcko commented on pull request "fuzz: Avoid timeout and bloat in fuzz targets":
(https://github.com/bitcoin/bitcoin/pull/28815#issuecomment-1801265842)
> Question: What is the difference compared to #27552 ("partial" fuzzers)?

As I said on that pull request, it needs benchmarks and review on a case-by-case basis to check whether it is useful for a specific fuzz target. If someone wants to do those benchmarks on the fuzz targets touched in this pull request, and finds a positive outcome, nothing is holding anyone back from applying the concept.

The goal of this pull request is to prevent the fuzz engine from exploring invalid serialization
...

👍 ismaelsadeeq approved a pull request: "validation: return more helpful results for reconsiderable fee failures and skipped transactions"
(https://github.com/bitcoin/bitcoin/pull/28785#pullrequestreview-1719641686)
ACK 1147e00e59e47f27024ec96629993c66a3ce4ef0

looks good to me.