💬 ajtowns commented on pull request "rpc: Add script verification flags to getdeploymentinfo":
(https://github.com/bitcoin/bitcoin/pull/28806#discussion_r1385534115)
> Is this ever hit? If not, maybe it can be removed, as the remaining code should reach the same conclusion anyway in the rare case that this is hit?

It's hit for block 170060. I think it's worth having it be explicit, as it would also be reasonable to return "NONE" (as in `SCRIPT_VERIFY_NONE`) for that case.

💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1385542152)
Ah, good catch. Fixed

💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1385543718)
I don't think it particularly matters since a wallet without private keys cannot have a global hd key. However I have changed it so that it is set only if private keys are enabled.

💬 achow101 commented on pull request "shutdown: Destroy kernel last, make test shutdown order consistent":
(https://github.com/bitcoin/bitcoin/pull/28224#issuecomment-1800121448)
ACK c1144f0076339c775f41d4b5fcfdc72191440d96

🚀 achow101 merged a pull request: "shutdown: Destroy kernel last, make test shutdown order consistent"
(https://github.com/bitcoin/bitcoin/pull/28224)

💬 achow101 commented on pull request "multiprocess compatibility updates":
(https://github.com/bitcoin/bitcoin/pull/28721#issuecomment-1800179388)
ACK 3b70f7b6156cb110c47a6e482791cf337bb6ad6d

💬 achow101 commented on pull request "validation: return more helpful results for reconsiderable fee failures and skipped transactions":
(https://github.com/bitcoin/bitcoin/pull/28785#issuecomment-1800200116)
ACK 1147e00e59e47f27024ec96629993c66a3ce4ef0

💬 achow101 commented on pull request "test: python cryptography required for BIP 324 functional tests":
(https://github.com/bitcoin/bitcoin/pull/28374#issuecomment-1800222458)
ACK c534c0871038ded72dc9078cc91e030ceb746196

💬 sipa commented on pull request "contrib: Add asmap-tool":
(https://github.com/bitcoin/bitcoin/pull/28793#discussion_r1385624420)
Not right now; we could drop that for now. I think the idea was supporting loading an asmap, and then also loading a patch file on top of it (which could be created by diffing).

💬 sipa commented on pull request "contrib: Add asmap-tool":
(https://github.com/bitcoin/bitcoin/pull/28793#discussion_r1385624685)
Nit: typo "overallping"

🚀 achow101 merged a pull request: "test: python cryptography required for BIP 324 functional tests"
(https://github.com/bitcoin/bitcoin/pull/28374)

💬 achow101 commented on pull request "net: improve max-connection limits code":
(https://github.com/bitcoin/bitcoin/pull/28464#issuecomment-1800241388)
ACK df69b22f2e3cc03764a582f29a16a36114f67e17

🚀 achow101 merged a pull request: "net: improve max-connection limits code"
(https://github.com/bitcoin/bitcoin/pull/28464)

🤔 murchandamus reviewed a pull request: "validation: return more helpful results for reconsiderable fee failures and skipped transactions"
(https://github.com/bitcoin/bitcoin/pull/28785#pullrequestreview-1718852604)
reACK 1147e00e59e47f27024ec96629993c66a3ce4ef0

💬 murchandamus commented on pull request "validation: return more helpful results for reconsiderable fee failures and skipped transactions":
(https://github.com/bitcoin/bitcoin/pull/28785#discussion_r1385633055)
I was very confused by the changes in this vein, until I realized that `CheckPackageMempoolAcceptResult(…)` returns an error in case of a CPMA failure, but returns nothing in the case of a success. Per the name of this function my initial expectation was that we would expect a truthy return value in case of successful acceptance.

💬 mzumsande commented on pull request "net: improve max-connection limits code":
(https://github.com/bitcoin/bitcoin/pull/28464#discussion_r1385649907)
I forgot about this comment - I hadn't considered it, and I think I would prefer `maxautoconnections`, but changing it (even with keeping an alias) seems like too much effort for too little benefit for my taste .

⚠️ Polkadotclaim opened an issue: "Guide on How to Claim Kasuma Airdrop"
(https://github.com/bitcoin/bitcoin/issues/28818)
### Please describe the feature you'd like to see added.

Hey Kasuma Community! 👋



We understand that claiming the Kasuma Airdrop can be an exciting yet unfamiliar process for some. Fear not! We've created this issue to provide you with a step-by-step guide on how to claim your Kasuma Airdrop tokens effortlessly.

Steps to Claim Kasuma Airdrop:

Stay Updated:
Keep an eye on
...

✅ pinheadmz closed an issue: "Guide on How to Claim Kasuma Airdrop"
(https://github.com/bitcoin/bitcoin/issues/28818)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/28818)

💬 pray-for-paris commented on issue "doc: Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/issues/18085#issuecomment-1800346918)
Where in the existing documentation can one read about bitcoin core's use of **keypools**? That's the one part of the story scenarios (@jonasschnelli 2nd story) that I don't yet understand. Thanks!