✅ achow101 closed an issue: "Write instructions on offline signing."
(https://github.com/bitcoin/bitcoin/issues/9492)

🚀 achow101 merged a pull request: "doc: Add offline signing tutorial"
(https://github.com/bitcoin/bitcoin/pull/28363)

💬 TheBlueMatt commented on issue "Wallet Missing Balances/Unspent":
(https://github.com/bitcoin/bitcoin/issues/28797#issuecomment-1795347642)
```
getwalletinfo
{
"walletname": "",
"walletversion": 169900,
"format": "bdb",
...
"keypoolsize": 1000,
"keypoolsize_hd_internal": 1000,
"paytxfee": 0.00000000,
"private_keys_enabled": true,
"avoid_reuse": false,
"scanning": false,
"descriptors": false,
"external_signer": false
}
```

💬 1440000bytes commented on issue "Wallet Missing Balances/Unspent":
(https://github.com/bitcoin/bitcoin/issues/28797#issuecomment-1795362833)
> "walletconflicts": [
> "1bd8d162be5a4b91c083866386a9e6ca0201f2c837241350855a61a7d4a9f78c"

Maybe this is the reason for incorrect balance?

💬 andrewtoth commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1383787269)
Here we are using `std::set::find` and below on line 1141 we are using `std::set::count` to determine if an element already exists. We should use a consistent method for each. I'm not sure if C++20 is supported in this codebase yet, but we should use `std::set::contains` if it is.

🤔 andrewtoth reviewed a pull request: "cli: improve error message on multiwallet and add validation to cli-side commands"
(https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1715911067)
style-nit: all variable and function names should be snake_case https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style-c.

💬 TheBlueMatt commented on issue "Wallet Missing Balances/Unspent":
(https://github.com/bitcoin/bitcoin/issues/28797#issuecomment-1795856728)
Probably, but just because a transaction was RBF-bumped there shouldn't be an incorrect balance/missing unspent entry :)

🤔 katesalazar reviewed a pull request: "gui: add used balance to overview page"
(https://github.com/bitcoin-core/gui/pull/775#pullrequestreview-1715933567)
Concept ACK

💬 katesalazar commented on pull request "gui: add used balance to overview page":
(https://github.com/bitcoin-core/gui/pull/775#discussion_r1383801194)
https://bitcoin.stackexchange.com/a/38998/126793

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#issuecomment-1795922777)
> style-nit: all variable and function names should be snake_case https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style-c.

Thanks for checking that, you are right, I'll fix them all ASAP.

💬 katesalazar commented on pull request "Wallet: Functions to enable adding used balance to GUI overview page":
(https://github.com/bitcoin/bitcoin/pull/28776#issuecomment-1795925965)
Concept ACK

💬 katesalazar commented on pull request "gui: add used balance to overview page":
(https://github.com/bitcoin-core/gui/pull/775#discussion_r1383815524)
> > Because the space is tiny, and the impact should be big, every word in an effective tooltip needs to pack a punch.
>
> Source: Internet

as the tooltip for the "used" line of the "balances" block,
"your current used balance" doesnt feel like a great tooltip

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1383818109)
It makes sense, I'll use `std::set::find` instead of `std::set::count` (L#1141).

Regarding C++20. it's [not enabled](https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L99) yet but perhaps will be soon (#28349). If this PR doesn't get merged first I'll update the code as you suggested so I'm leaving this conversation as unresolved, otherwise I'll do a follow-up.

💬 fanquake commented on issue "Wallet Missing Balances/Unspent":
(https://github.com/bitcoin/bitcoin/issues/28797#issuecomment-1795955354)
cc @achow101

💬 achow101 commented on issue "Wallet Missing Balances/Unspent":
(https://github.com/bitcoin/bitcoin/issues/28797#issuecomment-1796181526)
I think the only conditions for this to happen are either the output has been spent by something in the wallet that has not been broadcast yet, or if the wallet thinks that those outputs are not ismine. The latter shouldn't be possible given that `getaddressinfo` reports both addresses as ismine. Can you check if there is some transaction in your wallet that is spending that output but wasn't broadcast?

It could be that the output is locked with `lockunspent`, but that should only affect `lis
...

💬 achow101 commented on pull request "wallet: cache descriptor ID to avoid repeated descriptor string creation":
(https://github.com/bitcoin/bitcoin/pull/28799#issuecomment-1796284261)
ACK 5e6bc6d830664a5afeb5d5bd7e7b3818a01376b7

💬 ariard commented on pull request "policy: Enable full-rbf by default":
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-1796295871)
Hi @Daniel600

> HI @ariard - has this PR been decided to be merged already? What would the timeline to expect if it will be released with 27.0 or 28.0? (i.e When should we expect 27.0 or 28.0 to released?)

For your clarity and wider transparency, to the best of my understanding, we don't have a decision process among the community about mempool policy changes affecting Bitcoin applications in a wide scale fashion, as `mempoolfullrbf` is I believe one of them. I think the best process we m
...

💬 fjahr commented on pull request "contrib: Add asmap-tool":
(https://github.com/bitcoin/bitcoin/pull/28793#discussion_r1383924519)
done

💬 achow101 commented on pull request "ArgsManager: support subcommand-specific options":
(https://github.com/bitcoin/bitcoin/pull/28802#discussion_r1383925133)
In 50368d92ff0f878af2d6a70773bdf6a6e29b25bb "ArgsManager: support subcommand specific options"

I found this name to be confusing since the word "subcommand" implies that the option itself is a subcommand (i.e. the same category as `COMMANDS`), rather than it being an option to a command. Would suggest renaming this to something like `COMMAND_OPT`.

✅ achow101 closed an issue: "test: wallet_miniscript.py fails with thread sanitizer "
(https://github.com/bitcoin/bitcoin/issues/28800)