⚠️ dergoegge opened an issue: "fuzz: Re-introduce i2p target"
(https://github.com/bitcoin/bitcoin/issues/28803)
We deleted the i2p target (#28692) because it wasn't effective at covering the i2p code and as a result never found any bugs. Someone should re-work the target and then re-introduce it to the repo.

Some of the short comings of the previous harness were identified:
* The temporary file created for the private key should be deleted at the end of each iteration (https://github.com/bitcoin/bitcoin/blob/106ab20f121f14d021725c8a657999079dbabfc1/src/test/fuzz/i2p.cpp#L34), or better yet don't use a
...

💬 willcl-ark commented on issue "High CPU load when network traffic page left open":
(https://github.com/bitcoin-core/gui/issues/768#issuecomment-1794692567)
Tested again with 26.0rc2 binary from bitcoincore.org, and the issue is still present for me. So long as the graph content is relatively "varied", then one CPU constantly thrashes between ~60-100%.


Seems to happen even more readily if I set the scale to 5m where even with fewer data points shown (I think) it pretty much just pins a single core to 100%

![image](https://github.com/bitcoin-cor
...

💬 maflcko commented on pull request "refactor: Simplify CTxMempool/BlockAssembler fields, remove some external mapTx access":
(https://github.com/bitcoin/bitcoin/pull/28391#discussion_r1383242173)
```suggestion
CTxMemPoolEntry* GetEntry(const uint256& hash) const LIFETIMEBOUND EXCLUSIVE_LOCKS_REQUIRED(cs);
```

Instead of optional ref, could just use a pointer?

💬 maflcko commented on pull request "net: support unix domain sockets for -proxy and -onion":
(https://github.com/bitcoin/bitcoin/pull/27375#issuecomment-1794721136)
To preserve CI resources, only one task is re-run to detect silent merge conflicts.

💬 maflcko commented on pull request "build: Require C++20 compiler":
(https://github.com/bitcoin/bitcoin/pull/28349#issuecomment-1794726325)
Rebased. This should be possible to review, and should work on all platforms, I guess, except for macOS?

Once and if this is merged, I'll follow-up with a `fs.h` cleanup.

💬 TheCharlatan commented on pull request "refactor: Simplify CTxMempool/BlockAssembler fields, remove some external mapTx access":
(https://github.com/bitcoin/bitcoin/pull/28391#discussion_r1383268650)
Yeah, I thought this would better convey its semantics, but with all the force pushes over the past two hours, it seems like it is not intuitive to work with, so I'll revert to using a pointer.

💬 fanquake commented on pull request "guix: switch to 6.1 kernel headers over 5.15":
(https://github.com/bitcoin/bitcoin/pull/28786#issuecomment-1794834244)
> I can't see anything obvious that would do that.

Sent a patch upstream, https://lists.gnu.org/archive/html/guix-patches/2023-11/msg00362.html, to see if we can get some unversioned pointers to stable/longterm added.

👍 BrandonOdiwuor approved a pull request: "wallet: cache descriptor ID to avoid repeated descriptor string creation"
(https://github.com/bitcoin/bitcoin/pull/28799#pullrequestreview-1715206734)
ACK 5e6bc6d830664a5afeb5d5bd7e7b3818a01376b7

looks good to me

🤔 glozow reviewed a pull request: "test: bugfix CheckPackageMempoolAcceptResult return all error strings"
(https://github.com/bitcoin/bitcoin/pull/28788#pullrequestreview-1715221980)
utACK 5380f055136ea99f76cd3df2c2add081852d35d0

💬 glozow commented on pull request "validation: return more helpful results for reconsiderable fee failures and skipped transactions":
(https://github.com/bitcoin/bitcoin/pull/28785#discussion_r1383369213)
Added comment

💬 glozow commented on pull request "validation: return more helpful results for reconsiderable fee failures and skipped transactions":
(https://github.com/bitcoin/bitcoin/pull/28785#discussion_r1383369301)
Taken

💬 glozow commented on pull request "validation: return more helpful results for reconsiderable fee failures and skipped transactions":
(https://github.com/bitcoin/bitcoin/pull/28785#discussion_r1383369984)
Changed :+1:

💬 TheCharlatan commented on pull request "refactor: Simplify CTxMempool/BlockAssembler fields, remove some external mapTx access":
(https://github.com/bitcoin/bitcoin/pull/28391#issuecomment-1794886627)
Updated 66a4c881e3387b55b26cd2a890bd0d5d522c6727 -> 995aa6b9cb5d1ea685a5d2ac6767d21b373e4c84 ([simplifyMemPoolInteractions_9](https://github.com/TheCharlatan/bitcoin/tree/simplifyMemPoolInteractions_9) -> [simplifyMemPoolInteractions_10](https://github.com/TheCharlatan/bitcoin/tree/simplifyMemPoolInteractions_10), [compare](https://github.com/TheCharlatan/bitcoin/compare/simplifyMemPoolInteractions_9..simplifyMemPoolInteractions_10))

* Addressed @maflcko's [comment](https://github.com/bitcoi
...

💬 maflcko commented on pull request "ArgsManager: support subcommand-specific options":
(https://github.com/bitcoin/bitcoin/pull/28802#issuecomment-1794891484)
tool_wallet.py fails CI

👍 dergoegge approved a pull request: "test: bugfix CheckPackageMempoolAcceptResult return all error strings"
(https://github.com/bitcoin/bitcoin/pull/28788#pullrequestreview-1715285547)
utACK 5380f055136ea99f76cd3df2c2add081852d35d0

🚀 fanquake merged a pull request: "test: bugfix CheckPackageMempoolAcceptResult return all error strings"
(https://github.com/bitcoin/bitcoin/pull/28788)

💬 murchandamus commented on pull request "validation: return more helpful results for reconsiderable fee failures and skipped transactions":
(https://github.com/bitcoin/bitcoin/pull/28785#discussion_r1383433511)
It was not obvious to me what the motivation for `SINGLE` in the constant name here is. After discussing with @glozow, maybe:

```suggestion
TX_RECONSIDERABLE, //!< mining score was insufficient to meet some policy, but transaction might be acceptable if submitted in a (different) package
```

💬 Zero-1729 commented on pull request "doc: Add offline signing tutorial":
(https://github.com/bitcoin/bitcoin/pull/28363#discussion_r1383445833)
Minor capitalization nit.

```suggestion
1. Unlock the `offline_wallet` with the passphrase:
```

💬 Zero-1729 commented on pull request "doc: Add offline signing tutorial":
(https://github.com/bitcoin/bitcoin/pull/28363#discussion_r1383446166)
Minor capitalization nit.

```suggestion
* `offline` host which is disconnected from all networks (Internet, Tor, wifi, Bluetooth, etc.) and does not have, or need, a copy of the blockchain.
```

💬 Zero-1729 commented on pull request "doc: Add offline signing tutorial":
(https://github.com/bitcoin/bitcoin/pull/28363#discussion_r1383447044)
Minor hyphenation nit.

```suggestion
Maintaining an air gap between private keys and any network connections drastically reduces the opportunity for those keys to be exfiltrated from the user.
```