💬 jonatack commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#issuecomment-1458550061)
> consider adding a comment at the top of the file probably, stating the expected results

Good idea @LarryRuane (thanks!). Done.

📝 johnny9 opened a pull request: "Update chainparams for 25.x"
(https://github.com/bitcoin/bitcoin/pull/27223)

Update chain parameters for upcoming major release. See [doc/release-process.md](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md) for review instructions. Followed instructions from #24418 closely as well.

- `m_assumed_blockchain_size`, `m_assumed_chain_state_size`:

mainnet
```
.bitcoin$ du -h --exclude=signet --exclude=testnet3 .
0 ./wallets
117M ./blocks/index
489G ./blocks
4.9G ./chainstate
494G .
.bitcoin$ python3
Python 3.11.1 (main,
...

💬 johnny9 commented on pull request "Update chainparams for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27223#issuecomment-1458585212)
Might have jumped the gun on this. Says "Before branch-off"

💬 achow101 commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1458593730)
ACK 802cc1ef536e11944608fe9ab782d3e962037703

🚀 achow101 merged a pull request: "Deduplicate bitcoind and bitcoin-qt init code"
(https://github.com/bitcoin/bitcoin/pull/27150)

💬 LarryRuane commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#issuecomment-1458622474)
ACK 8c47d599b87d6b2d43e7d37ce0aaf4f541535bb9
The commits are very clean.

💬 brunoerg commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1128354369)
You're right. Considering it comes from GUI, it's better to check whether it has value. Addressed it!

💬 brunoerg commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#issuecomment-1458628670)
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1127278080

💬 fanquake commented on issue "Issue in `p2p_ibd_stalling.py` under Valgrind":
(https://github.com/bitcoin/bitcoin/issues/27208#issuecomment-1458702913)
> Is there a combined log or similar?

```bash
............................ 170/256 - p2p_ibd_stalling.py failed, Duration: 134 s

stdout:
2023-03-07T18:57:54.280000Z TestFramework (INFO): PRNG seed is: 6725125940728086953
2023-03-07T18:57:54.281000Z TestFramework (INFO): Initializing test directory /home/ubuntu/ci_scratch/ci/scratch/test_runner/test_runner_₿_🏃_
...

💬 fanquake commented on pull request "Update chainparams for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27223#issuecomment-1458705526)
> Might have jumped the gun on this.

Yea, it's a bit too early to be doing this. See #26549.

💬 fanquake commented on pull request "test: Default timeout factor to 4 under --valgrind":
(https://github.com/bitcoin/bitcoin/pull/27221#issuecomment-1458711392)
Concept ACK - will test

💬 stratospher commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/26988#discussion_r1128463603)
thanks! done.

💬 fanquake commented on pull request "doc: DummySignInput mention external signer":
(https://github.com/bitcoin/bitcoin/pull/27180#issuecomment-1458722234)
cc @S3RK @ishaanam @furszy

💬 MarcoFalke commented on pull request "refactor: Use move semantics instead of custom swap functions":
(https://github.com/bitcoin/bitcoin/pull/26749#issuecomment-1458725581)
Changes:

* Adding a wrong hunk? https://github.com/bitcoin/bitcoin/pull/26749#discussion_r1123429117
* Fixing my feedback from https://github.com/bitcoin/bitcoin/pull/26749#discussion_r1071035557
* Adding commit 7673fd0b41

re-ACK 142718890e718397e0026c315c8940102b9657ce 📬

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDD
...

💬 stratospher commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/26988#issuecomment-1458734131)
>Instead of being a string, wouldn't make sense it to be an array? E.g. I want to get new/tried table address count for ipv5 and ipv6 together.

i'm confused about this since making it into `RPCArg::Type::ARR` would make the RPC harder to type and use?
`$ bitcoin-cli getaddrmaninfo "[\"ipv4\", \"ipv6\"]"`

and there are only few network types. would be interested in what others think.

💬 fanquake commented on pull request "refactor: Split util/system into exception, shell, and fs-specific files":
(https://github.com/bitcoin/bitcoin/pull/25152#issuecomment-1458740529)
> I'm still keen on moving this work forward. If you don't have the time right now, I'll attribute the commits to you and try to get my branch merged instead.

Yep, it would be good to start getting some of this merged.

💬 pinheadmz commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1128487451)
Feels like there must be a way to express this without rewriting the filter? I think the only reason you need to do that here is because `list(coinbase_filter)` exhausts the iterator so you need to start it over. What if `coinbase_filter` was actually a list called `mature_coins` from the beginning of the function? I dunno, just an idea.

💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1128491150)
I'll keep this as is, to me this reads easier. We also do use the options struct before to read the fastprune flag.

💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1458819504)
Thank you for the review! These are valuable and I hope they allow me to improve future commits. I'm pushing changes addressing comments up to the 4th commit now.

Updated a1db3966d1c4f4213d7bfd6be0ea7fb308fe4e11 -> 65d026b47270c2fb9d2dab7f3d448b4abc37b93a ([tc/2022-09-libbitcoinkernel-chainparams-args_0](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_0) -> [tc/2022-09-libbitcoinkernel-chainparams-args_1](https://github.com/TheCharlatan/bitcoin/co
...

💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1128545452)
Thank you for spelling this out, I updated the description.