💬 hebasto commented on pull request "depends: drop -O1 workaround from arm64 apple Qt build":
(https://github.com/bitcoin/bitcoin/pull/28778#issuecomment-1791078896)
Concept ACK. Nice :)

👋 fanquake's pull request is ready for review: "doc: update docs for `CHECK_ATOMIC` macro"
(https://github.com/bitcoin/bitcoin/pull/28777)

💬 fanquake commented on pull request "doc: update docs for `CHECK_ATOMIC` macro":
(https://github.com/bitcoin/bitcoin/pull/28777#issuecomment-1791118146)
Clang prior to version 15, when compiling for 32-bit, is the culprit here (I misread the CI). Have updated the docs.

💬 maflcko commented on pull request "doc: update docs for `CHECK_ATOMIC` macro":
(https://github.com/bitcoin/bitcoin/pull/28777#issuecomment-1791174436)
Jup, it is still needed. Steps to reproduce on a fresh install of bullseye:

`export DEBIAN_FRONTEND=noninteractive && apt update && apt install curl wget htop git vim ccache -y && git clone https://github.com/bitcoin/bitcoin.git --depth=1 && cd bitcoin && apt install build-essential libtool autotools-dev automake pkg-config bsdmainutils python3-zmq make automake cmake curl clang-13 llvm-13 g++-multilib libtool binutils-gold bsdmainutils pkg-config python3 patch bison -y && ( cd depends && ma
...

💬 achow101 commented on pull request "MiniMiner changes for package linearization":
(https://github.com/bitcoin/bitcoin/pull/28762#issuecomment-1791255104)
ACK a5b6481b94580ef2cc2d9c45ac1c1959e79a82b2

💬 achow101 commented on pull request "Replace RecursiveMutex m_cs_banned with Mutex, and rename it":
(https://github.com/bitcoin/bitcoin/pull/24097#issuecomment-1791258148)
ACK 37d150d8c5ffcb2bddcd99951a739e97571194c7

🚀 achow101 merged a pull request: "Replace RecursiveMutex m_cs_banned with Mutex, and rename it"
(https://github.com/bitcoin/bitcoin/pull/24097)

💬 Ayush170-Future commented on pull request "fuzz: wallet, add target for Spend":
(https://github.com/bitcoin/bitcoin/pull/28236#issuecomment-1791356580)
The `fuzzer` logs are unclear, I'm not sure why it failed suddenly. Maybe some issue with the Fuzzer again?

💬 maflcko commented on pull request "fuzz: wallet, add target for Spend":
(https://github.com/bitcoin/bitcoin/pull/28236#issuecomment-1791381061)
You'll need to rebase on current master in any case

⚠️ hebasto opened an issue: "`libbitcoinconsensus.a` is unusable"
(https://github.com/bitcoin/bitcoin/issues/28779)
On Ubuntu 22.04, in the master branch @ 0857f2935f90df9c3d303582e5b62a9c8dedd9d7:
```
$ ./autogen.sh
$ ./configure --without-daemon --without-gui --without-utils --disable-tests --disable-bench --disable-fuzz-binary --disable-shared --prefix=/
$ make
$ make DESTDIR=~/CONSENSUS install
$ g++ testconsensus.cpp -o testconsensus -I ~/CONSENSUS/include -L ~/CONSENSUS/lib -l:libbitcoinconsensus.a
/usr/bin/ld: /home/hebasto/CONSENSUS/lib/libbitcoinconsensus.a(libbitcoinconsensus_la-pubkey.o): in
...

💬 hebasto commented on issue "`libbitcoinconsensus.a` is unusable":
(https://github.com/bitcoin/bitcoin/issues/28779#issuecomment-1791383638)
cc @theuni @TheCharlatan @fanquake @ryanofsky

💬 achow101 commented on pull request "test: add coverage to rpc_blockchain.py":
(https://github.com/bitcoin/bitcoin/pull/27852#issuecomment-1791405002)
ACK 376dc2cfb32806a8aa450589effe4d384e648398

🚀 achow101 merged a pull request: "test: add coverage to rpc_blockchain.py"
(https://github.com/bitcoin/bitcoin/pull/27852)

🤔 kevkevinpal reviewed a pull request: "MiniMiner changes for package linearization"
(https://github.com/bitcoin/bitcoin/pull/28762#pullrequestreview-1709331080)
ACK a5b6481b94580ef2cc2d9c45ac1c1959e79a82b2

added few small nits but feel free to ignore

💬 kevkevinpal commented on pull request "MiniMiner changes for package linearization":
(https://github.com/bitcoin/bitcoin/pull/28762#discussion_r1379509252)
nit: Should we make some of these values into a variable instead of hardcoding the number?

💬 kevkevinpal commented on pull request "MiniMiner changes for package linearization":
(https://github.com/bitcoin/bitcoin/pull/28762#discussion_r1379505261)
nit:
I just noticed `CENT/100` is used in this file for tx 5's fee aswell, not sure if it makes sense to make a common variable to use for both

💬 kevkevinpal commented on pull request "wallet: allowing walletpassphrase timeout to be MAX_SLEEP_TIME if set to -1":
(https://github.com/bitcoin/bitcoin/pull/28454#issuecomment-1791427196)
> rebased to [76b1c4c](https://github.com/bitcoin/bitcoin/pull/28454/commits/76b1c4ca6eea327328c7a0b035e6f2b1a2211e51) and since this [PR 28617](https://github.com/bitcoin/bitcoin/pull/28617) has been merged only the test-framework will be modified so I am not sure if this change is needed anymore.
>
> Thoughts @maflcko? I am happy to close this

closing this pull request

✅ kevkevinpal closed a pull request: "wallet: allowing walletpassphrase timeout to be MAX_SLEEP_TIME if set to -1"
(https://github.com/bitcoin/bitcoin/pull/28454)

💬 achow101 commented on pull request "refactor: use string_view for passing string literals to Parse{Hash,Hex}":
(https://github.com/bitcoin/bitcoin/pull/28172#issuecomment-1791441941)
ACK bb91131d545d986aab81c4bb13676c4520169259

🚀 achow101 merged a pull request: "refactor: use string_view for passing string literals to Parse{Hash,Hex}"
(https://github.com/bitcoin/bitcoin/pull/28172)