💬 achow101 commented on pull request "wallet: Replace use of purpose strings with an enum":
(https://github.com/bitcoin/bitcoin/pull/27217#discussion_r1128102852)
Done

💬 achow101 commented on pull request "wallet: Replace use of purpose strings with an enum":
(https://github.com/bitcoin/bitcoin/pull/27217#discussion_r1128103018)
Done

💬 achow101 commented on issue "`combinepsbt` RPC does not work with P2TR inputs":
(https://github.com/bitcoin/bitcoin/issues/27219#issuecomment-1458416545)
The combined PSBT is correctly combined, there are just no signatures in any of the PSBTs. There's nothing to finalize, so it cannot be finalized.

💬 pinheadmz commented on issue "ThreadDNSAddressSeed hangs on sk_wait_data and doesn't stop on exit":
(https://github.com/bitcoin/bitcoin/issues/16778#issuecomment-1458423187)
@Nikolay-Po is this still an issue on the latest release of bitcoin core?

📝 MarcoFalke opened a pull request: "test: Default timeout factor to 4 under --valgrind"
(https://github.com/bitcoin/bitcoin/pull/27221)
valgrind will incur a slowdown of at least 2, so increase the default timeout factor.

This should reduce the number of reported issues. See also https://github.com/bitcoin/bitcoin/issues/27112#issuecomment-1455762739

💬 pinheadmz commented on issue "IBD slowed down by failing to deal with a bad checksum block message":
(https://github.com/bitcoin/bitcoin/issues/18755#issuecomment-1458442569)
I think this was closed by https://github.com/bitcoin/bitcoin/pull/19107. @rebroad are you able to still reproduce this issue with the latest release of Bitcoin Core?

💬 1440000bytes commented on issue "`combinepsbt` RPC does not work with P2TR inputs":
(https://github.com/bitcoin/bitcoin/issues/27219#issuecomment-1458450836)
> The combined PSBT is correctly combined, there are just no signatures in any of the PSBTs. There's nothing to finalize, so it cannot be finalized.

This wasn't don't manually, all PSBTs passed through `walletprocesspsbt`, I used the same code for segwit inputs and it worked. I will re-test everything although fractalcrypt told me this can be fixed with an open PR: https://twitter.com/FractalEncrypt/status/1633073353580859396

👍 theStack approved a pull request: "test: Log when LongpollThread is ending"
(https://github.com/bitcoin/bitcoin/pull/26996)
ACK fa6a2be8eff9b67e5f6e378c2d5999981804c692

💬 achow101 commented on issue "`combinepsbt` RPC does not work with P2TR inputs":
(https://github.com/bitcoin/bitcoin/issues/27219#issuecomment-1458453570)
Yes, it is a bug in signing, not in combining.

💬 MarcoFalke commented on pull request "test: Log when LongpollThread is ending":
(https://github.com/bitcoin/bitcoin/pull/26996#issuecomment-1458464523)
Sorry, this slipped the inbox. I'll reply to the feedback

💬 MarcoFalke commented on pull request "test: Log when LongpollThread is ending":
(https://github.com/bitcoin/bitcoin/pull/26996#issuecomment-1458467484)
> Is there an example where logging the end of a thread in such a way could offer an advantage during debugging?

Good point. It probably doesn't. It should already be clear from the assertion being hit (or not being hit) whether the thread exited or not.

⚠️ MarcoFalke opened an issue: "test: use-of-uninitialized-value in sqlite3Strlen30"
(https://github.com/bitcoin/bitcoin/issues/27222)
https://cirrus-ci.com/task/5021971277152256?logs=ci#L3656

```
wallet/test/feebumper_tests.cpp(18): Entering test suite "feebumper_tests"
wallet/test/feebumper_tests.cpp(42): Entering test case "external_max_weight_test"
2023-01-30T17:19:34Z Seed: Setting random seed for current tests to RANDOM_CTX_SEED=231d587d0169ecab6befbed75f49c95aa84567b2750479dca13bd7471f2627e2
2023-01-30T17:19:34.255341Z [test] [init/common.cpp:149] [LogPackageVersion] Bitcoin Core version v24.99.0-a55717c914f8 (rel
...

💬 MarcoFalke commented on issue "test: use-of-uninitialized-value in sqlite3Strlen30":
(https://github.com/bitcoin/bitcoin/issues/27222#issuecomment-1458484442)
For reference, the path seems to be `""` (empty string), but that shouldn't be an issue?

💬 MarcoFalke commented on issue "IBD slowed down by failing to deal with a bad checksum block message":
(https://github.com/bitcoin/bitcoin/issues/18755#issuecomment-1458493054)
Can be re-opened if this is confirmed to be happening on a recent vanilla release of Bitcoin Core. Bonus points will be assigned for steps to reproduce.

✅ MarcoFalke closed an issue: "IBD slowed down by failing to deal with a bad checksum block message"
(https://github.com/bitcoin/bitcoin/issues/18755)

💬 pinheadmz commented on issue "Potential data race on fHavePruned flag":
(https://github.com/bitcoin/bitcoin/issues/21627#issuecomment-1458495557)
I think this issue can be closed, `fHavePruned` seems to have been replaced with `chainman().m_blockman.m_have_pruned` (etc) and looks to me like all the setters (e.g. `FlushStateToDisk()`) have appropriate locks

💬 MarcoFalke commented on pull request "test: Flatten miniwallet array and remove random fee in longpoll":
(https://github.com/bitcoin/bitcoin/pull/26996#discussion_r1128202695)
Thanks, dropped the commit

💬 MarcoFalke commented on pull request "test: Flatten miniwallet array and remove random fee in longpoll":
(https://github.com/bitcoin/bitcoin/pull/26996#discussion_r1128202898)
Thanks, dropped the commit

👋 Sjors's pull request is ready for review: "wallet: 26032 followups"
(https://github.com/bitcoin/bitcoin/pull/27180)

💬 Sjors commented on pull request "wallet: 26032 followups":
(https://github.com/bitcoin/bitcoin/pull/27180#issuecomment-1458502104)
Not really I guess...