💬 glozow commented on pull request "MiniMiner changes for package linearization":
(https://github.com/bitcoin/bitcoin/pull/28762#issuecomment-1787632152)
last push changed new instances of uint256 to Txid

💬 theuni commented on pull request "build: remove duplicate `-lminiupnpc` linking":
(https://github.com/bitcoin/bitcoin/pull/28755#discussion_r1377917232)
Lol, you trying to tell me something? :)

👍 theuni approved a pull request: "build: remove duplicate `-lminiupnpc` linking"
(https://github.com/bitcoin/bitcoin/pull/28755#pullrequestreview-1706842520)
ACK b74e449ffa9965f18037f0322ea178e2fe1dbc18

✅ fanquake closed an issue: "guix: prune Rust toolchain boostrap from Darwin HOSTS"
(https://github.com/bitcoin/bitcoin/issues/28449)

🚀 fanquake merged a pull request: "guix: update signapple to latest master"
(https://github.com/bitcoin/bitcoin/pull/28759)

💬 fanquake commented on pull request "guix: update signapple to latest master":
(https://github.com/bitcoin/bitcoin/pull/28759#issuecomment-1787637550)
Added to #28754 for backporting to 26.x.

👋 fanquake's pull request is ready for review: "[26.x] Backports for rc2"
(https://github.com/bitcoin/bitcoin/pull/28754)

💬 fanquake commented on pull request "[26.x] Backports for rc2":
(https://github.com/bitcoin/bitcoin/pull/28754#issuecomment-1787645890)
Added final backports, and bumped version + manpages. We also just merged a translation update, which I rebased this branch on top of.

📝 jonatack reopened a pull request: "test: add peer connection unit test coverage"
(https://github.com/bitcoin/bitcoin/pull/28749)
This PR is based on #28155 and adds unit test coverage for each change in it (i.e. tests that fail on master), as well as some missing unit test coverage in general for `CConnman::AddNode()`, `ConnectNode()`, `GetAddedNodeInfo()`, `ThreadOpenAddedConnections()`, and RPC `addnode` -- see coverage check at https://corecheck.dev/bitcoin/bitcoin/pulls/28749. I'm building on these initial unit tests for writing coverage for #28248.

A version of this branch based on current master instead of #2815
...

💬 vasild commented on pull request "Do the SOCKS5 handshake reliably":
(https://github.com/bitcoin/bitcoin/pull/28649#issuecomment-1787664526)
`608f8aa1c4...af0fca530e`: use a `Span` for `Sock::SendComplete()`, looks better, thanks for the [suggestion](https://github.com/bitcoin/bitcoin/pull/28649#issuecomment-1765229184).

💬 jonatack commented on pull request "net: improves addnode / m_added_nodes logic":
(https://github.com/bitcoin/bitcoin/pull/28155#discussion_r1377947935)
Thanks, I've repushed #28749 with the update.

💬 sr-gi commented on pull request "net: improves addnode / m_added_nodes logic":
(https://github.com/bitcoin/bitcoin/pull/28155#discussion_r1377955800)
Rebased

✅ jonatack closed a pull request: "test: add peer connection unit test coverage"
(https://github.com/bitcoin/bitcoin/pull/28749)

💬 jonatack commented on pull request "test: add peer connection unit test coverage":
(https://github.com/bitcoin/bitcoin/pull/28749#issuecomment-1787695089)
Re-opened to push an update and re-closed after it was cherry-picked into #28155.

💬 fanquake commented on pull request "test: add peer connection unit test coverage":
(https://github.com/bitcoin/bitcoin/pull/28749#issuecomment-1787698569)
In future, there is no need to reopen and reclose pull requests, for someone to cherry pick a commit out of a branch. Someone can just fetch your remote after you've pushed changes, and cherry-pick what they like.

💬 achow101 commented on pull request "gui: fix crash on selecting "Mask values" in transaction view":
(https://github.com/bitcoin-core/gui/pull/774#issuecomment-1787704366)
Should this be backported?

💬 jonatack commented on pull request "test: add peer connection unit test coverage":
(https://github.com/bitcoin/bitcoin/pull/28749#issuecomment-1787712031)
Yes. It was to allow verifying the CI was green, if desired, prior to cherry-picking.

💬 jonatack commented on pull request "net: improves addnode / m_added_nodes logic":
(https://github.com/bitcoin/bitcoin/pull/28155#issuecomment-1787716146)
re-ACK 0420f99f429ce2382057e101859067f40de47be0

💬 theStack commented on pull request "gui: fix crash on selecting "Mask values" in transaction view":
(https://github.com/bitcoin-core/gui/pull/774#issuecomment-1787748102)
> Should this be backported?

Yes, I think so. The bug first occured with release 25.0 (according to `git tag --contains 4492de1be11` in the main repo), so backporting to 25.x and 26.x would make sense.

💬 achow101 commented on pull request "gui: fix crash on selecting "Mask values" in transaction view":
(https://github.com/bitcoin-core/gui/pull/774#issuecomment-1787761090)
ACK e26e665f9f64a962dd56053be817cc953e714847