💬 sipa commented on pull request "valgrind: remove libsecp256k1 suppression":
(https://github.com/bitcoin/bitcoin/pull/27173#issuecomment-1448482185)
utACK 29b62c01c8d211475ea9dd1a1093820f0a86c06d

💬 MarcoFalke commented on issue "Feature request: alert PR author in case of CI failure":
(https://github.com/bitcoin/bitcoin/issues/27178#issuecomment-1448506275)
Two notes:
* There are still false positives, so in the end a human has to look at the result and figure out whether it needs to be fixed on master or the pull, or none (re-run due to network issue) .
* One can keep a background tab open until it shows the green checkmark.

🚀 glozow merged a pull request: "refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`"
(https://github.com/bitcoin/bitcoin/pull/23897)

🚀 fanquake merged a pull request: "valgrind: remove libsecp256k1 suppression"
(https://github.com/bitcoin/bitcoin/pull/27173)

💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#issuecomment-1448527435)
Maintainers: what else would you like to see for a merge here?

👍 dergoegge approved a pull request: "Make miniscript_{stable,smart} fuzzers avoid too large scripts"
(https://github.com/bitcoin/bitcoin/pull/27165)

👋 fanquake's pull request is ready for review: "guix: pass `--enable-initfini-array` to release GCC"
(https://github.com/bitcoin/bitcoin/pull/27153)

✅ fanquake closed an issue: "miniscript_stable fuzz timeout"
(https://github.com/bitcoin/bitcoin/issues/27147)

🚀 fanquake merged a pull request: "Make miniscript_{stable,smart} fuzzers avoid too large scripts"
(https://github.com/bitcoin/bitcoin/pull/27165)

💬 mzumsande commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1120306670)
`bilingual_str` seems unused

💬 dergoegge commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1448555096)
Concept ACK

💬 dergoegge commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1448575726)
Concept ACK

💬 brunoerg commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1120508531)
it makes sense, I didn't notice it was discarding the previous one, gonna change it. However, I realized we can't always apply this coinbase filter because some tests need to use unconfirmed coinbase utxo (because it's the only available ones).

💬 achow101 commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#issuecomment-1448601870)
> Maintainers: what else would you like to see for a merge here?

Waiting for a couple more reviews.

📝 fanquake opened a pull request: "guix: use osslsigncode 2.5"
(https://github.com/bitcoin/bitcoin/pull/27179)
Switches to using a newer version of [osslsigncode](https://github.com/mtrojnar/osslsigncode) in our Guix environment.

@achow101 can you test this with some sort of WIndows code-signing dry-run (no-rush).

💬 pablomartin4btc commented on pull request "Mask values on Transactions View":
(https://github.com/bitcoin-core/gui/pull/708#issuecomment-1448682269)
> Thinking further about this, if the "privacy" option is enabled, the transactions screen has no usage, thus shouldn't be accessible for the user.

> We could either block the view when the privacy option is enabled, or could create an empty screen image to replace the transactions list when privacy is enabled.

Yeah, I realised what you are saying as soon as I fixed the negative amount issue looking at the type transactions, date-time, addresses columns, the red foreground colour due to th
...

💬 ryanofsky commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#discussion_r1120648056)
re: https://github.com/bitcoin/bitcoin/pull/27150#discussion_r1120039071

Thanks, applied change

💬 ryanofsky commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#discussion_r1120648916)
re: https://github.com/bitcoin/bitcoin/pull/27150#discussion_r1119622390

> nit: s/to whether/whether to/

Thanks, fixed comment

💬 ryanofsky commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#discussion_r1120647673)
re: https://github.com/bitcoin/bitcoin/pull/27150#discussion_r1120047778

Thanks, applied change

💬 pinheadmz commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1120662435)
What's the purpose of this annotation `Any` here?