💬 andrewtoth commented on pull request "net: don't lock cs_main while reading blocks in net processing":
(https://github.com/bitcoin/bitcoin/pull/26326#discussion_r1120198609)
See https://github.com/bitcoin/bitcoin/pull/26326#discussion_r1043171470. Blocks below `MAX_BLOCKTXN_DEPTH` can't be pruned, so we should retain the current behavior if this read fails.

💬 achow101 commented on pull request "ci: bump lint task to bookworm for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#issuecomment-1448344724)
ACK a984beeca10e3ae1ceb3ea53e4dea778160e7079

👍 hebasto approved a pull request: "ci: bump lint task to bookworm for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)
re-ACK a984beeca10e3ae1ceb3ea53e4dea778160e7079

💬 TheCharlatan commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448349530)
ACK 2c9eb4afe1f5

Guix builds:

```
220003bd9c9cb840444494232b01b3d9e17ddda007abfd1b3a1001662b5f24c6 guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/SHA256SUMS.part
cc7f6e969a37d66164aad138635ea4ca1bb30eff2ed59a16c6b4af716824e4f1 guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/bitcoin-2c9eb4afe1f5-aarch64-linux-gnu-debug.tar.gz
6f1afad24db86220a29f8e3ee9170201b5ece045e00ce94d1000f0541a111a4d guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/bitcoin-2c9eb4afe1f5-aarch64-linux-gnu.tar.g
...

💬 fanquake commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448349712)
> Is there an intuition on how much space this will save?

Maybe 10's of megabytes (will get you a number). Saving any space is a nice side-effect, but isn't the primary goal here. The goal is to remove things that are not required in the release build environment, from the release build envionronment. Using available `*-minimal` packages also better communicates the intent of creating a minimal build env.

I would also assume this makes any bootstrapping paths less complicated, as any tools
...

👍 willcl-ark approved a pull request: "docs: GetDataDirNet and GetDataDirBase don't create datadir"
(https://github.com/bitcoin/bitcoin/pull/27176)
ACK fb0dbe942

Thanks for updating these.

💬 brunoerg commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1120264452)
I didn't notice it was descarding the previous one, perhaps we could do:
```py
self._utxos = sorted(self._utxos, key=lambda k: (k['value'], -k['height'])) # Put the largest utxo last
if txid:
utxo_filter = filter(lambda utxo: txid == utxo['txid'], self._utxos)
else:
utxo_filter = reversed(self._utxos) # By default the largest utxo
if not include_immature_coinbase:
utxo_filter = filter(lambda utxo: not utxo['coinbase']
...

🚀 fanquake merged a pull request: "docs: GetDataDirNet and GetDataDirBase don't create datadir"
(https://github.com/bitcoin/bitcoin/pull/27176)

👍 MarcoFalke approved a pull request: "ci: bump lint task to bookworm for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)

💬 achow101 commented on pull request "refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`":
(https://github.com/bitcoin/bitcoin/pull/23897#issuecomment-1448395425)
ACK 75db62ba4cae048e742ca02dc6a52b3b3d6727de

🚀 fanquake merged a pull request: "ci: bump lint task to bookworm for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)

💬 achow101 commented on pull request "refactor: Stop using gArgs global in system.cpp":
(https://github.com/bitcoin/bitcoin/pull/27170#issuecomment-1448418416)
ACK 9a9d5da11fa6033f82dcf8e2298aee29587f5396

💬 fanquake commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-1448424566)
@theStack @grubles can you confirm if this is still an issue, i.e with master or not, and on which systems/OS? Note that you can also use `--enable-suppress-external-warnings` to avoid the Boost build spam.

💬 MarcoFalke commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#discussion_r1120305388)
Is it not possible to call the existing `EnableCategory` and disable functions?

💬 sipa commented on pull request "valgrind: remove libsecp256k1 suppression":
(https://github.com/bitcoin/bitcoin/pull/27173#issuecomment-1448431125)
I'm a bit surprised we had this suppression in the first place; it seems to have been added without any discussion in #17455? libsecp256k1context objects in the Bitcoin Core codebase should always be deleted.

Yet, even if there was a bug around this, or somehow detected incorrectly, it's possible #26691 changed/fixed it (in particular, 4462cb04986d77eddcfc6e8f75e04dc278a8147a, which removed the verification context object).

💬 LarryRuane commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#issuecomment-1448432672)
re-ACK, although now rebase is needed

💬 MarcoFalke commented on pull request "valgrind: remove libsecp256k1 suppression":
(https://github.com/bitcoin/bitcoin/pull/27173#issuecomment-1448435176)
lgtm ACK 29b62c01c8d211475ea9dd1a1093820f0a86c06d

should be trivial to re-add in any case, if it happens again

⚠️ stickies-v opened an issue: "Feature request: alert PR author in case of CI failure"
(https://github.com/bitcoin/bitcoin/issues/27178)
Would be nice to have a means of quickly getting alerted about the CI failing on a PR you authored. It's a bit cumbersome to keep an eye out on it manually, and a freshly created PR typically gets more eyes on it so having it in failing state is a bit of a waste of everyone's time. Creating this issue after brief [IRC discussion](https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2023-02-28#1677593689-1677599148;).

I think the main requirements are:
- be able to opt out or easily ignore/hide
...

🚀 achow101 merged a pull request: "refactor: Stop using gArgs global in system.cpp"
(https://github.com/bitcoin/bitcoin/pull/27170)

💬 fanquake commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448451058)
> Is there an intuition on how much space this will save?

Some insight into any space saving:
```bash
# bash
/gnu/store/5h2w4qi9hk1qzzgi1w83220ydslinr4s-glibc-2.33 38.3 36.6 42.9%
/gnu/store/094bbaq6glba86h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib 71.7 33.4 39.2%
/gnu/store/d99ykvj3axzzidygsmdmzxah4lvxd6hw-bash-5.1.8 85.3 6.2 7.3%
/gnu/store/9rrnm5hdjw7cy96a2a9rfgh6y08wsbmf-ncurses-6.2.20210619 77.6 5.9 7.0%
/gnu/store/720rj90bch716isd8z
...