👍 TheCharlatan approved a pull request: "docs: GetDataDirNet and GetDataDirBase don't create datadir"
(https://github.com/bitcoin/bitcoin/pull/27176)
ACK fb0dbe94233ec509570cbba3118cf62d8e60842b

👍 theStack approved a pull request: "docs: GetDataDirNet and GetDataDirBase don't create datadir"
(https://github.com/bitcoin/bitcoin/pull/27176)
ACK fb0dbe94233ec509570cbba3118cf62d8e60842b

💬 glozow commented on pull request "[ci] bump lint task to lunar for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#discussion_r1120141279)
makes sense to me if bookworm is stable

💬 sipa commented on pull request "Make miniscript_{stable,smart} fuzzers avoid too large scripts":
(https://github.com/bitcoin/bitcoin/pull/27165#discussion_r1120151237)
Done.

💬 sipa commented on pull request "Make miniscript_{stable,smart} fuzzers avoid too large scripts":
(https://github.com/bitcoin/bitcoin/pull/27165#discussion_r1120151749)
I've expanded the comment slightly, mentioning the `FromScript` logic.

💬 achow101 commented on pull request "prune: scan and unlink already pruned block files on startup":
(https://github.com/bitcoin/bitcoin/pull/26533#issuecomment-1448289832)
ACK 3141eab9c669488a2e7fef5f60d356ac92294922

💬 darosior commented on pull request "Make miniscript_{stable,smart} fuzzers avoid too large scripts":
(https://github.com/bitcoin/bitcoin/pull/27165#discussion_r1120162512)
Sorry to block just for a code comment.. But it's in `Parse()` (called by `FromString()`) that we have this logic, not `FromScript` (where we can just check the script size isn't larger than `3600`).

💬 pablomartin4btc commented on pull request "Mask values on Transactions View":
(https://github.com/bitcoin-core/gui/pull/708#issuecomment-1448306040)
> Need to adapt `BitcoinUnits::formatWithPrivacy` function to accept negative amounts. Otherwise, when the wallet make a send, the assertion crashes the software.

Fixed it, thanks.

💬 sipa commented on pull request "Make miniscript_{stable,smart} fuzzers avoid too large scripts":
(https://github.com/bitcoin/bitcoin/pull/27165#discussion_r1120176857)
Fixed.

💬 MarcoFalke commented on pull request "[ci] bump lint task to lunar for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#issuecomment-1448307647)
lgtm ACK 257dfef897db0ece387511d0592076381aaeff2b

The title and commit message can be adjusted to `ci: ...`, if you retouch

💬 glozow commented on pull request "[ci] bump lint task to lunar for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#issuecomment-1448309112)
> lgtm ACK https://github.com/bitcoin/bitcoin/commit/257dfef897db0ece387511d0592076381aaeff2b

sorry, pushed again because commit message still said lunar

💬 darosior commented on pull request "Make miniscript_{stable,smart} fuzzers avoid too large scripts":
(https://github.com/bitcoin/bitcoin/pull/27165#issuecomment-1448313061)
re-ACK 56e37e71a2

💬 MarcoFalke commented on pull request "ci: bump lint task to bookworm for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#discussion_r1120184805)
Yes, the debian tag should be more stable than `lunar`, because it should be around for ~3 years, as opposed to ~1 year for lunar, looking at how long docker hub kept them historically.

(Can be marked as resolved)

💬 MarcoFalke commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1120193686)
Instead of overwriting and discarding the previous filter, it might be better to just set it once. This can be done by nesting the new `if` under a new `elif`.

Another alternative would be to always apply the filter.

🚀 achow101 merged a pull request: "prune: scan and unlink already pruned block files on startup"
(https://github.com/bitcoin/bitcoin/pull/26533)

💬 MarcoFalke commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448325539)
Is there an intuition on how much space this will save? Also, it might be good to check the binaries are identical before and after?

💬 andrewtoth commented on pull request "net: don't lock cs_main while reading blocks in net processing":
(https://github.com/bitcoin/bitcoin/pull/26326#discussion_r1120198609)
See https://github.com/bitcoin/bitcoin/pull/26326#discussion_r1043171470. Blocks below `MAX_BLOCKTXN_DEPTH` can't be pruned, so we should retain the current behavior if this read fails.

💬 achow101 commented on pull request "ci: bump lint task to bookworm for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#issuecomment-1448344724)
ACK a984beeca10e3ae1ceb3ea53e4dea778160e7079

👍 hebasto approved a pull request: "ci: bump lint task to bookworm for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)
re-ACK a984beeca10e3ae1ceb3ea53e4dea778160e7079

💬 TheCharlatan commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448349530)
ACK 2c9eb4afe1f5

Guix builds:

```
220003bd9c9cb840444494232b01b3d9e17ddda007abfd1b3a1001662b5f24c6 guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/SHA256SUMS.part
cc7f6e969a37d66164aad138635ea4ca1bb30eff2ed59a16c6b4af716824e4f1 guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/bitcoin-2c9eb4afe1f5-aarch64-linux-gnu-debug.tar.gz
6f1afad24db86220a29f8e3ee9170201b5ece045e00ce94d1000f0541a111a4d guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/bitcoin-2c9eb4afe1f5-aarch64-linux-gnu.tar.g
...