💬 hebasto commented on pull request "Translatability fixups":
(https://github.com/bitcoin-core/gui/pull/599#issuecomment-1446332571)
> Concept ACK.

> Concept ACK and initial code review ACK [5e23dab](https://github.com/bitcoin-core/gui/commit/5e23dabf2651e49a77954609c303bfc4478ff8f1)

@luke-jr

Mind rebasing this PR before [soft translation string freeze](https://github.com/bitcoin/bitcoin/issues/26549)?

💬 MarcoFalke commented on pull request "contrib: Improve verify-commits.py to work with maintainers leaving":
(https://github.com/bitcoin/bitcoin/pull/27058#issuecomment-1446339062)
This will break the script on all operating systems except the rolling ones like rawhide and tumbleweed?

See also:

subprocess.CalledProcessError: Command '['git', 'merge-tree', 'be2e748f378fc9ed40593a723dd18f2528705956', '14fac808bd6c12bce121011bbf50501960c7326f']' returned non-zero exit status 129.

https://cirrus-ci.com/task/4961884550463488?logs=lint#L242

👍 stickies-v approved a pull request: "Handle invalid hex encoding in ParseHex"
(https://github.com/bitcoin/bitcoin/pull/25227)
re-ACK faab273e060d27e166b5fb7fe7692614ec9e5c76

💬 furszy commented on pull request "wallet: finish addressbook encapsulation":
(https://github.com/bitcoin/bitcoin/pull/26836#issuecomment-1446361158)
Thanks @rserranon.

> why not encapsulate the other calls to wallet->m_address_book[addr_pair.first].purpose = purpose ?

Good catch. I did this changes prior the wallet migration PR merge. Will add those too and make the addressbook member private so we don't keep adding more in the future.

💬 glozow commented on pull request "contrib: Improve verify-commits.py to work with maintainers leaving":
(https://github.com/bitcoin/bitcoin/pull/27058#issuecomment-1446365757)
iiuc reverting 5497c1483097a9b582ef78089a2ce1101b7d722e would make it go away though keeping `merge-tree` would be nice.
Is bumping the lint container to something that gets 2.38 an option for CI?

💬 MarcoFalke commented on pull request "contrib: Improve verify-commits.py to work with maintainers leaving":
(https://github.com/bitcoin/bitcoin/pull/27058#issuecomment-1446372436)
Yeah, should be easy to bump CI to `ubuntu:devel`. Though, I wonder what users are supposed to do?

💬 furszy commented on pull request "wallet: finish addressbook encapsulation":
(https://github.com/bitcoin/bitcoin/pull/26836#discussion_r1118780133)
done

💬 fanquake commented on pull request "I2P network optimizations":
(https://github.com/bitcoin/bitcoin/pull/26837#issuecomment-1446389184)
Added to #26878 for backporting to 24.x.

💬 furszy commented on pull request "wallet: finish addressbook encapsulation":
(https://github.com/bitcoin/bitcoin/pull/26836#issuecomment-1446395076)
Updated per feedback. Now we no longer access the wallet's addressbook member externally.

Plus, improvements to the address book migration process:
1) Fixed a bug where we don't copy the "send" records to all the wallets.
2) Have re-written the process with no code duplication.
3) Batched db writes so the disk dump is done all at once.

💬 fanquake commented on pull request "wallet: be able to specify a wallet name and passphrase to migratewallet":
(https://github.com/bitcoin/bitcoin/pull/26595#issuecomment-1446408587)
Added to #26878 for backporting to 24.x.

💬 glozow commented on pull request "contrib: Improve verify-commits.py to work with maintainers leaving":
(https://github.com/bitcoin/bitcoin/pull/27058#issuecomment-1446412437)
Would it be unreasonable for users to add a ppa and install that way? Also temporary?

💬 sipa commented on pull request "p2p: Batch send NOTFOUND messages":
(https://github.com/bitcoin/bitcoin/pull/26486#issuecomment-1446415216)
I have no further interest in pursuit this, going to close it and mark as up for grabs.

✅ sipa closed a pull request: "p2p: Batch send NOTFOUND messages"
(https://github.com/bitcoin/bitcoin/pull/26486)

🚀 fanquake merged a pull request: "Handle invalid hex encoding in ParseHex"
(https://github.com/bitcoin/bitcoin/pull/25227)

💬 brunoerg commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1118825254)
nit:
```cpp
const bool ret{m_chainman.m_blockman.ReadBlockFromDisk(block, pindex, m_chainparams.GetConsensus())};
```

📝 hebasto opened a pull request: "Update translations for 25.0 string freeze"
(https://github.com/bitcoin/bitcoin/pull/27169)
This PR follows our [Release Process](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md).

Required to open Transifex translations for 25.0 on 2023-03-01 as it's [planned](https://github.com/bitcoin/bitcoin/issues/26549).

**NOTE.** Translations for the following languages for the latest 24.x Transifex resource have been effectively cancelled/damaged/vandalized:
- German (de) by [nesbonk83](https://www.transifex.com/user/profile/nesbonk83/) on 2023-01-27
- Dutch (nl) by
...

💬 hebasto commented on pull request "Update translations for 25.0 string freeze":
(https://github.com/bitcoin/bitcoin/pull/27169#issuecomment-1446432625)
cc @luke-jr @jarolrod @wtogami

💬 hebasto commented on issue "Release schedule for 25.0":
(https://github.com/bitcoin/bitcoin/issues/26549#issuecomment-1446439957)
> ## 2023-03-01 construction
>
> - Open Transifex translations for 25.0

See #27169.

---

@GregTonoski
> What is the "23.0" in the sentence: "Finalize and close translations for 23.0"? Isn't it a typo, perhaps?

That's correct. See https://www.transifex.com/bitcoin/bitcoin/content/.

✅ fanquake closed an issue: "`libbitcoinkernel`: Building `mingw-w64` dll's broken"
(https://github.com/bitcoin/bitcoin/issues/25008)

✅ fanquake closed an issue: "build: Cross-compiling libbitcoinconsensus for Windows fails with DEBUG=1"
(https://github.com/bitcoin/bitcoin/issues/19772)