💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297744944)
> Why stop doing extra block-relay peers in this situation?
Because, in the stalling scenario, we not only need to progress at the chain level, we might also need to receive new addresses from the network. And block-relay-only connections are limited in that sense. The node rejects addresses coming from them.
> If for whatever reason our current peers aren't able to send us the blocks to get us out of this situation, maybe trying an additional one will.
Thats basically what we currently
...
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297744944)
> Why stop doing extra block-relay peers in this situation?
Because, in the stalling scenario, we not only need to progress at the chain level, we might also need to receive new addresses from the network. And block-relay-only connections are limited in that sense. The node rejects addresses coming from them.
> If for whatever reason our current peers aren't able to send us the blocks to get us out of this situation, maybe trying an additional one will.
Thats basically what we currently
...
⚠️ mzumsande opened an issue: "Intermittent failure in feature_config_args.py"
(https://github.com/bitcoin/bitcoin/issues/28290)
https://cirrus-ci.com/task/5383892962639872?logs=ci#L7698
```
2023-08-17T20:59:43.754000Z TestFramework (INFO): Test seed peers
2023-08-17T21:03:45.922000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
self.run_test()
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_config_
...
(https://github.com/bitcoin/bitcoin/issues/28290)
https://cirrus-ci.com/task/5383892962639872?logs=ci#L7698
```
2023-08-17T20:59:43.754000Z TestFramework (INFO): Test seed peers
2023-08-17T21:03:45.922000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
self.run_test()
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_config_
...
💬 kevkevinpal commented on pull request "init: changing -torcontrol help to specify that a default port is used":
(https://github.com/bitcoin/bitcoin/pull/28101#discussion_r1297759286)
Update in e5f20cb26848c97d48c6a479c4680f6823f2ec1e
(https://github.com/bitcoin/bitcoin/pull/28101#discussion_r1297759286)
Update in e5f20cb26848c97d48c6a479c4680f6823f2ec1e
💬 murchandamus commented on pull request "Bump unconfirmed ancestor transactions to target feerate":
(https://github.com/bitcoin/bitcoin/pull/26152#discussion_r1297760127)
Okay, I replaced `GetSummedBumpFees()` with `GetTotalBumpFees()` which deducts the `bump_fee_discount` if it has been set.
(https://github.com/bitcoin/bitcoin/pull/26152#discussion_r1297760127)
Okay, I replaced `GetSummedBumpFees()` with `GetTotalBumpFees()` which deducts the `bump_fee_discount` if it has been set.
💬 murchandamus commented on pull request "Bump unconfirmed ancestor transactions to target feerate":
(https://github.com/bitcoin/bitcoin/pull/26152#discussion_r1297768542)
Removed SSFO from this test
(https://github.com/bitcoin/bitcoin/pull/26152#discussion_r1297768542)
Removed SSFO from this test
💬 murchandamus commented on pull request "Bump unconfirmed ancestor transactions to target feerate":
(https://github.com/bitcoin/bitcoin/pull/26152#issuecomment-1683003630)
I believe that I have now addressed all open feedback. Ready for review
(https://github.com/bitcoin/bitcoin/pull/26152#issuecomment-1683003630)
I believe that I have now addressed all open feedback. Ready for review
🤔 jonatack reviewed a pull request: "init: changing -torcontrol help to specify that a default port is used"
(https://github.com/bitcoin/bitcoin/pull/28101#pullrequestreview-1583526315)
ACK e5f20cb26848c97d48c6a479c4680f6823f2ec1e
It might be good to prefix the pull title with `doc, refactor:` instead of `init`.
(https://github.com/bitcoin/bitcoin/pull/28101#pullrequestreview-1583526315)
ACK e5f20cb26848c97d48c6a479c4680f6823f2ec1e
It might be good to prefix the pull title with `doc, refactor:` instead of `init`.
💬 jonatack commented on pull request "init: changing -torcontrol help to specify that a default port is used":
(https://github.com/bitcoin/bitcoin/pull/28101#discussion_r1297772924)
If you retouch, can remove this added newline.
(https://github.com/bitcoin/bitcoin/pull/28101#discussion_r1297772924)
If you retouch, can remove this added newline.
💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297791137)
Yeah. Sure for both.
Not sure why I hardcoded the number..
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297791137)
Yeah. Sure for both.
Not sure why I hardcoded the number..
💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297796093)
> Was it just outdated already? I'm confused by what NODE_NONE meant here before this change.
It was talking about the input `ServiceFlags`. Not the `GetDesirableServiceFlags()` output.
Basically, we expect to have all the hardcoded seeds supporting `NODE_NETWORK` and `NODE_WITNESS`.
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297796093)
> Was it just outdated already? I'm confused by what NODE_NONE meant here before this change.
It was talking about the input `ServiceFlags`. Not the `GetDesirableServiceFlags()` output.
Basically, we expect to have all the hardcoded seeds supporting `NODE_NETWORK` and `NODE_WITNESS`.
💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297797152)
yeah sure.
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297797152)
yeah sure.
💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297802187)
> The comment ("shortcut for...") was helpful for me, any reason to drop it?
That was because the method was moved to the net interface ([see](https://github.com/bitcoin/bitcoin/blob/1428b7f4e8c648fdc68ba5744d640d120d5d78eb/src/net.h#L673)). And there, this is no longer a shortcut. It is the only available method.
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297802187)
> The comment ("shortcut for...") was helpful for me, any reason to drop it?
That was because the method was moved to the net interface ([see](https://github.com/bitcoin/bitcoin/blob/1428b7f4e8c648fdc68ba5744d640d120d5d78eb/src/net.h#L673)). And there, this is no longer a shortcut. It is the only available method.
👍 theStack approved a pull request: "crypto: more `Span<std::byte>` modernization & follow-ups"
(https://github.com/bitcoin/bitcoin/pull/28100#pullrequestreview-1583609952)
re-ACK 57cc136282c38825e97bbf85728df4bdf1ccc648
(CI failure is unrelated)
(https://github.com/bitcoin/bitcoin/pull/28100#pullrequestreview-1583609952)
re-ACK 57cc136282c38825e97bbf85728df4bdf1ccc648
(CI failure is unrelated)
💬 ajtowns commented on pull request "rpc: Add Arg() default helper":
(https://github.com/bitcoin/bitcoin/pull/28230#discussion_r1297864956)
Okay, you nerdsniped me successfully. https://github.com/ajtowns/bitcoin/blob/9f332c93bcf7c2a1a4796dda4d2304014b10037e/src/rpc/util.cpp#L684-L705
(https://github.com/bitcoin/bitcoin/pull/28230#discussion_r1297864956)
Okay, you nerdsniped me successfully. https://github.com/ajtowns/bitcoin/blob/9f332c93bcf7c2a1a4796dda4d2304014b10037e/src/rpc/util.cpp#L684-L705
💬 ajtowns commented on pull request "p2p: Drop m_recently_announced_invs bloom filter":
(https://github.com/bitcoin/bitcoin/pull/27675#discussion_r1297922908)
Unique for any tx and strictly monotonically increasing for child txs would also be violated for accepting packages to the mempool, I think.
(https://github.com/bitcoin/bitcoin/pull/27675#discussion_r1297922908)
Unique for any tx and strictly monotonically increasing for child txs would also be violated for accepting packages to the mempool, I think.
💬 ajtowns commented on issue "Auto detect IPv6 connectivity":
(https://github.com/bitcoin/bitcoin/issues/28061#issuecomment-1683257963)
> That is the case currently as well: `ifconfig eth0 up/down` and IPv4 or IPv6 connectivity comes and goes. Tor or I2P or CJDNS router restart - same, at runtime.
Sure: but the way that works is if you configure bitcoind for tor/i2p/etc, and if it goes down for a while, bitcoind will continue working once it comes back up again (and emit log messages about it in the meantime). ipv6 handling shouldn't be worse than that.
(https://github.com/bitcoin/bitcoin/issues/28061#issuecomment-1683257963)
> That is the case currently as well: `ifconfig eth0 up/down` and IPv4 or IPv6 connectivity comes and goes. Tor or I2P or CJDNS router restart - same, at runtime.
Sure: but the way that works is if you configure bitcoind for tor/i2p/etc, and if it goes down for a while, bitcoind will continue working once it comes back up again (and emit log messages about it in the meantime). ipv6 handling shouldn't be worse than that.
📝 russeree opened a pull request: "removed StrFormatInternalBug quote delimitation"
(https://github.com/bitcoin/bitcoin/pull/28291)
This PR rectifies an unnecessary set of quotes delimiting the contents of ```StrFormatInternalBug```. This is a follow up to @MarcoFalke https://github.com/bitcoin/bitcoin/pull/28123#discussion_r1297191493. The method of action was to remove the escaped quotes that were a part of strprintf. A single functional test case was modified to reflect the new output format.
The results can be seen below.
Previously
This PR rectifies an unnecessary set of quotes delimiting the contents of ```StrFormatInternalBug```. This is a follow up to @MarcoFalke https://github.com/bitcoin/bitcoin/pull/28123#discussion_r1297191493. The method of action was to remove the escaped quotes that were a part of strprintf. A single functional test case was modified to reflect the new output format.
The results can be seen below.
Previously
![image](https://github.com/bitcoin/bitcoin/assets/3104223/53f9ea59-317f-4c62-
...
💬 ajtowns commented on pull request "Update MANDATORY_SCRIPT_VERIFY_FLAGS":
(https://github.com/bitcoin/bitcoin/pull/26291#discussion_r1297949804)
Done
(https://github.com/bitcoin/bitcoin/pull/26291#discussion_r1297949804)
Done
💬 ajtowns commented on pull request "Update MANDATORY_SCRIPT_VERIFY_FLAGS":
(https://github.com/bitcoin/bitcoin/pull/26291#issuecomment-1683303626)
First commit from this has been merged via #28244; rebased on top of that. See #28285 or #28289 for CI failure.
(https://github.com/bitcoin/bitcoin/pull/26291#issuecomment-1683303626)
First commit from this has been merged via #28244; rebased on top of that. See #28285 or #28289 for CI failure.
📝 russeree converted_to_draft a pull request: "rpc: removed StrFormatInternalBug quote delimitation"
(https://github.com/bitcoin/bitcoin/pull/28291)
This PR rectifies an unnecessary set of quotes delimiting the contents of ```StrFormatInternalBug```. This is a follow up to @MarcoFalke https://github.com/bitcoin/bitcoin/pull/28123#discussion_r1297191493. The method of action was to remove the escaped quotes that were a part of strprintf. A single functional test case was modified to reflect the new output format.
The results can be seen below.
Previously
This PR rectifies an unnecessary set of quotes delimiting the contents of ```StrFormatInternalBug```. This is a follow up to @MarcoFalke https://github.com/bitcoin/bitcoin/pull/28123#discussion_r1297191493. The method of action was to remove the escaped quotes that were a part of strprintf. A single functional test case was modified to reflect the new output format.
The results can be seen below.
Previously
![image](https://github.com/bitcoin/bitcoin/assets/3104223/53f9ea59-317f-4c62-
...