💬 MarcoFalke commented on pull request "Bugfix: RPC: Remove quotes from non-string oneline descriptions":
(https://github.com/bitcoin/bitcoin/pull/28123#discussion_r1297191493)
@russeree Do you want to create a follow-up pull with the changes?

🚀 fanquake merged a pull request: "ci: Ensure that only a single workflow processes `github.ref` at a time"
(https://github.com/bitcoin/bitcoin/pull/28282)

💬 mzumsande commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297205559)
If for whatever reason our current peers aren't able to send us the blocks to get us out of this situation, maybe trying an additional one will.

🚀 fanquake merged a pull request: "ci: Refactor: Remove CI_USE_APT_INSTALL"
(https://github.com/bitcoin/bitcoin/pull/28278)

💬 mzumsande commented on pull request "p2p: Restrict self-advertisements with privacy networks to avoid fingerprinting":
(https://github.com/bitcoin/bitcoin/pull/27411#issuecomment-1682292653)
> Should this be added to the release notes?

Not sure. I think the impact on users isn't that strong (it fixes behavior in rather rare constellations), so I wouldn't have added it. But happy to add it, if others would like it included!

💬 hebasto commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#issuecomment-1682299313)
> Also, it looks like CI tasks currently need approval from a maintainer to run at all from non-members. See [docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks](https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks)

It is a configurable setting.

💬 hebasto commented on pull request "ci: Ensure that only a single workflow processes `github.ref` at a time":
(https://github.com/bitcoin/bitcoin/pull/28282#issuecomment-1682303626)
> Could do the same in the secp repo?

Sure! Done in https://github.com/bitcoin-core/secp256k1/pull/1403.

💬 dergoegge commented on issue "meta: Isolated fuzzing of net processing":
(https://github.com/bitcoin/bitcoin/issues/27502#issuecomment-1682331240)
> I wonder if it would make sense to have a ... `PeerManChainPoolInterface`

Yea that is what I had in mind as well and what I was alluding to by "net processing / validation split" in the PR description. Alternatively we could work on making the actual mempool/chainman interfaces mockable/more abstract but that might be more work and would also interfere with kernel.

For the `PeerManChainPoolInterface` approach, I would probably go with a separate interface for mempool and chainman but th
...

📝 MarcoFalke opened a pull request: "refactor: Remove confusing static_cast in address types"
(https://github.com/bitcoin/bitcoin/pull/28284)
It seems confusing to use `static_cast<uint160>(bla)` to call the constructor of `uint160`. The normal and common way to call a constructor is by simply calling it. (`uint160{bla}`).

Do this, and also drop the constructor completely where the existing `const&` reference is enough.

Also, add missing includes while touching the file.

💬 achow101 commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#issuecomment-1682341523)
> > Also, it looks like CI tasks currently need approval from a maintainer to run at all from non-members. See [docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks](https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks)
>
> It is a configurable setting.

It's currently set to "Require approval for first-time contributors". Could change that to "Require approval for first-time contributors who are new to Gi
...

💬 MarcoFalke commented on pull request "Break up script/standard.{h/cpp}":
(https://github.com/bitcoin/bitcoin/pull/28244#discussion_r1297268615)
Fixed in https://github.com/bitcoin/bitcoin/pull/28284

💬 MarcoFalke commented on pull request "Break up script/standard.{h/cpp}":
(https://github.com/bitcoin/bitcoin/pull/28244#discussion_r1297269129)
Fixed in https://github.com/bitcoin/bitcoin/pull/28284

💬 MarcoFalke commented on pull request "Break up script/standard.{h/cpp}":
(https://github.com/bitcoin/bitcoin/pull/28244#discussion_r1297269303)
Fixed in https://github.com/bitcoin/bitcoin/pull/28284

💬 MarcoFalke commented on pull request "Break up script/standard.{h/cpp}":
(https://github.com/bitcoin/bitcoin/pull/28244#discussion_r1297269484)
Fixed in https://github.com/bitcoin/bitcoin/pull/28284

💬 sipa commented on pull request "Break up script/standard.{h/cpp}":
(https://github.com/bitcoin/bitcoin/pull/28244#issuecomment-1682347085)
Posthumous concept ACK

💬 ajtowns commented on issue "meta: Isolated fuzzing of net processing":
(https://github.com/bitcoin/bitcoin/issues/27502#issuecomment-1682349394)
I think even just having it as documentation of what parts of mempool/validation are used by net would be interesting -- I don't think the boundary there is entirely clean; eg the `CompareInvMempoolOrder` stuff could probably be moved to txmempool.

👋 brunoerg's pull request is ready for review: "fuzz: call `LookupSubNet` before calling `Ban` with a subnet"
(https://github.com/bitcoin/bitcoin/pull/27935)

💬 brunoerg commented on pull request "fuzz: call lookup functions before calling `Ban`":
(https://github.com/bitcoin/bitcoin/pull/27935#issuecomment-1682367492)
Thanks for review @dergoegge. I noted that we also need to call `LookupHost` when banning with `CNetAddr`. Just updated the PR description and title.

Also, this way we're closer to the reality (following what RPC does to set it).

✅ MarcoFalke closed an issue: "ci: Future of macOS and Windows MSVC CI tasks"
(https://github.com/bitcoin/bitcoin/issues/28098)

💬 MarcoFalke commented on issue "ci: Future of macOS and Windows MSVC CI tasks":
(https://github.com/bitcoin/bitcoin/issues/28098#issuecomment-1682367879)
Closing for now. macOS has been merged and Windows can be discussed in the already open pull: https://github.com/bitcoin/bitcoin/pull/28173

For other issues or new issues, a new issue can be opened.